Re: [PATCH] media: qcom: camss: vfe: fix PIX subdev naming on VFE lite

[Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>]

On 3/19/2026 10:44 PM, Loic Poulain wrote:
> On Thu, Mar 19, 2026 at 10:11 AM Wenmeng Liu
> <wenmeng.liu@oss.qualcomm.com> wrote:
>>
>> VFE lite hardware does not provide a functional PIX path, but after
>> the per sub-device type resource changes the PIX subdev name is still
>> assigned unconditionally.
>>
>> Only assign the PIX subdev name on non-lite VFE variants to avoid
>> exposing a misleading device name.
>>
>> Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources")
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
>> ---
>>   drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
>> index 5baf0e3d4bc461df28d8dcf97a98dec04fa17ceb..2ee4f9ae0ab50e22f916736f1d1664767bdb6a36 100644
>> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
>> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
>> @@ -2053,7 +2053,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,
>>                  v4l2_subdev_init(sd, &vfe_v4l2_ops);
>>                  sd->internal_ops = &vfe_v4l2_internal_ops;
>>                  sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
>> -               if (i == VFE_LINE_PIX)
>> +               if (i == VFE_LINE_PIX && vfe->res->is_lite == false)
>>                          snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s",
>>                                   MSM_VFE_NAME, vfe->id, "pix");
> 
> So the PIX path will be called RDI? Doesn’t that seem misleading as well?
when i == VFE_LINE_PIX and vfe->res->is_lite == false then vfe name is 
pix, not rdi.

thanks,
Wenmeng