ipt_random

ipt_random

[Ming-Ching Tiew]

It seems that the random patch for patch-o-matic for 2.6 kernel
existed long time ago but it is still not inside the latest patch-o-matic
snapshot. May I know why ?

Cheers

Re: ipt_random

[Jan Engelhardt]

>It seems that the random patch for patch-o-matic for 2.6 kernel
>existed long time ago but it is still not inside the latest patch-o-matic
>snapshot. May I know why ?

12:16 linux01:~ > tar -xvjf patch-o-matic-ng-20050718.tar.bz2 | grep random
patch-o-matic-ng-20050718/patchlets/random/
patch-o-matic-ng-20050718/patchlets/random/linux/include/linux/netfilter_ipv4/ip
t_random.h
(output reduced)


It's there...



Jan Engelhardt
-- 
| Alphagate Systems, http://alphagate.hopto.org/

Re: ipt_random

[Ming-Ching Tiew]

From: "Jan Engelhardt" <jengelh@linux01.gwdg.de>

> 
> >It seems that the random patch for patch-o-matic for 2.6 kernel
> >existed long time ago but it is still not inside the latest patch-o-matic
> >snapshot. May I know why ?
> 
> 12:16 linux01:~ > tar -xvjf patch-o-matic-ng-20050718.tar.bz2 | grep random
> patch-o-matic-ng-20050718/patchlets/random/
> patch-o-matic-ng-20050718/patchlets/random/linux/include/linux/netfilter_ipv4/ip
> t_random.h

That's a 2.4 kernel patch. I am referring to 2.6 kernel. 

Cheers.

Re: ipt_random

[Jan Engelhardt]

>> >It seems that the random patch for patch-o-matic for 2.6 kernel
>> >existed long time ago but it is still not inside the latest patch-o-matic
>> >snapshot. May I know why ?
>> 
>> 12:16 linux01:~ > tar -xvjf patch-o-matic-ng-20050718.tar.bz2 | grep random
>> patch-o-matic-ng-20050718/patchlets/random/
>> patch-o-matic-ng-20050718/patchlets/random/linux/include/linux/netfilter_ipv4/ip
>> t_random.h
>
>That's a 2.4 kernel patch. I am referring to 2.6 kernel. 

07:11 linux01:../random/linux > l net/ipv4/netfilter/
total 24
drwxr-xr-x    2 jengelh  users        4096 2005-07-19 23:55 .
drwxr-xr-x    3 jengelh  users        4096 2005-07-19 23:55 ..
-rw-r--r--    1 jengelh  users         172 2003-12-18 19:28 Config.in.ladd
-rw-r--r--    1 jengelh  users        2236 2003-12-18 19:28 ipt_random.c
-rw-r--r--    1 jengelh  users         326 2004-05-06 15:27 Kconfig.ladd
-rw-r--r--    1 jengelh  users          93 2003-12-18 19:28 Makefile.ladd
07:11 linux01:../random/linux > pwd
/home/jengelh/patch-o-matic-ng-20050719/patchlets/random/linux

Given that there is Kconfig, this patch _is_ also for 2.6.


Jan Engelhardt
-- 

Re: ipt_random

[Ming-Ching Tiew]

From: "Jan Engelhardt" <jengelh@linux01.gwdg.de>
> 
> 07:11 linux01:../random/linux > l net/ipv4/netfilter/
> total 24
> drwxr-xr-x    2 jengelh  users        4096 2005-07-19 23:55 .
> drwxr-xr-x    3 jengelh  users        4096 2005-07-19 23:55 ..
> -rw-r--r--    1 jengelh  users         172 2003-12-18 19:28 Config.in.ladd
> -rw-r--r--    1 jengelh  users        2236 2003-12-18 19:28 ipt_random.c
> -rw-r--r--    1 jengelh  users         326 2004-05-06 15:27 Kconfig.ladd
> -rw-r--r--    1 jengelh  users          93 2003-12-18 19:28 Makefile.ladd
> 07:11 linux01:../random/linux > pwd
> /home/jengelh/patch-o-matic-ng-20050719/patchlets/random/linux
> 
> Given that there is Kconfig, this patch _is_ also for 2.6.
> 

Too bad that's not how the patch-o-matic scripts are written. It will not
patch the kernel source, if it did not follow certain directory structure.

That's how the patch-o-matic 'runme --batch' behaves, if what I have
tried is correct.

Re: ipt_random

[Jan Engelhardt]

>Too bad that's not how the patch-o-matic scripts are written. It will not
>patch the kernel source, if it did not follow certain directory structure.
>
>That's how the patch-o-matic 'runme --batch' behaves, if what I have
>tried is correct.

I usually dont use runme, because I'm almost sure it creates rejectfiles 
nonetheless given the kernel I use. So I copy the files and merge the *.ladd 
files by hand. Voil`a. Note that I do use ipt_random actively, so it 
definitely works on 2.6.x.



Jan Engelhardt
-- 

Re: ipt_random

[Ming-Ching Tiew]

From: "Jan Engelhardt" <jengelh@linux01.gwdg.de>
> 
> >Too bad that's not how the patch-o-matic scripts are written. It will not
> >patch the kernel source, if it did not follow certain directory structure.
> >
> >That's how the patch-o-matic 'runme --batch' behaves, if what I have
> >tried is correct.
> 
> I usually dont use runme, because I'm almost sure it creates rejectfiles 
> nonetheless given the kernel I use. So I copy the files and merge the *.ladd 
> files by hand. Voil`a. Note that I do use ipt_random actively, so it 
> definitely works on 2.6.x.
> 

If you have small work  you could copy here and there. As soon as
you have a few patches to apply, it will become very laborious and
error proned. That's the whole purpose of 'runme'.

Any the contrary, I use 'runme' as it guarantees me certain minimum
repeatable quality.

Anyway, thanks for letting me know about the quality of the ipt_random.c
on 2.6 kernel. I actually found another patch, 

https://lists.netfilter.org/pipermail/ netfilter-devel/2004-November/017491.html 

Cheers.

Re: ipt_random

[Jozsef Kadlecsik]

On Wed, 20 Jul 2005, Ming-Ching Tiew wrote:

> > Given that there is Kconfig, this patch _is_ also for 2.6.
>
> Too bad that's not how the patch-o-matic scripts are written. It will not
> patch the kernel source, if it did not follow certain directory structure.

Actually, it's not the directory structure but the info file which
prevents the patch to show up and offered for 2.6 kernels. I've added the
missing 2.6 port to the svn tree.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@sunserv.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary