* [PATCH] ARM: DTS: correct the capability string for mmc0
@ 2014-06-23 11:20 ` Naveen Krishna Chatradhi
0 siblings, 0 replies; 8+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-23 11:20 UTC (permalink / raw)
To: kgene.kim, linux-samsung-soc, linux-arm-kernel; +Cc: cpgs, devicetree
MMC capability for HS200 is parsed in mmc/core/host.c as
dts string "mmc-hs200-1_8v".
This patch corrects the dts string for Exynos5420 based peach-pit
and Exynos5800 based peach-pi boards.
Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 7649982..7dea480 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -173,7 +173,7 @@
status = "okay";
num-slots = <1>;
broken-cd;
- caps2-mmc-hs200-1_8v;
+ mmc-hs200-1_8v;
supports-highspeed;
non-removable;
card-detect-delay = <200>;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 2c2c137..bb3ee76 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -171,7 +171,7 @@
status = "okay";
num-slots = <1>;
broken-cd;
- caps2-mmc-hs200-1_8v;
+ mmc-hs200-1_8v;
supports-highspeed;
non-removable;
card-detect-delay = <200>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ARM: DTS: correct the capability string for mmc0
@ 2014-06-23 11:20 ` Naveen Krishna Chatradhi
0 siblings, 0 replies; 8+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-23 11:20 UTC (permalink / raw)
To: linux-arm-kernel
MMC capability for HS200 is parsed in mmc/core/host.c as
dts string "mmc-hs200-1_8v".
This patch corrects the dts string for Exynos5420 based peach-pit
and Exynos5800 based peach-pi boards.
Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
---
arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 7649982..7dea480 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -173,7 +173,7 @@
status = "okay";
num-slots = <1>;
broken-cd;
- caps2-mmc-hs200-1_8v;
+ mmc-hs200-1_8v;
supports-highspeed;
non-removable;
card-detect-delay = <200>;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 2c2c137..bb3ee76 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -171,7 +171,7 @@
status = "okay";
num-slots = <1>;
broken-cd;
- caps2-mmc-hs200-1_8v;
+ mmc-hs200-1_8v;
supports-highspeed;
non-removable;
card-detect-delay = <200>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH] ARM: DTS: correct the capability string for mmc0
2014-06-23 11:20 ` Naveen Krishna Chatradhi
@ 2014-06-23 11:36 ` Kukjin Kim
-1 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2014-06-23 11:36 UTC (permalink / raw)
To: 'Naveen Krishna Chatradhi', linux-samsung-soc,
linux-arm-kernel
Cc: devicetree
Naveen Krishna Chatradhi wrote:
>
> MMC capability for HS200 is parsed in mmc/core/host.c as
> dts string "mmc-hs200-1_8v".
>
> This patch corrects the dts string for Exynos5420 based peach-pit
> and Exynos5800 based peach-pi boards.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-
> peach-pit.dts
> index 7649982..7dea480 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -173,7 +173,7 @@
> status = "okay";
> num-slots = <1>;
> broken-cd;
> - caps2-mmc-hs200-1_8v;
> + mmc-hs200-1_8v;
> supports-highspeed;
> non-removable;
> card-detect-delay = <200>;
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-
> peach-pi.dts
> index 2c2c137..bb3ee76 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -171,7 +171,7 @@
> status = "okay";
> num-slots = <1>;
> broken-cd;
> - caps2-mmc-hs200-1_8v;
> + mmc-hs200-1_8v;
> supports-highspeed;
> non-removable;
> card-detect-delay = <200>;
> --
> 1.7.9.5
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: DTS: correct the capability string for mmc0
@ 2014-06-23 11:36 ` Kukjin Kim
0 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2014-06-23 11:36 UTC (permalink / raw)
To: linux-arm-kernel
Naveen Krishna Chatradhi wrote:
>
> MMC capability for HS200 is parsed in mmc/core/host.c as
> dts string "mmc-hs200-1_8v".
>
> This patch corrects the dts string for Exynos5420 based peach-pit
> and Exynos5800 based peach-pi boards.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-
> peach-pit.dts
> index 7649982..7dea480 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -173,7 +173,7 @@
> status = "okay";
> num-slots = <1>;
> broken-cd;
> - caps2-mmc-hs200-1_8v;
> + mmc-hs200-1_8v;
> supports-highspeed;
> non-removable;
> card-detect-delay = <200>;
> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-
> peach-pi.dts
> index 2c2c137..bb3ee76 100644
> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> @@ -171,7 +171,7 @@
> status = "okay";
> num-slots = <1>;
> broken-cd;
> - caps2-mmc-hs200-1_8v;
> + mmc-hs200-1_8v;
> supports-highspeed;
> non-removable;
> card-detect-delay = <200>;
> --
> 1.7.9.5
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ARM: DTS: correct the capability string for mmc0
2014-06-23 11:36 ` Kukjin Kim
@ 2014-06-24 21:33 ` Doug Anderson
-1 siblings, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2014-06-24 21:33 UTC (permalink / raw)
To: Kukjin Kim
Cc: Naveen Krishna Chatradhi, linux-samsung-soc,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Javier Martinez Canillas, Kevin Hilman, Olof Johansson,
Jaehoon Chung, Seungwon Jeon, Chris Ball
Hi,
On Mon, Jun 23, 2014 at 4:36 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Naveen Krishna Chatradhi wrote:
>>
>> MMC capability for HS200 is parsed in mmc/core/host.c as
>> dts string "mmc-hs200-1_8v".
>>
>> This patch corrects the dts string for Exynos5420 based peach-pit
>> and Exynos5800 based peach-pi boards.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-
>> peach-pit.dts
>> index 7649982..7dea480 100644
>> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> @@ -173,7 +173,7 @@
>> status = "okay";
>> num-slots = <1>;
>> broken-cd;
>> - caps2-mmc-hs200-1_8v;
>> + mmc-hs200-1_8v;
>> supports-highspeed;
>> non-removable;
>> card-detect-delay = <200>;
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-
>> peach-pi.dts
>> index 2c2c137..bb3ee76 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -171,7 +171,7 @@
>> status = "okay";
>> num-slots = <1>;
>> broken-cd;
>> - caps2-mmc-hs200-1_8v;
>> + mmc-hs200-1_8v;
>> supports-highspeed;
>> non-removable;
>> card-detect-delay = <200>;
>> --
>> 1.7.9.5
>
> Applied, thanks.
As an FYI: this patch (while correct) will likely cause sporadic boot
failures until Sonny and my patches land:
* https://patchwork.kernel.org/patch/4323921/
mmc: dw_mmc: Make sure we don't get stuck when we get an error
* https://patchwork.kernel.org/patch/4213211/
mmc: dw_mmc: change to use recommended reset procedure
In the very least we got sporadic boot failures locally when we
enabled hs200 and didn't have the "don't get stuck" patch. I will
also note that it would have been nice had this patch title included
the words exynos and/or pit/pi in it.
-Doug
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: DTS: correct the capability string for mmc0
@ 2014-06-24 21:33 ` Doug Anderson
0 siblings, 0 replies; 8+ messages in thread
From: Doug Anderson @ 2014-06-24 21:33 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Mon, Jun 23, 2014 at 4:36 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Naveen Krishna Chatradhi wrote:
>>
>> MMC capability for HS200 is parsed in mmc/core/host.c as
>> dts string "mmc-hs200-1_8v".
>>
>> This patch corrects the dts string for Exynos5420 based peach-pit
>> and Exynos5800 based peach-pi boards.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-
>> peach-pit.dts
>> index 7649982..7dea480 100644
>> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
>> @@ -173,7 +173,7 @@
>> status = "okay";
>> num-slots = <1>;
>> broken-cd;
>> - caps2-mmc-hs200-1_8v;
>> + mmc-hs200-1_8v;
>> supports-highspeed;
>> non-removable;
>> card-detect-delay = <200>;
>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-
>> peach-pi.dts
>> index 2c2c137..bb3ee76 100644
>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
>> @@ -171,7 +171,7 @@
>> status = "okay";
>> num-slots = <1>;
>> broken-cd;
>> - caps2-mmc-hs200-1_8v;
>> + mmc-hs200-1_8v;
>> supports-highspeed;
>> non-removable;
>> card-detect-delay = <200>;
>> --
>> 1.7.9.5
>
> Applied, thanks.
As an FYI: this patch (while correct) will likely cause sporadic boot
failures until Sonny and my patches land:
* https://patchwork.kernel.org/patch/4323921/
mmc: dw_mmc: Make sure we don't get stuck when we get an error
* https://patchwork.kernel.org/patch/4213211/
mmc: dw_mmc: change to use recommended reset procedure
In the very least we got sporadic boot failures locally when we
enabled hs200 and didn't have the "don't get stuck" patch. I will
also note that it would have been nice had this patch title included
the words exynos and/or pit/pi in it.
-Doug
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] ARM: DTS: correct the capability string for mmc0
2014-06-24 21:33 ` Doug Anderson
@ 2014-06-25 11:19 ` Kukjin Kim
-1 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2014-06-25 11:19 UTC (permalink / raw)
To: 'Doug Anderson'
Cc: 'Naveen Krishna Chatradhi', 'linux-samsung-soc',
linux-arm-kernel, devicetree, 'Javier Martinez Canillas',
'Kevin Hilman', 'Olof Johansson',
'Jaehoon Chung', 'Seungwon Jeon',
'Chris Ball'
Doug Anderson wrote:
>
> Hi,
>
Hi,
> On Mon, Jun 23, 2014 at 4:36 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Naveen Krishna Chatradhi wrote:
> >>
> >> MMC capability for HS200 is parsed in mmc/core/host.c as
> >> dts string "mmc-hs200-1_8v".
> >>
> >> This patch corrects the dts string for Exynos5420 based peach-pit
> >> and Exynos5800 based peach-pi boards.
> >>
> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> >> ---
> >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
> >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> b/arch/arm/boot/dts/exynos5420-
> >> peach-pit.dts
> >> index 7649982..7dea480 100644
> >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> >> @@ -173,7 +173,7 @@
> >> status = "okay";
> >> num-slots = <1>;
> >> broken-cd;
> >> - caps2-mmc-hs200-1_8v;
> >> + mmc-hs200-1_8v;
> >> supports-highspeed;
> >> non-removable;
> >> card-detect-delay = <200>;
> >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> b/arch/arm/boot/dts/exynos5800-
> >> peach-pi.dts
> >> index 2c2c137..bb3ee76 100644
> >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> >> @@ -171,7 +171,7 @@
> >> status = "okay";
> >> num-slots = <1>;
> >> broken-cd;
> >> - caps2-mmc-hs200-1_8v;
> >> + mmc-hs200-1_8v;
> >> supports-highspeed;
> >> non-removable;
> >> card-detect-delay = <200>;
> >> --
> >> 1.7.9.5
> >
> > Applied, thanks.
>
> As an FYI: this patch (while correct) will likely cause sporadic boot
> failures until Sonny and my patches land:
>
Thanks for your kindly information.
As I replied on other patch, I will holding on until followings land.
> * https://patchwork.kernel.org/patch/4323921/
> mmc: dw_mmc: Make sure we don't get stuck when we get an error
>
> * https://patchwork.kernel.org/patch/4213211/
> mmc: dw_mmc: change to use recommended reset procedure
>
> In the very least we got sporadic boot failures locally when we
> enabled hs200 and didn't have the "don't get stuck" patch. I will
> also note that it would have been nice had this patch title included
> the words exynos and/or pit/pi in it.
>
Yes, as you can see log, I always change the subject with some my rule is
similar with your suggestion when I apply into samsung tree ;-)
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ARM: DTS: correct the capability string for mmc0
@ 2014-06-25 11:19 ` Kukjin Kim
0 siblings, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2014-06-25 11:19 UTC (permalink / raw)
To: linux-arm-kernel
Doug Anderson wrote:
>
> Hi,
>
Hi,
> On Mon, Jun 23, 2014 at 4:36 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Naveen Krishna Chatradhi wrote:
> >>
> >> MMC capability for HS200 is parsed in mmc/core/host.c as
> >> dts string "mmc-hs200-1_8v".
> >>
> >> This patch corrects the dts string for Exynos5420 based peach-pit
> >> and Exynos5800 based peach-pi boards.
> >>
> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> >> ---
> >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 +-
> >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> b/arch/arm/boot/dts/exynos5420-
> >> peach-pit.dts
> >> index 7649982..7dea480 100644
> >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> >> @@ -173,7 +173,7 @@
> >> status = "okay";
> >> num-slots = <1>;
> >> broken-cd;
> >> - caps2-mmc-hs200-1_8v;
> >> + mmc-hs200-1_8v;
> >> supports-highspeed;
> >> non-removable;
> >> card-detect-delay = <200>;
> >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> b/arch/arm/boot/dts/exynos5800-
> >> peach-pi.dts
> >> index 2c2c137..bb3ee76 100644
> >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
> >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
> >> @@ -171,7 +171,7 @@
> >> status = "okay";
> >> num-slots = <1>;
> >> broken-cd;
> >> - caps2-mmc-hs200-1_8v;
> >> + mmc-hs200-1_8v;
> >> supports-highspeed;
> >> non-removable;
> >> card-detect-delay = <200>;
> >> --
> >> 1.7.9.5
> >
> > Applied, thanks.
>
> As an FYI: this patch (while correct) will likely cause sporadic boot
> failures until Sonny and my patches land:
>
Thanks for your kindly information.
As I replied on other patch, I will holding on until followings land.
> * https://patchwork.kernel.org/patch/4323921/
> mmc: dw_mmc: Make sure we don't get stuck when we get an error
>
> * https://patchwork.kernel.org/patch/4213211/
> mmc: dw_mmc: change to use recommended reset procedure
>
> In the very least we got sporadic boot failures locally when we
> enabled hs200 and didn't have the "don't get stuck" patch. I will
> also note that it would have been nice had this patch title included
> the words exynos and/or pit/pi in it.
>
Yes, as you can see log, I always change the subject with some my rule is
similar with your suggestion when I apply into samsung tree ;-)
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-06-25 11:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-23 11:20 [PATCH] ARM: DTS: correct the capability string for mmc0 Naveen Krishna Chatradhi
2014-06-23 11:20 ` Naveen Krishna Chatradhi
2014-06-23 11:36 ` Kukjin Kim
2014-06-23 11:36 ` Kukjin Kim
2014-06-24 21:33 ` Doug Anderson
2014-06-24 21:33 ` Doug Anderson
2014-06-25 11:19 ` Kukjin Kim
2014-06-25 11:19 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.