Re: [PATCH 3/5] arch: arm64: dts: exynos7870-on7xelte: enable display panel support

[Kaustabh Chakraborty <kauschluss@disroot.org>]

On 2025-06-18 09:57, Krzysztof Kozlowski wrote:
> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>> Enable DECON and DSI nodes, and add the compatible display panel and
>> appropriate panel timings for this device. Also, disable the
>> simple-framebuffer node in favor of the panel.
>> 
>> This device has a 1080x1920 Synaptics TD4300 display panel.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 40 
>> ++++++++++++++++++++++
>>  1 file changed, 40 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts 
>> b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
>> index 
>> eb97dcc415423f405d7df9b9869b2db3432fb483..86a7fc2554a137752862c37d27cf9813b3ac5514 
>> 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
>> @@ -40,6 +40,8 @@ framebuffer@67000000 {
>>  			height = <1920>;
>>  			stride = <(1080 * 4)>;
>>  			format = "a8r8g8b8";
>> +
>> +			status = "disabled";
> 
> This should be rather removed. What is the idea behind keeping disabled
> node?

Ideally should be removed, yes. A disabled property was added so that if
required, it can be enabled downstream simply by a patch which removes 
it.

And I also understand that upstream doesn't care what's happening 
downstream.
To upstream, it is effectively a dead node. So I'll remove it.

> 
> 
> Best regards,
> Krzysztof