Re: [PATCH 1/5] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs

[Kaustabh Chakraborty <kauschluss@disroot.org>]

On 2025-06-18 09:46, Krzysztof Kozlowski wrote:
> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are
>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml      | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> @@ -52,6 +52,12 @@ properties:
>>                - samsung,exynosautov9-sysreg
>>            - const: syscon
>>          deprecated: true
>> +      - items:
>> +          - enum:
>> +              - samsung,exynos7870-cam-sysreg
>> +              - samsung,exynos7870-disp-sysreg
>> +          - const: samsung,exynos7870-sysreg
> 
> 
> Drop. These are not really compatible or your commit msg is incomplete.
> Don't use deprecated syntax and backwards compatible solutions for new
> hardware.

Are you sure? The deprecated one is actually the item above. From what I
understand, those are generic sysregs and don't mention their functions.

      - items:
          - enum:
              - samsung,exynos5433-sysreg
              - samsung,exynos850-sysreg
              - samsung,exynosautov9-sysreg
          - const: syscon
        deprecated: true

> 
> Best regards,
> Krzysztof