All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Krzysztof Kozlowski' <k.kozlowski@samsung.com>,
	'Russell King' <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: 'Kyungmin Park' <kyungmin.park@samsung.com>,
	'Marek Szyprowski' <m.szyprowski@samsung.com>,
	'Bartlomiej Zolnierkiewicz' <b.zolnierkie@samsung.com>,
	'Sachin Kamat' <sachin.kamat@linaro.org>,
	'Tomasz Figa' <t.figa@samsung.com>
Subject: RE: [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice
Date: Fri, 04 Jul 2014 17:41:15 +0900	[thread overview]
Message-ID: <032901cf9763$b7733150$265993f0$@samsung.com> (raw)
In-Reply-To: <1403783163-28638-1-git-send-email-k.kozlowski@samsung.com>

Krzysztof Kozlowski wrote:
> 
> Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT
> bindings") introduced local variable boot_reg where boot address from
> cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg()
> again.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/mach-exynos/platsmp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
> index 1c8d31e39520..55ed2e6729c5 100644
> --- a/arch/arm/mach-exynos/platsmp.c
> +++ b/arch/arm/mach-exynos/platsmp.c
> @@ -155,7 +155,7 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle)
>  				ret = PTR_ERR(boot_reg);
>  				goto fail;
>  			}
> -			__raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
> +			__raw_writel(boot_addr, boot_reg);
>  		}
> 
>  		call_firmware_op(cpu_boot, phys_cpu);
> @@ -242,7 +242,7 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus)
> 
>  			if (IS_ERR(boot_reg))
>  				break;
> -			__raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
> +			__raw_writel(boot_addr, boot_reg);
>  		}
>  	}
>  }
> --
> 1.9.1

Oh, good catch. will apply :-)

Thanks,
Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice
Date: Fri, 04 Jul 2014 17:41:15 +0900	[thread overview]
Message-ID: <032901cf9763$b7733150$265993f0$@samsung.com> (raw)
In-Reply-To: <1403783163-28638-1-git-send-email-k.kozlowski@samsung.com>

Krzysztof Kozlowski wrote:
> 
> Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT
> bindings") introduced local variable boot_reg where boot address from
> cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg()
> again.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/mach-exynos/platsmp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
> index 1c8d31e39520..55ed2e6729c5 100644
> --- a/arch/arm/mach-exynos/platsmp.c
> +++ b/arch/arm/mach-exynos/platsmp.c
> @@ -155,7 +155,7 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle)
>  				ret = PTR_ERR(boot_reg);
>  				goto fail;
>  			}
> -			__raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
> +			__raw_writel(boot_addr, boot_reg);
>  		}
> 
>  		call_firmware_op(cpu_boot, phys_cpu);
> @@ -242,7 +242,7 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus)
> 
>  			if (IS_ERR(boot_reg))
>  				break;
> -			__raw_writel(boot_addr, cpu_boot_reg(phys_cpu));
> +			__raw_writel(boot_addr, boot_reg);
>  		}
>  	}
>  }
> --
> 1.9.1

Oh, good catch. will apply :-)

Thanks,
Kukjin

  parent reply	other threads:[~2014-07-04  8:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-26 11:46 [PATCH RESEND] ARM: EXYNOS: Do not calculate boot address twice Krzysztof Kozlowski
2014-06-26 11:46 ` Krzysztof Kozlowski
2014-06-26 11:51 ` Sachin Kamat
2014-06-26 11:51   ` Sachin Kamat
2014-07-04  8:41 ` Kukjin Kim [this message]
2014-07-04  8:41   ` Kukjin Kim
2014-09-01  8:39   ` Krzysztof Kozlowski
2014-09-01  8:39     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='032901cf9763$b7733150$265993f0$@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=sachin.kamat@linaro.org \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.