From: Krzysztof Kozlowski <krzk@kernel.org>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Russell King <linux@armlinux.org.uk>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Arnd Bergmann <arnd@arndb.de>, Chancel Liu <chancel.liu@nxp.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding
Date: Thu, 13 Jun 2024 08:11:00 +0200 [thread overview]
Message-ID: <038eaf17-7806-4be4-b98d-e936afa1001f@kernel.org> (raw)
In-Reply-To: <CAG+cZ06EN4Uw7Cy+kwsiPzu16Kp7tsF19Oit6oN6GUcSe464JQ@mail.gmail.com>
On 12/06/2024 10:06, Piotr Wojtaszczyk wrote:
> On Tue, Jun 11, 2024 at 12:45 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> Changes for v2:
>>> - Added maintainers field
>>> - Dropped clock-names
>>> - Dropped unused unneded interrupts field
>>
>> Does the device has interrupts or not? This should justify decision, not
>> current usage by drivers.
> Yes the device has interrupts but feeding data FIFOs is handled by DMA
> (amba-pl08x.c).
> Should I declare interrupts despite they are not used in the compatible driver?
Yes.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com>
Cc: alsa-devel@alsa-project.org, Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-sound@vger.kernel.org, Vladimir Zapolskiy <vz@mleia.com>,
Mark Brown <broonie@kernel.org>,
Chancel Liu <chancel.liu@nxp.com>,
linux-arm-kernel@lists.infradead.org,
Russell King <linux@armlinux.org.uk>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding
Date: Thu, 13 Jun 2024 08:11:00 +0200 [thread overview]
Message-ID: <038eaf17-7806-4be4-b98d-e936afa1001f@kernel.org> (raw)
In-Reply-To: <CAG+cZ06EN4Uw7Cy+kwsiPzu16Kp7tsF19Oit6oN6GUcSe464JQ@mail.gmail.com>
On 12/06/2024 10:06, Piotr Wojtaszczyk wrote:
> On Tue, Jun 11, 2024 at 12:45 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> Changes for v2:
>>> - Added maintainers field
>>> - Dropped clock-names
>>> - Dropped unused unneded interrupts field
>>
>> Does the device has interrupts or not? This should justify decision, not
>> current usage by drivers.
> Yes the device has interrupts but feeding data FIFOs is handled by DMA
> (amba-pl08x.c).
> Should I declare interrupts despite they are not used in the compatible driver?
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-13 6:12 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs>
2024-06-11 9:47 ` [Patch v2 1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs Piotr Wojtaszczyk
2024-06-11 9:47 ` Piotr Wojtaszczyk
2024-06-11 9:47 ` Piotr Wojtaszczyk
2024-06-11 9:47 ` [Patch v2 2/2] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding Piotr Wojtaszczyk
2024-06-11 9:47 ` Piotr Wojtaszczyk
2024-06-11 9:47 ` Piotr Wojtaszczyk
2024-06-11 10:18 ` Krzysztof Kozlowski
2024-06-11 10:18 ` Krzysztof Kozlowski
2024-06-11 10:18 ` Krzysztof Kozlowski
2024-06-12 8:02 ` Piotr Wojtaszczyk
2024-06-12 8:02 ` Piotr Wojtaszczyk
2024-06-13 6:11 ` Krzysztof Kozlowski
2024-06-13 6:11 ` Krzysztof Kozlowski
2024-06-11 10:37 ` Mark Brown
2024-06-11 10:37 ` Mark Brown
2024-06-11 10:37 ` Mark Brown
2024-06-11 10:45 ` Krzysztof Kozlowski
2024-06-11 10:45 ` Krzysztof Kozlowski
2024-06-11 10:45 ` Krzysztof Kozlowski
2024-06-12 8:06 ` Piotr Wojtaszczyk
2024-06-12 8:06 ` Piotr Wojtaszczyk
2024-06-13 6:11 ` Krzysztof Kozlowski [this message]
2024-06-13 6:11 ` Krzysztof Kozlowski
2024-06-11 11:31 ` Rob Herring (Arm)
2024-06-11 11:31 ` Rob Herring (Arm)
2024-06-11 11:31 ` Rob Herring (Arm)
2024-06-11 10:15 ` [Patch v2 1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs Krzysztof Kozlowski
2024-06-11 10:15 ` Krzysztof Kozlowski
2024-06-11 10:15 ` Krzysztof Kozlowski
2024-06-12 7:48 ` Piotr Wojtaszczyk
2024-06-12 7:48 ` Piotr Wojtaszczyk
2024-06-11 10:36 ` Mark Brown
2024-06-11 10:36 ` Mark Brown
2024-06-11 10:36 ` Mark Brown
2024-06-12 7:54 ` Piotr Wojtaszczyk
2024-06-12 7:54 ` Piotr Wojtaszczyk
2024-06-14 16:24 ` Piotr Wojtaszczyk
2024-06-14 16:24 ` Piotr Wojtaszczyk
2024-06-14 16:42 ` Mark Brown
2024-06-14 16:42 ` Mark Brown
2024-06-14 16:46 ` Piotr Wojtaszczyk
2024-06-14 16:46 ` Piotr Wojtaszczyk
2024-06-14 16:51 ` Mark Brown
2024-06-14 16:51 ` Mark Brown
2024-06-14 16:34 ` [PATCH v3 0/4] Add audio support for LPC32XX CPUs Piotr Wojtaszczyk
2024-06-14 16:34 ` Piotr Wojtaszczyk
2024-06-14 16:34 ` [PATCH v3 1/4] ASoC: dt-bindings: lpc32xx: Add lpc32xx i2s DT binding Piotr Wojtaszczyk
2024-06-14 16:34 ` Piotr Wojtaszczyk
2024-06-15 10:01 ` Krzysztof Kozlowski
2024-06-15 10:01 ` Krzysztof Kozlowski
2024-06-17 9:33 ` Piotr Wojtaszczyk
2024-06-17 9:33 ` Piotr Wojtaszczyk
2024-06-17 12:14 ` Krzysztof Kozlowski
2024-06-17 12:14 ` Krzysztof Kozlowski
2024-06-17 14:04 ` Piotr Wojtaszczyk
2024-06-17 14:04 ` Piotr Wojtaszczyk
2024-06-17 15:48 ` Krzysztof Kozlowski
2024-06-17 15:48 ` Krzysztof Kozlowski
2024-06-17 16:30 ` Piotr Wojtaszczyk
2024-06-17 16:30 ` Piotr Wojtaszczyk
2024-06-14 16:34 ` [PATCH v3 2/4] ARM: dts: lpc32xx: Add missing properties for the i2s interfaces Piotr Wojtaszczyk
2024-06-14 16:34 ` Piotr Wojtaszczyk
2024-06-14 16:34 ` [PATCH v3 3/4] ARM: lpc32xx: Add pl08x virtual dma channels for spi and i2s Piotr Wojtaszczyk
2024-06-14 16:34 ` Piotr Wojtaszczyk
2024-06-14 16:34 ` [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs Piotr Wojtaszczyk
2024-06-14 16:34 ` Piotr Wojtaszczyk
2024-06-17 19:30 ` Markus Elfring
2024-06-17 19:30 ` Markus Elfring
2024-06-18 7:45 ` Piotr Wojtaszczyk
2024-06-18 7:45 ` Piotr Wojtaszczyk
2024-06-14 16:43 ` [PATCH v3 0/4] Add audio support for LPC32XX CPUs Mark Brown
2024-06-14 16:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=038eaf17-7806-4be4-b98d-e936afa1001f@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chancel.liu@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=perex@perex.cz \
--cc=piotr.wojtaszczyk@timesys.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.