From: Florian Fainelli <f.fainelli@gmail.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH net-next] net: marvell: prestera: fix uninitialized vid in prestera_port_vlans_add
Date: Thu, 14 Jan 2021 10:48:00 -0800 [thread overview]
Message-ID: <03979f1b-851e-d5ff-2928-323f5aed696e@gmail.com> (raw)
In-Reply-To: <20210114083556.2274440-1-olteanv@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
On 1/14/21 12:35 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> prestera_bridge_port_vlan_add should have been called with vlan->vid,
> however this was masked by the presence of the local vid variable and I
> did not notice the build warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: b7a9e0da2d1c ("net: switchdev: remove vid_begin -> vid_end range from VLAN objects")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: Kurt Kanzenbach <kurt@linutronix.de>,
Vadym Kochan <vkochan@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Ido Schimmel <idosch@nvidia.com>,
clang-built-linux@googlegroups.com, linux-mm@kvack.org,
kbuild-all@lists.01.org
Subject: Re: [PATCH net-next] net: marvell: prestera: fix uninitialized vid in prestera_port_vlans_add
Date: Thu, 14 Jan 2021 10:48:00 -0800 [thread overview]
Message-ID: <03979f1b-851e-d5ff-2928-323f5aed696e@gmail.com> (raw)
In-Reply-To: <20210114083556.2274440-1-olteanv@gmail.com>
On 1/14/21 12:35 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> prestera_bridge_port_vlan_add should have been called with vlan->vid,
> however this was masked by the presence of the local vid variable and I
> did not notice the build warning.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: b7a9e0da2d1c ("net: switchdev: remove vid_begin -> vid_end range from VLAN objects")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-01-14 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 8:35 [PATCH net-next] net: marvell: prestera: fix uninitialized vid in prestera_port_vlans_add Vladimir Oltean
2021-01-14 18:48 ` Florian Fainelli [this message]
2021-01-14 18:48 ` Florian Fainelli
2021-01-14 21:46 ` Taras
2021-01-14 21:46 ` Taras Chornyi [C]
2021-01-15 0:50 ` patchwork-bot+netdevbpf
2021-01-15 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03979f1b-851e-d5ff-2928-323f5aed696e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.