All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wang, Wei W" <wei.w.wang@intel.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Yamahata, Isaku" <isaku.yamahata@intel.com>,
	Andra Paraschiv <andraprs@amazon.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Kleen,  Andi" <andi.kleen@intel.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [RFC] hypercall-vsock: add a new vsock transport
Date: Thu, 11 Nov 2021 08:02:27 +0000	[thread overview]
Message-ID: <03b779ac2f504fa989559f16e75817d3@intel.com> (raw)
In-Reply-To: <YYuSKEqj3UMLNAfw@stefanha-x1.localdomain>

> From: Stefan Hajnoczi <stefanha@redhat.com>
On Wednesday, November 10, 2021 5:35 PM, Stefan Hajnoczi wrote:
> AF_VSOCK is designed to allow multiple transports, so why not. There is a cost
> to developing and maintaining a vsock transport though.

Yes. The effort could be reduced via simplifying the design as much as possible:
e.g. no ring operations - guest just sends a packet each time for the host to read.
(this transport isn't targeting for high performance)

> 
> I think Amazon Nitro enclaves use virtio-vsock and I've CCed Andra in case she
> has thoughts on the pros/cons and how to minimize the trusted computing
> base.

Thanks for adding more related person to the discussion loop.

> 
> If simplicity is the top priority then VIRTIO's MMIO transport without indirect
> descriptors and using the packed virtqueue layout reduces the size of the
> implementation:
> https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x1-1
> 440002

I listed some considerations for virtio-mmio in the response to Michael.
Please have a check if any different thoughts.

Thanks,
Wei
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Wang, Wei W" <wei.w.wang@intel.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "sgarzare@redhat.com" <sgarzare@redhat.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"mst@redhat.com" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"kys@microsoft.com" <kys@microsoft.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"Yamahata, Isaku" <isaku.yamahata@intel.com>,
	"Nakajima, Jun" <jun.nakajima@intel.com>,
	"Kleen, Andi" <andi.kleen@intel.com>,
	Andra Paraschiv <andraprs@amazon.com>,
	"Sergio Lopez Pascual" <slp@redhat.com>
Subject: RE: [RFC] hypercall-vsock: add a new vsock transport
Date: Thu, 11 Nov 2021 08:02:27 +0000	[thread overview]
Message-ID: <03b779ac2f504fa989559f16e75817d3@intel.com> (raw)
In-Reply-To: <YYuSKEqj3UMLNAfw@stefanha-x1.localdomain>

> From: Stefan Hajnoczi <stefanha@redhat.com>
On Wednesday, November 10, 2021 5:35 PM, Stefan Hajnoczi wrote:
> AF_VSOCK is designed to allow multiple transports, so why not. There is a cost
> to developing and maintaining a vsock transport though.

Yes. The effort could be reduced via simplifying the design as much as possible:
e.g. no ring operations - guest just sends a packet each time for the host to read.
(this transport isn't targeting for high performance)

> 
> I think Amazon Nitro enclaves use virtio-vsock and I've CCed Andra in case she
> has thoughts on the pros/cons and how to minimize the trusted computing
> base.

Thanks for adding more related person to the discussion loop.

> 
> If simplicity is the top priority then VIRTIO's MMIO transport without indirect
> descriptors and using the packed virtqueue layout reduces the size of the
> implementation:
> https://docs.oasis-open.org/virtio/virtio/v1.1/cs01/virtio-v1.1-cs01.html#x1-1
> 440002

I listed some considerations for virtio-mmio in the response to Michael.
Please have a check if any different thoughts.

Thanks,
Wei

  reply	other threads:[~2021-11-11  8:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10  7:12 [RFC] hypercall-vsock: add a new vsock transport Wang, Wei W
2021-11-10  9:34 ` Stefan Hajnoczi
2021-11-10  9:34   ` Stefan Hajnoczi
2021-11-11  8:02   ` Wang, Wei W [this message]
2021-11-11  8:02     ` Wang, Wei W
2021-11-10 10:50 ` Michael S. Tsirkin
2021-11-10 10:50   ` Michael S. Tsirkin
2021-11-11  7:58   ` Wang, Wei W
2021-11-11  7:58     ` Wang, Wei W
2021-11-11 15:19     ` Michael S. Tsirkin
2021-11-11 15:19       ` Michael S. Tsirkin
2021-11-25  6:37     ` Jason Wang
2021-11-25  6:37       ` Jason Wang
2021-11-25  8:43       ` Wang, Wei W
2021-11-25  8:43         ` Wang, Wei W
2021-11-25 12:04         ` Gerd Hoffmann
2021-11-25 12:04           ` Gerd Hoffmann
2021-11-10 11:17 ` Stefano Garzarella
2021-11-10 11:17   ` Stefano Garzarella
2021-11-10 21:45   ` Paraschiv, Andra-Irina
2021-11-11  8:14   ` Wang, Wei W
2021-11-11  8:14     ` Wang, Wei W
2021-11-11  8:24     ` Paolo Bonzini
2021-11-11  8:24       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03b779ac2f504fa989559f16e75817d3@intel.com \
    --to=wei.w.wang@intel.com \
    --cc=andi.kleen@intel.com \
    --cc=andraprs@amazon.com \
    --cc=davem@davemloft.net \
    --cc=isaku.yamahata@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.