* [PATCH v2] tty: serial: samsung_tty: support 18 uart ports [not found] <CGME20250404134131epcas5p4794f2b1e5d289e1faa142c9093ea45e5@epcas5p4.samsung.com> @ 2025-04-04 13:50 ` Faraz Ata 2025-04-04 16:45 ` Krzysztof Kozlowski 0 siblings, 1 reply; 3+ messages in thread From: Faraz Ata @ 2025-04-04 13:50 UTC (permalink / raw) To: alim.akhtar, krzk+dt, gregkh, jirislaby Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-serial, rosa.pila, dev.tailor, Faraz Ata Exynos Auto v920 SoC supports up to 18 UART ports. Hence changing the value of UART_NR to 18. --- drivers/tty/serial/samsung_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 210fff7164c1..9a5211b730fb 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -52,7 +52,7 @@ #define S3C24XX_SERIAL_MINOR 64 #ifdef CONFIG_ARM64 -#define UART_NR 12 +#define UART_NR 18 #else #define UART_NR CONFIG_SERIAL_SAMSUNG_UARTS #endif -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tty: serial: samsung_tty: support 18 uart ports 2025-04-04 13:50 ` [PATCH v2] tty: serial: samsung_tty: support 18 uart ports Faraz Ata @ 2025-04-04 16:45 ` Krzysztof Kozlowski 2025-04-11 6:23 ` Faraz Ata 0 siblings, 1 reply; 3+ messages in thread From: Krzysztof Kozlowski @ 2025-04-04 16:45 UTC (permalink / raw) To: Faraz Ata, alim.akhtar, krzk+dt, gregkh, jirislaby Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-serial, rosa.pila, dev.tailor On 04/04/2025 15:50, Faraz Ata wrote: > Exynos Auto v920 SoC supports up to 18 UART ports. > Hence changing the value of UART_NR to 18. > --- How v2, without changelog, is even worse than v1? It goes to wrong direction. Please run scripts/checkpatch.pl and fix reported warnings. After that, run also `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] tty: serial: samsung_tty: support 18 uart ports 2025-04-04 16:45 ` Krzysztof Kozlowski @ 2025-04-11 6:23 ` Faraz Ata 0 siblings, 0 replies; 3+ messages in thread From: Faraz Ata @ 2025-04-11 6:23 UTC (permalink / raw) To: 'Krzysztof Kozlowski', alim.akhtar, krzk+dt, gregkh, jirislaby Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel, linux-serial, rosa.pila, dev.tailor Hello Krzysztof > Subject: Re: [PATCH v2] tty: serial: samsung_tty: support 18 uart ports > > On 04/04/2025 15:50, Faraz Ata wrote: > > Exynos Auto v920 SoC supports up to 18 UART ports. > > Hence changing the value of UART_NR to 18. > > --- > > How v2, without changelog, is even worse than v1? It goes to wrong > direction. > > Please run scripts/checkpatch.pl and fix reported warnings. After that, run > also `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some > warnings can be ignored, especially from --strict run, but the code here looks > like it needs a fix. Feel free to get in touch if the warning is not clear. > > Thanks for your review and sorry for the noise, that was not intentional, got posted by mistake, will takecare about it. Will send another version with change-log. > ... > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-11 6:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20250404134131epcas5p4794f2b1e5d289e1faa142c9093ea45e5@epcas5p4.samsung.com>
2025-04-04 13:50 ` [PATCH v2] tty: serial: samsung_tty: support 18 uart ports Faraz Ata
2025-04-04 16:45 ` Krzysztof Kozlowski
2025-04-11 6:23 ` Faraz Ata
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.