From: Kukjin Kim <kgene@kernel.org>
To: 'Pankaj Dubey' <pankaj.dubey@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: linux@arm.linux.org.uk, thomas.ab@samsung.com
Subject: RE: [PATCH] ARM: EXYNOS: fix typo in static struct name "exynos5_list_diable_wfi_wfe"
Date: Tue, 28 Oct 2014 19:33:17 +0900 [thread overview]
Message-ID: <041401cff29a$963784e0$c2a68ea0$@kernel.org> (raw)
In-Reply-To: <1414489832-28011-1-git-send-email-pankaj.dubey@samsung.com>
Pankaj Dubey wrote:
>
> This patch fixes a typo in struct named as "exynos5_list_diable_wfi_wfe"
> by making it "exynos5_list_disable_wfi_wfe" which is more meaningful.
>
Yes, 'disable' is more meaningful ;)
I'll apply this into non-critical-fixes for 3.19.
Thanks,
Kukjin
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/mach-exynos/pmu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c
> index cfc62e8..e5e1846 100644
> --- a/arch/arm/mach-exynos/pmu.c
> +++ b/arch/arm/mach-exynos/pmu.c
> @@ -330,7 +330,7 @@ static unsigned int const exynos5_list_both_cnt_feed[] = {
> EXYNOS5_TOP_PWR_SYSMEM_OPTION,
> };
>
> -static unsigned int const exynos5_list_diable_wfi_wfe[] = {
> +static unsigned int const exynos5_list_disable_wfi_wfe[] = {
> EXYNOS5_ARM_CORE1_OPTION,
> EXYNOS5_FSYS_ARM_OPTION,
> EXYNOS5_ISP_ARM_OPTION,
> @@ -361,11 +361,11 @@ static void exynos5_init_pmu(void)
> /*
> * Disable WFI/WFE on XXX_OPTION
> */
> - for (i = 0 ; i < ARRAY_SIZE(exynos5_list_diable_wfi_wfe) ; i++) {
> - tmp = pmu_raw_readl(exynos5_list_diable_wfi_wfe[i]);
> + for (i = 0 ; i < ARRAY_SIZE(exynos5_list_disable_wfi_wfe) ; i++) {
> + tmp = pmu_raw_readl(exynos5_list_disable_wfi_wfe[i]);
> tmp &= ~(EXYNOS5_OPTION_USE_STANDBYWFE |
> EXYNOS5_OPTION_USE_STANDBYWFI);
> - pmu_raw_writel(tmp, exynos5_list_diable_wfi_wfe[i]);
> + pmu_raw_writel(tmp, exynos5_list_disable_wfi_wfe[i]);
> }
> }
>
> --
> 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: fix typo in static struct name "exynos5_list_diable_wfi_wfe"
Date: Tue, 28 Oct 2014 19:33:17 +0900 [thread overview]
Message-ID: <041401cff29a$963784e0$c2a68ea0$@kernel.org> (raw)
In-Reply-To: <1414489832-28011-1-git-send-email-pankaj.dubey@samsung.com>
Pankaj Dubey wrote:
>
> This patch fixes a typo in struct named as "exynos5_list_diable_wfi_wfe"
> by making it "exynos5_list_disable_wfi_wfe" which is more meaningful.
>
Yes, 'disable' is more meaningful ;)
I'll apply this into non-critical-fixes for 3.19.
Thanks,
Kukjin
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/mach-exynos/pmu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c
> index cfc62e8..e5e1846 100644
> --- a/arch/arm/mach-exynos/pmu.c
> +++ b/arch/arm/mach-exynos/pmu.c
> @@ -330,7 +330,7 @@ static unsigned int const exynos5_list_both_cnt_feed[] = {
> EXYNOS5_TOP_PWR_SYSMEM_OPTION,
> };
>
> -static unsigned int const exynos5_list_diable_wfi_wfe[] = {
> +static unsigned int const exynos5_list_disable_wfi_wfe[] = {
> EXYNOS5_ARM_CORE1_OPTION,
> EXYNOS5_FSYS_ARM_OPTION,
> EXYNOS5_ISP_ARM_OPTION,
> @@ -361,11 +361,11 @@ static void exynos5_init_pmu(void)
> /*
> * Disable WFI/WFE on XXX_OPTION
> */
> - for (i = 0 ; i < ARRAY_SIZE(exynos5_list_diable_wfi_wfe) ; i++) {
> - tmp = pmu_raw_readl(exynos5_list_diable_wfi_wfe[i]);
> + for (i = 0 ; i < ARRAY_SIZE(exynos5_list_disable_wfi_wfe) ; i++) {
> + tmp = pmu_raw_readl(exynos5_list_disable_wfi_wfe[i]);
> tmp &= ~(EXYNOS5_OPTION_USE_STANDBYWFE |
> EXYNOS5_OPTION_USE_STANDBYWFI);
> - pmu_raw_writel(tmp, exynos5_list_diable_wfi_wfe[i]);
> + pmu_raw_writel(tmp, exynos5_list_disable_wfi_wfe[i]);
> }
> }
>
> --
> 1.7.9.5
next prev parent reply other threads:[~2014-10-28 10:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 9:50 [PATCH] ARM: EXYNOS: fix typo in static struct name "exynos5_list_diable_wfi_wfe" Pankaj Dubey
2014-10-28 9:50 ` Pankaj Dubey
2014-10-28 10:33 ` Kukjin Kim [this message]
2014-10-28 10:33 ` Kukjin Kim
2014-11-11 9:44 ` Javier Martinez Canillas
2014-11-11 9:44 ` Javier Martinez Canillas
2014-11-11 9:54 ` Javier Martinez Canillas
2014-11-11 9:54 ` Javier Martinez Canillas
2014-11-13 2:40 ` Kukjin Kim
2014-11-13 2:40 ` Kukjin Kim
2014-11-13 4:27 ` Pankaj Dubey
2014-11-13 4:27 ` Pankaj Dubey
2014-11-13 4:42 ` Kukjin Kim
2014-11-13 4:42 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='041401cff29a$963784e0$c2a68ea0$@kernel.org' \
--to=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pankaj.dubey@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.