From: Faiz Abbas <faiz_abbas@ti.com>
To: Nishanth Menon <nm@ti.com>, Vignesh R <vigneshr@ti.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
ulf.hansson@linaro.org, linux-kernel@vger.kernel.org,
adrian.hunter@intel.com, t-kristo@ti.com, robh+dt@kernel.org,
kishon@ti.com, michal.simek@xilinx.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD
Date: Mon, 10 Dec 2018 19:00:34 +0530 [thread overview]
Message-ID: <044fa725-9b6d-e331-ee10-664e59128e64@ti.com> (raw)
In-Reply-To: <20181208154526.ivbvwvcx6otg7lvh@akan>
Hi Nishanth,
On 08/12/18 9:15 PM, Nishanth Menon wrote:
> On 10:56-20181208, Vignesh R wrote:
>>
>>
>> On 07/12/18 2:12 PM, Faiz Abbas wrote:
>>> There are two MMC host controller instances present on the TI's
>>> Am654 SOCs. Add device tree nodes for the same.
>>>
>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>>> ---
>>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 28 ++++++++++++++++++++++++
>>> 1 file changed, 28 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>>> index 916434839603..d07212f16a81 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>>> @@ -129,4 +129,32 @@
>>> clocks = <&k3_clks 113 1>;
>>> power-domains = <&k3_pds 113>;
>>> };
>>> +
>>> + sdhci0: sdhci@4f80000 {
>>> + compatible = "ti,am654-sdhci-5.1";
>>> + reg = <0x0 0x4f80000 0x0 0x260>, <0x0 0x4f90000 0x0 0x134>;
>>> + power-domains = <&k3_pds 47>;
>>> + clocks = <&k3_clks 47 0>, <&k3_clks 47 1>;
>>> + clock-names = "clk_ahb", "clk_xin";
>>> + interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
>>> + sdhci-caps-mask = <0x80000007 0x0>;
>>> + mmc-ddr-1_8v;
>>> + ti,otap-del-sel = <0x2>;
>>> + ti,trm-icp = <0x8>;
>>> + status = "disabled";
>>> + };
>>
>> Please drop "status=disabled" from dtsi. Can be disabled as required in
>> the board dts.
>
>
> yes - the standard in k3 is to disable the nodes that are'nt needed in
> board.dtsi.
>
> This is different from "disabled by default" approach in DRA7 or OMAP4
> for example.
>
Ok. Will fix in v2.
Thanks,
Faiz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Faiz Abbas <faiz_abbas@ti.com>
To: Nishanth Menon <nm@ti.com>, Vignesh R <vigneshr@ti.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
ulf.hansson@linaro.org, linux-kernel@vger.kernel.org,
adrian.hunter@intel.com, t-kristo@ti.com, robh+dt@kernel.org,
kishon@ti.com, michal.simek@xilinx.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD
Date: Mon, 10 Dec 2018 19:00:34 +0530 [thread overview]
Message-ID: <044fa725-9b6d-e331-ee10-664e59128e64@ti.com> (raw)
In-Reply-To: <20181208154526.ivbvwvcx6otg7lvh@akan>
Hi Nishanth,
On 08/12/18 9:15 PM, Nishanth Menon wrote:
> On 10:56-20181208, Vignesh R wrote:
>>
>>
>> On 07/12/18 2:12 PM, Faiz Abbas wrote:
>>> There are two MMC host controller instances present on the TI's
>>> Am654 SOCs. Add device tree nodes for the same.
>>>
>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>>> ---
>>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 28 ++++++++++++++++++++++++
>>> 1 file changed, 28 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>>> index 916434839603..d07212f16a81 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>>> @@ -129,4 +129,32 @@
>>> clocks = <&k3_clks 113 1>;
>>> power-domains = <&k3_pds 113>;
>>> };
>>> +
>>> + sdhci0: sdhci@4f80000 {
>>> + compatible = "ti,am654-sdhci-5.1";
>>> + reg = <0x0 0x4f80000 0x0 0x260>, <0x0 0x4f90000 0x0 0x134>;
>>> + power-domains = <&k3_pds 47>;
>>> + clocks = <&k3_clks 47 0>, <&k3_clks 47 1>;
>>> + clock-names = "clk_ahb", "clk_xin";
>>> + interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
>>> + sdhci-caps-mask = <0x80000007 0x0>;
>>> + mmc-ddr-1_8v;
>>> + ti,otap-del-sel = <0x2>;
>>> + ti,trm-icp = <0x8>;
>>> + status = "disabled";
>>> + };
>>
>> Please drop "status=disabled" from dtsi. Can be disabled as required in
>> the board dts.
>
>
> yes - the standard in k3 is to disable the nodes that are'nt needed in
> board.dtsi.
>
> This is different from "disabled by default" approach in DRA7 or OMAP4
> for example.
>
Ok. Will fix in v2.
Thanks,
Faiz
WARNING: multiple messages have this Message-ID (diff)
From: Faiz Abbas <faiz_abbas@ti.com>
To: Nishanth Menon <nm@ti.com>, Vignesh R <vigneshr@ti.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <t-kristo@ti.com>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<mark.rutland@arm.com>, <ulf.hansson@linaro.org>,
<adrian.hunter@intel.com>, <kishon@ti.com>, <robh+dt@kernel.org>,
<michal.simek@xilinx.com>
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD
Date: Mon, 10 Dec 2018 19:00:34 +0530 [thread overview]
Message-ID: <044fa725-9b6d-e331-ee10-664e59128e64@ti.com> (raw)
In-Reply-To: <20181208154526.ivbvwvcx6otg7lvh@akan>
Hi Nishanth,
On 08/12/18 9:15 PM, Nishanth Menon wrote:
> On 10:56-20181208, Vignesh R wrote:
>>
>>
>> On 07/12/18 2:12 PM, Faiz Abbas wrote:
>>> There are two MMC host controller instances present on the TI's
>>> Am654 SOCs. Add device tree nodes for the same.
>>>
>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
>>> ---
>>> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 28 ++++++++++++++++++++++++
>>> 1 file changed, 28 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>>> index 916434839603..d07212f16a81 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
>>> @@ -129,4 +129,32 @@
>>> clocks = <&k3_clks 113 1>;
>>> power-domains = <&k3_pds 113>;
>>> };
>>> +
>>> + sdhci0: sdhci@4f80000 {
>>> + compatible = "ti,am654-sdhci-5.1";
>>> + reg = <0x0 0x4f80000 0x0 0x260>, <0x0 0x4f90000 0x0 0x134>;
>>> + power-domains = <&k3_pds 47>;
>>> + clocks = <&k3_clks 47 0>, <&k3_clks 47 1>;
>>> + clock-names = "clk_ahb", "clk_xin";
>>> + interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
>>> + sdhci-caps-mask = <0x80000007 0x0>;
>>> + mmc-ddr-1_8v;
>>> + ti,otap-del-sel = <0x2>;
>>> + ti,trm-icp = <0x8>;
>>> + status = "disabled";
>>> + };
>>
>> Please drop "status=disabled" from dtsi. Can be disabled as required in
>> the board dts.
>
>
> yes - the standard in k3 is to disable the nodes that are'nt needed in
> board.dtsi.
>
> This is different from "disabled by default" approach in DRA7 or OMAP4
> for example.
>
Ok. Will fix in v2.
Thanks,
Faiz
next prev parent reply other threads:[~2018-12-10 13:28 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 8:42 [PATCH 0/2] Add DT Support for MMCSD in Am65x-evm Faiz Abbas
2018-12-07 8:42 ` Faiz Abbas
2018-12-07 8:42 ` Faiz Abbas
2018-12-07 8:42 ` [PATCH 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD Faiz Abbas
2018-12-07 8:42 ` Faiz Abbas
2018-12-07 8:42 ` Faiz Abbas
2018-12-08 5:26 ` Vignesh R
2018-12-08 5:26 ` Vignesh R
2018-12-08 5:26 ` Vignesh R
2018-12-08 15:45 ` Nishanth Menon
2018-12-08 15:45 ` Nishanth Menon
2018-12-08 15:45 ` Nishanth Menon
2018-12-10 13:30 ` Faiz Abbas [this message]
2018-12-10 13:30 ` Faiz Abbas
2018-12-10 13:30 ` Faiz Abbas
2018-12-07 8:42 ` [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC/SD support Faiz Abbas
2018-12-07 8:42 ` Faiz Abbas
2018-12-07 8:42 ` Faiz Abbas
2018-12-08 15:54 ` Nishanth Menon
2018-12-08 15:54 ` Nishanth Menon
2018-12-08 15:54 ` Nishanth Menon
2018-12-10 8:03 ` Sekhar Nori
2018-12-10 8:03 ` Sekhar Nori
2018-12-10 8:03 ` Sekhar Nori
2018-12-10 12:06 ` Nishanth Menon
2018-12-10 12:06 ` Nishanth Menon
2018-12-10 12:06 ` Nishanth Menon
2018-12-10 12:40 ` Sekhar Nori
2018-12-10 12:40 ` Sekhar Nori
2018-12-10 12:40 ` Sekhar Nori
2018-12-10 13:33 ` Faiz Abbas
2018-12-10 13:33 ` Faiz Abbas
2018-12-10 13:33 ` Faiz Abbas
2018-12-10 13:52 ` Nishanth Menon
2018-12-10 13:52 ` Nishanth Menon
2018-12-10 13:52 ` Nishanth Menon
2018-12-10 13:49 ` Nishanth Menon
2018-12-10 13:49 ` Nishanth Menon
2018-12-10 13:49 ` Nishanth Menon
2018-12-10 23:47 ` Tony Lindgren
2018-12-10 23:47 ` Tony Lindgren
2018-12-11 13:32 ` Sekhar Nori
2018-12-11 13:32 ` Sekhar Nori
2018-12-11 13:32 ` Sekhar Nori
2018-12-11 5:58 ` Vignesh R
2018-12-11 5:58 ` Vignesh R
2018-12-11 5:58 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=044fa725-9b6d-e331-ee10-664e59128e64@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.