* [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI phy
@ 2022-03-14 18:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-14 18:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Marek Szyprowski, Sylwester Nawrocki, Krzysztof Kozlowski
Commit e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
support for PMU regmap") deprecated the usage of unit address in MIPI
phy node, in favor of a syscon phandle. Deprecating was a correct
approach because that unit address was actually coming from Power
Management Unit SFR range so its usage here caused overlapped memory
mapping.
In 2016 commit 26dbadba495f ("phy: exynos-mipi-video: Drop support for
direct access to PMU") fully removed support for parsing that MIPI phy
unit address (SFR range) but the address stayed in Exynos5250 DTSI for
compatibility reasons.
Remove that deprecated unit address from Exynos5250 MIPI phy, because it
has been almost 6 years since it was deprecated and it causes now DT
schema validation warnings:
video-phy@10040710: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
Any out-of-tree users of Exynos5250 DTSI, should update their code to
use newer syscon property.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
arch/arm/boot/dts/exynos5250.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 5baaa7eb71a4..d8d401b5ca48 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -817,15 +817,14 @@ mixer: mixer@14450000 {
status = "disabled";
};
- dp_phy: video-phy {
+ dp_phy: video-phy-0 {
compatible = "samsung,exynos5250-dp-video-phy";
samsung,pmu-syscon = <&pmu_system_controller>;
#phy-cells = <0>;
};
- mipi_phy: video-phy@10040710 {
+ mipi_phy: video-phy-1 {
compatible = "samsung,s5pv210-mipi-video-phy";
- reg = <0x10040710 0x100>;
#phy-cells = <1>;
syscon = <&pmu_system_controller>;
};
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI phy
2022-03-14 18:41 ` Krzysztof Kozlowski
@ 2022-03-15 2:30 ` Alim Akhtar
-1 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2022-03-15 2:30 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Rob Herring',
'Krzysztof Kozlowski', devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: 'Marek Szyprowski', 'Sylwester Nawrocki'
Hi Krzysztof,
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Tuesday, March 15, 2022 12:11 AM
>To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
><krzk+dt@kernel.org>; Alim Akhtar <alim.akhtar@samsung.com>;
>devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
>Cc: Marek Szyprowski <m.szyprowski@samsung.com>; Sylwester Nawrocki
><snawrocki@kernel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski@canonical.com>
>Subject: [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI
>phy
>
>Commit e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
>support for PMU regmap") deprecated the usage of unit address in MIPI phy
>node, in favor of a syscon phandle. Deprecating was a correct approach
>because that unit address was actually coming from Power Management Unit
>SFR range so its usage here caused overlapped memory mapping.
>
>In 2016 commit 26dbadba495f ("phy: exynos-mipi-video: Drop support for
>direct access to PMU") fully removed support for parsing that MIPI phy unit
>address (SFR range) but the address stayed in Exynos5250 DTSI for
>compatibility reasons.
>
>Remove that deprecated unit address from Exynos5250 MIPI phy, because it
>has been almost 6 years since it was deprecated and it causes now DT schema
>validation warnings:
>
> video-phy@10040710: 'reg' does not match any of the regexes: 'pinctrl-[0-
>9]+'
>
>Any out-of-tree users of Exynos5250 DTSI, should update their code to use
>newer syscon property.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
Reviewed-by: Alim Akhtar<alim.akhtar@samsung.com>
> arch/arm/boot/dts/exynos5250.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>b/arch/arm/boot/dts/exynos5250.dtsi
>index 5baaa7eb71a4..d8d401b5ca48 100644
>--- a/arch/arm/boot/dts/exynos5250.dtsi
>+++ b/arch/arm/boot/dts/exynos5250.dtsi
>@@ -817,15 +817,14 @@ mixer: mixer@14450000 {
> status = "disabled";
> };
>
>- dp_phy: video-phy {
>+ dp_phy: video-phy-0 {
> compatible = "samsung,exynos5250-dp-video-phy";
> samsung,pmu-syscon = <&pmu_system_controller>;
> #phy-cells = <0>;
> };
>
>- mipi_phy: video-phy@10040710 {
>+ mipi_phy: video-phy-1 {
> compatible = "samsung,s5pv210-mipi-video-phy";
>- reg = <0x10040710 0x100>;
> #phy-cells = <1>;
> syscon = <&pmu_system_controller>;
> };
>--
>2.32.0
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI phy
@ 2022-03-15 2:30 ` Alim Akhtar
0 siblings, 0 replies; 6+ messages in thread
From: Alim Akhtar @ 2022-03-15 2:30 UTC (permalink / raw)
To: 'Krzysztof Kozlowski', 'Rob Herring',
'Krzysztof Kozlowski', devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: 'Marek Szyprowski', 'Sylwester Nawrocki'
Hi Krzysztof,
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com]
>Sent: Tuesday, March 15, 2022 12:11 AM
>To: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
><krzk+dt@kernel.org>; Alim Akhtar <alim.akhtar@samsung.com>;
>devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
>Cc: Marek Szyprowski <m.szyprowski@samsung.com>; Sylwester Nawrocki
><snawrocki@kernel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski@canonical.com>
>Subject: [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI
>phy
>
>Commit e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
>support for PMU regmap") deprecated the usage of unit address in MIPI phy
>node, in favor of a syscon phandle. Deprecating was a correct approach
>because that unit address was actually coming from Power Management Unit
>SFR range so its usage here caused overlapped memory mapping.
>
>In 2016 commit 26dbadba495f ("phy: exynos-mipi-video: Drop support for
>direct access to PMU") fully removed support for parsing that MIPI phy unit
>address (SFR range) but the address stayed in Exynos5250 DTSI for
>compatibility reasons.
>
>Remove that deprecated unit address from Exynos5250 MIPI phy, because it
>has been almost 6 years since it was deprecated and it causes now DT schema
>validation warnings:
>
> video-phy@10040710: 'reg' does not match any of the regexes: 'pinctrl-[0-
>9]+'
>
>Any out-of-tree users of Exynos5250 DTSI, should update their code to use
>newer syscon property.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>---
Reviewed-by: Alim Akhtar<alim.akhtar@samsung.com>
> arch/arm/boot/dts/exynos5250.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>b/arch/arm/boot/dts/exynos5250.dtsi
>index 5baaa7eb71a4..d8d401b5ca48 100644
>--- a/arch/arm/boot/dts/exynos5250.dtsi
>+++ b/arch/arm/boot/dts/exynos5250.dtsi
>@@ -817,15 +817,14 @@ mixer: mixer@14450000 {
> status = "disabled";
> };
>
>- dp_phy: video-phy {
>+ dp_phy: video-phy-0 {
> compatible = "samsung,exynos5250-dp-video-phy";
> samsung,pmu-syscon = <&pmu_system_controller>;
> #phy-cells = <0>;
> };
>
>- mipi_phy: video-phy@10040710 {
>+ mipi_phy: video-phy-1 {
> compatible = "samsung,s5pv210-mipi-video-phy";
>- reg = <0x10040710 0x100>;
> #phy-cells = <1>;
> syscon = <&pmu_system_controller>;
> };
>--
>2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI phy
2022-03-14 18:41 ` Krzysztof Kozlowski
@ 2022-04-04 17:01 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-04 17:01 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, linux-samsung-soc, devicetree,
linux-kernel, linux-arm-kernel, Alim Akhtar, Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Marek Szyprowski
On Mon, 14 Mar 2022 19:41:13 +0100, Krzysztof Kozlowski wrote:
> Commit e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
> support for PMU regmap") deprecated the usage of unit address in MIPI
> phy node, in favor of a syscon phandle. Deprecating was a correct
> approach because that unit address was actually coming from Power
> Management Unit SFR range so its usage here caused overlapped memory
> mapping.
>
> [...]
Applied, thanks!
[1/1] ARM: dts: exynos: drop deprecated SFR region from MIPI phy
commit: 04398e04173f1be0b21d7cd50c54e8affcebe106
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: exynos: drop deprecated SFR region from MIPI phy
@ 2022-04-04 17:01 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-04 17:01 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, linux-samsung-soc, devicetree,
linux-kernel, linux-arm-kernel, Alim Akhtar, Krzysztof Kozlowski
Cc: Krzysztof Kozlowski, Sylwester Nawrocki, Marek Szyprowski
On Mon, 14 Mar 2022 19:41:13 +0100, Krzysztof Kozlowski wrote:
> Commit e4b3d38088df ("phy: exynos-video-mipi: Fix regression by adding
> support for PMU regmap") deprecated the usage of unit address in MIPI
> phy node, in favor of a syscon phandle. Deprecating was a correct
> approach because that unit address was actually coming from Power
> Management Unit SFR range so its usage here caused overlapped memory
> mapping.
>
> [...]
Applied, thanks!
[1/1] ARM: dts: exynos: drop deprecated SFR region from MIPI phy
commit: 04398e04173f1be0b21d7cd50c54e8affcebe106
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread