All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Rob Herring <robh@kernel.org>
Cc: "Tony Lindgren" <tony@atomide.com>,
	linux-kernel@vger.kernel.org,
	"Tomer Maimon" <tmaimon77@gmail.com>,
	"Matt Mackall" <mpm@selenic.com>,
	"Avi Fishman" <avifishman70@gmail.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Nishanth Menon" <nm@ti.com>,
	"Patrick Venture" <venture@google.com>,
	openbmc@lists.ozlabs.org, "Pali Rohár" <pali@kernel.org>,
	"Khuong Dinh" <khuong@os.amperecomputing.com>,
	linux-crypto@vger.kernel.org,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Tali Perry" <tali.perry1@gmail.com>,
	devicetree@vger.kernel.org,
	"Benjamin Fair" <benjaminfair@google.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Nancy Yuen" <yuenn@google.com>,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	"Santosh Shilimkar" <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/8] dt-bindings: rng: atmel,at91-trng: convert Atmel TRNG to dtschema
Date: Mon, 3 Jan 2022 18:36:37 +0100	[thread overview]
Message-ID: <045f43d9-58e5-72a6-10fc-e47d875aeb21@microchip.com> (raw)
In-Reply-To: <5a3d7233-8ce0-dbb5-aac4-393caadf2a6a@canonical.com>

On 28/12/2021 at 14:07, Krzysztof Kozlowski wrote:
> On 28/12/2021 13:54, Rob Herring wrote:
>> On Mon, 27 Dec 2021 19:32:45 +0100, Krzysztof Kozlowski wrote:
>>> Convert the Atmel TRNG bindings to DT schema.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>>   .../bindings/rng/atmel,at91-trng.yaml         | 46 +++++++++++++++++++
>>>   .../devicetree/bindings/rng/atmel-trng.txt    | 16 -------
>>>   2 files changed, 46 insertions(+), 16 deletions(-)
>>>   create mode 100644 Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml
>>>   delete mode 100644 Documentation/devicetree/bindings/rng/atmel-trng.txt
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/1573492
>>
>>
>> rng@e2010000: compatible:0: 'microchip,sama7g5-trng' is not one of ['atmel,at91sam9g45-trng', 'microchip,sam9x60-trng']
>>        arch/arm/boot/dts/at91-sama7g5ek.dt.yaml
>>
>> rng@e2010000: compatible: Additional items are not allowed ('atmel,at91sam9g45-trng' was unexpected)
>>        arch/arm/boot/dts/at91-sama7g5ek.dt.yaml
>>
>> rng@e2010000: compatible: ['microchip,sama7g5-trng', 'atmel,at91sam9g45-trng'] is too long
>>        arch/arm/boot/dts/at91-sama7g5ek.dt.yaml
>>
> 
> This patch is only converting the existing bindings, so new compatible
> is not added. The issue reported here is being fixed in the next patch
> (3/8).

Thanks Krzysztof!
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Best regards,
   Nicolas


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Rob Herring <robh@kernel.org>
Cc: "Tony Lindgren" <tony@atomide.com>,
	linux-kernel@vger.kernel.org,
	"Tomer Maimon" <tmaimon77@gmail.com>,
	"Matt Mackall" <mpm@selenic.com>,
	"Avi Fishman" <avifishman70@gmail.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Nishanth Menon" <nm@ti.com>,
	"Patrick Venture" <venture@google.com>,
	openbmc@lists.ozlabs.org, "Pali Rohár" <pali@kernel.org>,
	"Khuong Dinh" <khuong@os.amperecomputing.com>,
	linux-crypto@vger.kernel.org,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Tali Perry" <tali.perry1@gmail.com>,
	devicetree@vger.kernel.org,
	"Benjamin Fair" <benjaminfair@google.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Nancy Yuen" <yuenn@google.com>,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	"Santosh Shilimkar" <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/8] dt-bindings: rng: atmel, at91-trng: convert Atmel TRNG to dtschema
Date: Mon, 3 Jan 2022 18:36:37 +0100	[thread overview]
Message-ID: <045f43d9-58e5-72a6-10fc-e47d875aeb21@microchip.com> (raw)
In-Reply-To: <5a3d7233-8ce0-dbb5-aac4-393caadf2a6a@canonical.com>

On 28/12/2021 at 14:07, Krzysztof Kozlowski wrote:
> On 28/12/2021 13:54, Rob Herring wrote:
>> On Mon, 27 Dec 2021 19:32:45 +0100, Krzysztof Kozlowski wrote:
>>> Convert the Atmel TRNG bindings to DT schema.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>>   .../bindings/rng/atmel,at91-trng.yaml         | 46 +++++++++++++++++++
>>>   .../devicetree/bindings/rng/atmel-trng.txt    | 16 -------
>>>   2 files changed, 46 insertions(+), 16 deletions(-)
>>>   create mode 100644 Documentation/devicetree/bindings/rng/atmel,at91-trng.yaml
>>>   delete mode 100644 Documentation/devicetree/bindings/rng/atmel-trng.txt
>>>
>>
>> Running 'make dtbs_check' with the schema in this patch gives the
>> following warnings. Consider if they are expected or the schema is
>> incorrect. These may not be new warnings.
>>
>> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>> This will change in the future.
>>
>> Full log is available here: https://patchwork.ozlabs.org/patch/1573492
>>
>>
>> rng@e2010000: compatible:0: 'microchip,sama7g5-trng' is not one of ['atmel,at91sam9g45-trng', 'microchip,sam9x60-trng']
>>        arch/arm/boot/dts/at91-sama7g5ek.dt.yaml
>>
>> rng@e2010000: compatible: Additional items are not allowed ('atmel,at91sam9g45-trng' was unexpected)
>>        arch/arm/boot/dts/at91-sama7g5ek.dt.yaml
>>
>> rng@e2010000: compatible: ['microchip,sama7g5-trng', 'atmel,at91sam9g45-trng'] is too long
>>        arch/arm/boot/dts/at91-sama7g5ek.dt.yaml
>>
> 
> This patch is only converting the existing bindings, so new compatible
> is not added. The issue reported here is being fixed in the next patch
> (3/8).

Thanks Krzysztof!
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Best regards,
   Nicolas


-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-03 17:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27 18:32 [PATCH 1/8] dt-bindings: rng: apm,x-gene-rng: convert APM RNG to dtschema Krzysztof Kozlowski
2021-12-27 18:32 ` [PATCH 1/8] dt-bindings: rng: apm, x-gene-rng: " Krzysztof Kozlowski
2021-12-27 18:32 ` [PATCH 2/8] dt-bindings: rng: atmel,at91-trng: convert Atmel TRNG " Krzysztof Kozlowski
2021-12-27 18:32   ` [PATCH 2/8] dt-bindings: rng: atmel, at91-trng: " Krzysztof Kozlowski
2021-12-28 12:54   ` [PATCH 2/8] dt-bindings: rng: atmel,at91-trng: " Rob Herring
2021-12-28 12:54     ` [PATCH 2/8] dt-bindings: rng: atmel, at91-trng: " Rob Herring
2021-12-28 12:54     ` Rob Herring
2021-12-28 13:07     ` [PATCH 2/8] dt-bindings: rng: atmel,at91-trng: " Krzysztof Kozlowski
2021-12-28 13:07       ` [PATCH 2/8] dt-bindings: rng: atmel, at91-trng: " Krzysztof Kozlowski
2022-01-03 17:36       ` Nicolas Ferre [this message]
2022-01-03 17:36         ` Nicolas Ferre
2021-12-27 18:32 ` [PATCH 3/8] dt-bindings: rng: atmel,at91-trng: document sama7g5 TRNG Krzysztof Kozlowski
2021-12-27 18:32   ` Krzysztof Kozlowski
2022-01-03 17:35   ` Nicolas Ferre
2022-01-03 17:35     ` Nicolas Ferre
2021-12-27 18:32 ` [PATCH 4/8] dt-bindings: rng: ti,keystone-rng: convert TI Keystone RNG to dtschema Krzysztof Kozlowski
2021-12-27 18:32   ` [PATCH 4/8] dt-bindings: rng: ti, keystone-rng: " Krzysztof Kozlowski
2021-12-27 18:32 ` [PATCH 5/8] dt-bindings: rng: nuvoton,npcm-rng: convert Nuvoton NPCM " Krzysztof Kozlowski
2021-12-27 18:32   ` [PATCH 5/8] dt-bindings: rng: nuvoton, npcm-rng: " Krzysztof Kozlowski
2021-12-27 18:32 ` [PATCH 6/8] dt-bindings: rng: ti,omap-rom-rng: convert OMAP ROM " Krzysztof Kozlowski
2021-12-27 18:32   ` [PATCH 6/8] dt-bindings: rng: ti, omap-rom-rng: " Krzysztof Kozlowski
2021-12-27 18:32 ` [PATCH 7/8] dt-bindings: rng: st,rng: convert ST " Krzysztof Kozlowski
2021-12-27 18:32   ` Krzysztof Kozlowski
2021-12-27 18:32 ` [PATCH 8/8] dt-bindings: rng: timeriomem_rng: convert TimerIO " Krzysztof Kozlowski
2021-12-27 18:32   ` Krzysztof Kozlowski
2022-01-05 13:30 ` [PATCH 1/8] dt-bindings: rng: apm,x-gene-rng: convert APM " Rob Herring
2022-01-05 13:30   ` [PATCH 1/8] dt-bindings: rng: apm, x-gene-rng: " Rob Herring
2022-01-05 13:30   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=045f43d9-58e5-72a6-10fc-e47d875aeb21@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=khuong@os.amperecomputing.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=mpm@selenic.com \
    --cc=nm@ti.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=pali@kernel.org \
    --cc=patrice.chotard@foss.st.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=tali.perry1@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=tony@atomide.com \
    --cc=venture@google.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.