From: Kukjin Kim <kgene@kernel.org>
To: 'Krzysztof Kozlowski' <k.kozlowski@samsung.com>,
'Ben Dooks' <ben-linux@fluff.org>,
'Russell King' <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: 'Kyungmin Park' <kyungmin.park@samsung.com>,
'Marek Szyprowski' <m.szyprowski@samsung.com>,
'Bartlomiej Zolnierkiewicz' <b.zolnierkie@samsung.com>
Subject: RE: [PATCH v2] ARM: dts: exynos4412-trats: Add micro SD card SDHCI node
Date: Tue, 28 Oct 2014 19:57:40 +0900 [thread overview]
Message-ID: <047101cff29d$fdedc880$f9c95980$@kernel.org> (raw)
In-Reply-To: <1414421995-22618-1-git-send-email-k.kozlowski@samsung.com>
Krzysztof Kozlowski wrote:
>
Hi,
> Add SDHCI node for supporting the micro SD card. On Trats2 board the
> SDHCI does not use sd2_cd pins (gpk2-2) for card detect but gpx3-4
> instead.
>
> Power is supplied from LDO21 regulator which in off state is controlled
> by external GPIO pin.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> Changes since v1:
> 1. Drop FIXME comment (about findings during testing).
> ---
> arch/arm/boot/dts/exynos4412-trats2.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index a5aa52bba72c..7a68e0832cd6 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -603,6 +603,16 @@
> cap-mmc-highspeed;
> };
>
> + sdhci@12530000 {
> + bus-width = <4>;
> + cd-gpios = <&gpx3 4 0>;
> + cd-inverted;
> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4>;
> + pinctrl-names = "default";
> + vmmc-supply = <&ldo21_reg>;
> + status = "okay";
> + };
> +
> serial@13800000 {
> status = "okay";
> };
> --
> 1.9.1
Looks good to me, will apply.
Thanks,
Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: exynos4412-trats: Add micro SD card SDHCI node
Date: Tue, 28 Oct 2014 19:57:40 +0900 [thread overview]
Message-ID: <047101cff29d$fdedc880$f9c95980$@kernel.org> (raw)
In-Reply-To: <1414421995-22618-1-git-send-email-k.kozlowski@samsung.com>
Krzysztof Kozlowski wrote:
>
Hi,
> Add SDHCI node for supporting the micro SD card. On Trats2 board the
> SDHCI does not use sd2_cd pins (gpk2-2) for card detect but gpx3-4
> instead.
>
> Power is supplied from LDO21 regulator which in off state is controlled
> by external GPIO pin.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> Changes since v1:
> 1. Drop FIXME comment (about findings during testing).
> ---
> arch/arm/boot/dts/exynos4412-trats2.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index a5aa52bba72c..7a68e0832cd6 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -603,6 +603,16 @@
> cap-mmc-highspeed;
> };
>
> + sdhci at 12530000 {
> + bus-width = <4>;
> + cd-gpios = <&gpx3 4 0>;
> + cd-inverted;
> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4>;
> + pinctrl-names = "default";
> + vmmc-supply = <&ldo21_reg>;
> + status = "okay";
> + };
> +
> serial at 13800000 {
> status = "okay";
> };
> --
> 1.9.1
Looks good to me, will apply.
Thanks,
Kukjin
next prev parent reply other threads:[~2014-10-28 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 14:59 [PATCH v2] ARM: dts: exynos4412-trats: Add micro SD card SDHCI node Krzysztof Kozlowski
2014-10-27 14:59 ` Krzysztof Kozlowski
2014-10-28 10:57 ` Kukjin Kim [this message]
2014-10-28 10:57 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='047101cff29d$fdedc880$f9c95980$@kernel.org' \
--to=kgene@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.