All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom St Denis <tom.stdenis-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx mailing list
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: unclear code in vega10 pp
Date: Tue, 5 Sep 2017 12:18:26 -0400	[thread overview]
Message-ID: <04aae9c8-9d67-e3d7-e2b4-a6d14b58b3ed@amd.com> (raw)

In vega10_populate_smc_link_levels(): there's this bit

	j = i - 1;
	while (i < NUM_LINK_LEVELS) {
		pp_table->PcieGenSpeed[i] = pcie_table->pcie_gen[j];
		pp_table->PcieLaneCount[i] = pcie_table->pcie_lane[j];

		result = vega10_populate_single_lclk_level(hwmgr,
				pcie_table->lclk[j], &(pp_table->LclkDid[i]));
		if (result) {
			pr_info("Populate LClock Level %d Failed!\n", i);
			return result;
		}
		i++;
	}

It seems 'j' isn't changing so it's spamming multiple entries in the 
lclkdid[] array based on the same entries from the pcie_table->pcie*[j].

Is that intentional or is a ++ or -- to j missing?

Cheers,
Tom
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

             reply	other threads:[~2017-09-05 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 16:18 Tom St Denis [this message]
     [not found] ` <04aae9c8-9d67-e3d7-e2b4-a6d14b58b3ed-5C7GfCeVMHo@public.gmane.org>
2017-09-05 16:22   ` unclear code in vega10 pp Tom St Denis
     [not found]     ` <1bd6c44f-87cc-4dbc-50f6-b2dbd822e0c8-5C7GfCeVMHo@public.gmane.org>
2017-09-06  1:12       ` Zhu, Rex

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04aae9c8-9d67-e3d7-e2b4-a6d14b58b3ed@amd.com \
    --to=tom.stdenis-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.