All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene@kernel.org>
To: 'Javier Martinez Canillas' <javier.martinez@collabora.co.uk>
Cc: 'Doug Anderson' <dianders@chromium.org>,
	'Kevin Hilman' <khilman@linaro.org>,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: RE: [PATCH 1/1] ARM: exynos_defconfig: Enable max77802 rtc and clock drivers
Date: Tue, 28 Oct 2014 20:06:40 +0900	[thread overview]
Message-ID: <04e101cff29f$4021ea00$c065be00$@kernel.org> (raw)
In-Reply-To: <1414401440-10972-1-git-send-email-javier.martinez@collabora.co.uk>

Javier Martinez Canillas wrote:
> 
Hi,

> Commit 6e80e3d87549 ("ARM: exynos_defconfig: Enable MAX77802")
> enabled support for the max77802 regulators but the PMIC also
> has a Real-Time-Clock (RTC) and 2-channel 32kHz clock outputs.
> 
Yes, right.

> Enable the kernel config options to have the drivers for these
> devices built-in since they are present in many Exynos boards.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Acked-by: Kevin Hilman <khilman@linaro.org>
> Tested-by: Kevin Hilman <khilman@linaro.org>
> ---
> 
> This patch supersedes [0] since commit "ARM: exynos_defconfig: savedefconfig"
> is not present in linux-next anymore which disabled among other options, the
> max77802 support.
> 
Yeah, I talked about savedefconfig with Bart and I decided to revert it at that
time.

> However, support for the max77802 rtc and clocks were not enabled on exynos
> defconfig so $subject is still needed.
> 
> Kevin, I carried your tags from [0] since $subject enables the options you
> needed to get RTC wakeup from suspend working on exynos5800-peach-pi. Please
> let me know if they no longer applies.
> 
> Best regards,
> Javier
> 
> [0]: https://lkml.org/lkml/2014/10/9/413
> 
>  arch/arm/configs/exynos_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 72058b8..e21ef83 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -142,11 +142,13 @@ CONFIG_MMC_DW_IDMAC=y
>  CONFIG_MMC_DW_EXYNOS=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_MAX77686=y
> +CONFIG_RTC_DRV_MAX77802=y
>  CONFIG_RTC_DRV_S5M=y
>  CONFIG_RTC_DRV_S3C=y
>  CONFIG_DMADEVICES=y
>  CONFIG_PL330_DMA=y
>  CONFIG_COMMON_CLK_MAX77686=y
> +CONFIG_COMMON_CLK_MAX77802=y
>  CONFIG_COMMON_CLK_S2MPS11=y
>  CONFIG_EXYNOS_IOMMU=y
>  CONFIG_IIO=y
> --
> 2.1.0

I'll apply this, thanks.

- Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: exynos_defconfig: Enable max77802 rtc and clock drivers
Date: Tue, 28 Oct 2014 20:06:40 +0900	[thread overview]
Message-ID: <04e101cff29f$4021ea00$c065be00$@kernel.org> (raw)
In-Reply-To: <1414401440-10972-1-git-send-email-javier.martinez@collabora.co.uk>

Javier Martinez Canillas wrote:
> 
Hi,

> Commit 6e80e3d87549 ("ARM: exynos_defconfig: Enable MAX77802")
> enabled support for the max77802 regulators but the PMIC also
> has a Real-Time-Clock (RTC) and 2-channel 32kHz clock outputs.
> 
Yes, right.

> Enable the kernel config options to have the drivers for these
> devices built-in since they are present in many Exynos boards.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Acked-by: Kevin Hilman <khilman@linaro.org>
> Tested-by: Kevin Hilman <khilman@linaro.org>
> ---
> 
> This patch supersedes [0] since commit "ARM: exynos_defconfig: savedefconfig"
> is not present in linux-next anymore which disabled among other options, the
> max77802 support.
> 
Yeah, I talked about savedefconfig with Bart and I decided to revert it at that
time.

> However, support for the max77802 rtc and clocks were not enabled on exynos
> defconfig so $subject is still needed.
> 
> Kevin, I carried your tags from [0] since $subject enables the options you
> needed to get RTC wakeup from suspend working on exynos5800-peach-pi. Please
> let me know if they no longer applies.
> 
> Best regards,
> Javier
> 
> [0]: https://lkml.org/lkml/2014/10/9/413
> 
>  arch/arm/configs/exynos_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 72058b8..e21ef83 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -142,11 +142,13 @@ CONFIG_MMC_DW_IDMAC=y
>  CONFIG_MMC_DW_EXYNOS=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_MAX77686=y
> +CONFIG_RTC_DRV_MAX77802=y
>  CONFIG_RTC_DRV_S5M=y
>  CONFIG_RTC_DRV_S3C=y
>  CONFIG_DMADEVICES=y
>  CONFIG_PL330_DMA=y
>  CONFIG_COMMON_CLK_MAX77686=y
> +CONFIG_COMMON_CLK_MAX77802=y
>  CONFIG_COMMON_CLK_S2MPS11=y
>  CONFIG_EXYNOS_IOMMU=y
>  CONFIG_IIO=y
> --
> 2.1.0

I'll apply this, thanks.

- Kukjin

  reply	other threads:[~2014-10-28 11:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27  9:17 [PATCH 1/1] ARM: exynos_defconfig: Enable max77802 rtc and clock drivers Javier Martinez Canillas
2014-10-27  9:17 ` Javier Martinez Canillas
2014-10-28 11:06 ` Kukjin Kim [this message]
2014-10-28 11:06   ` Kukjin Kim
2014-11-13  8:45   ` Javier Martinez Canillas
2014-11-13  8:45     ` Javier Martinez Canillas
2014-11-19  8:09     ` Kukjin Kim
2014-11-19  8:09       ` Kukjin Kim
2014-11-19 10:17       ` Javier Martinez Canillas
2014-11-19 10:17         ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='04e101cff29f$4021ea00$c065be00$@kernel.org' \
    --to=kgene@kernel.org \
    --cc=dianders@chromium.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.