From: Guanqun Lu <guanqun.lu@intel.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH 3 of 3] fix S3 resume error
Date: Mon, 23 Feb 2009 23:27:49 +0800 [thread overview]
Message-ID: <04e7e4e8519fbbd2ec14.1235402869@localhost.localdomain> (raw)
In-Reply-To: <patchbomb.1235402866@localhost.localdomain>
# HG changeset patch
# User Guanqun Lu <guanqun.lu@intel.com>
# Date 1235401627 -28800
# Node ID 04e7e4e8519fbbd2ec141875d466ea8ca038d553
# Parent 0e17f070db2aa92bc74f29245cdb8528aa72bbe3
fix S3 resume error
spin_lock() usage in do_settime() in this situation is invoked
when irq is disabled, which causes check_lock() BUG_ON().
We bypass the check by using spin_debug_disable(). It's safe
since no other CPUs are online yet at this moment.
Signed-off-by: Guanqun Lu <guanqun.lu@intel.com>
diff -r 0e17f070db2a -r 04e7e4e8519f xen/arch/x86/time.c
--- a/xen/arch/x86/time.c Mon Feb 23 23:07:01 2009 +0800
+++ b/xen/arch/x86/time.c Mon Feb 23 23:07:07 2009 +0800
@@ -1300,7 +1300,9 @@ int time_resume(void)
init_percpu_time();
+ spin_debug_disable();
do_settime(get_cmos_time() + cmos_utc_offset, 0, NOW());
+ spin_debug_enable();
update_vcpu_system_time(current);
prev parent reply other threads:[~2009-02-23 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 15:27 [PATCH 0 of 3] fix S3 suspend and resume error Guanqun Lu
2009-02-23 15:27 ` [PATCH 1 of 3] fix S3 suspend error Guanqun Lu
2009-02-23 12:38 ` Keir Fraser
2009-02-23 12:46 ` Tian, Kevin
2009-02-23 13:15 ` Keir Fraser
2009-02-23 13:45 ` Keir Fraser
2009-02-23 15:27 ` [PATCH 2 " Guanqun Lu
2009-02-23 15:27 ` Guanqun Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04e7e4e8519fbbd2ec14.1235402869@localhost.localdomain \
--to=guanqun.lu@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.