From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Guanqun Lu <guanqun.lu@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 1 of 3] fix S3 suspend error
Date: Mon, 23 Feb 2009 04:38:55 -0800 [thread overview]
Message-ID: <C5C7D8DF.3178%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <b713518a241b6f6e07ed.1235402867@localhost.localdomain>
On 23/02/2009 07:27, "Guanqun Lu" <guanqun.lu@intel.com> wrote:
> fix S3 suspend error.
>
> invoke ioapic_pm_state_alloc() eariler,
> thus avoiding check_lock() BUG_ON() in spin_lock().
>
> Signed-off-by: Guanqun Lu <guanqun.lu@intel.com>
This one I think is a good idea anyway. The other two -- I wonder why we do
device suspend/resume with IRQs disabled? As far as I can tell Linux does
not do that. So would it be cleaner to move the device suspend/resume hooks
outside the IRQs-disabled region?
-- Keir
next prev parent reply other threads:[~2009-02-23 12:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 15:27 [PATCH 0 of 3] fix S3 suspend and resume error Guanqun Lu
2009-02-23 15:27 ` [PATCH 1 of 3] fix S3 suspend error Guanqun Lu
2009-02-23 12:38 ` Keir Fraser [this message]
2009-02-23 12:46 ` Tian, Kevin
2009-02-23 13:15 ` Keir Fraser
2009-02-23 13:45 ` Keir Fraser
2009-02-23 15:27 ` [PATCH 2 " Guanqun Lu
2009-02-23 15:27 ` [PATCH 3 of 3] fix S3 resume error Guanqun Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5C7D8DF.3178%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=guanqun.lu@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.