All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Branislav Rankov <Branislav.Rankov@arm.com>,
	Marco Elver <elver@google.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Evgenii Stepanov <eugenis@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Alexander Potapenko <glider@google.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH v5 4/6] arm64: mte: Enable async tag check fault
Date: Fri, 22 Jan 2021 11:24:28 +0000	[thread overview]
Message-ID: <04eba2be-641b-ee23-7fa0-436c33168cd8@arm.com> (raw)
In-Reply-To: <CAAeHK+y9HbV6yVJ0f819Y=_6ijkKq06rqJSY+mh4NF4qd8t_oA@mail.gmail.com>



On 1/21/21 5:38 PM, Andrey Konovalov wrote:
>> +       if (unlikely(tfsr_el1 & SYS_TFSR_EL1_TF1)) {
>> +               /*
>> +                * Note: isb() is not required after this direct write
>> +                * because there is no indirect read subsequent to it
>> +                * (per ARM DDI 0487F.c table D13-1).
>> +                */
>> +               write_sysreg_s(0, SYS_TFSR_EL1);
>> +
>> +               kasan_report_async();
> Do we need a static bool reported like in do_tag_recovery() here?
> 

I would say not because async mode does not get disabled after the first fault.

-- 
Regards,
Vincenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kasan-dev <kasan-dev@googlegroups.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Alexander Potapenko <glider@google.com>,
	Marco Elver <elver@google.com>,
	Evgenii Stepanov <eugenis@google.com>,
	Branislav Rankov <Branislav.Rankov@arm.com>
Subject: Re: [PATCH v5 4/6] arm64: mte: Enable async tag check fault
Date: Fri, 22 Jan 2021 11:24:28 +0000	[thread overview]
Message-ID: <04eba2be-641b-ee23-7fa0-436c33168cd8@arm.com> (raw)
In-Reply-To: <CAAeHK+y9HbV6yVJ0f819Y=_6ijkKq06rqJSY+mh4NF4qd8t_oA@mail.gmail.com>



On 1/21/21 5:38 PM, Andrey Konovalov wrote:
>> +       if (unlikely(tfsr_el1 & SYS_TFSR_EL1_TF1)) {
>> +               /*
>> +                * Note: isb() is not required after this direct write
>> +                * because there is no indirect read subsequent to it
>> +                * (per ARM DDI 0487F.c table D13-1).
>> +                */
>> +               write_sysreg_s(0, SYS_TFSR_EL1);
>> +
>> +               kasan_report_async();
> Do we need a static bool reported like in do_tag_recovery() here?
> 

I would say not because async mode does not get disabled after the first fault.

-- 
Regards,
Vincenzo

  reply	other threads:[~2021-01-22 11:22 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 16:39 [PATCH v5 0/6] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino
2021-01-21 16:39 ` Vincenzo Frascino
2021-01-21 16:39 ` [PATCH v5 1/6] arm64: mte: Add asynchronous " Vincenzo Frascino
2021-01-21 16:39   ` Vincenzo Frascino
2021-01-21 16:39 ` [PATCH v5 2/6] kasan: Add KASAN mode kernel parameter Vincenzo Frascino
2021-01-21 16:39   ` Vincenzo Frascino
2021-01-21 17:34   ` Andrey Konovalov
2021-01-21 17:34     ` Andrey Konovalov
2021-01-22 11:25     ` Vincenzo Frascino
2021-01-22 11:25       ` Vincenzo Frascino
2021-01-21 16:39 ` [PATCH v5 3/6] kasan: Add report for async mode Vincenzo Frascino
2021-01-21 16:39   ` Vincenzo Frascino
2021-01-21 17:36   ` Andrey Konovalov
2021-01-21 17:36     ` Andrey Konovalov
2021-01-22  2:45   ` kernel test robot
2021-01-22  2:45     ` kernel test robot
2021-01-22  2:45     ` kernel test robot
2021-01-22  2:46   ` kernel test robot
2021-01-22  2:46     ` kernel test robot
2021-01-22  2:46     ` kernel test robot
2021-01-22 13:19   ` Catalin Marinas
2021-01-22 13:19     ` Catalin Marinas
2021-01-22 13:27     ` Vincenzo Frascino
2021-01-22 13:27       ` Vincenzo Frascino
2021-01-22 13:38       ` Vincenzo Frascino
2021-01-22 13:38         ` Vincenzo Frascino
2021-01-21 16:39 ` [PATCH v5 4/6] arm64: mte: Enable async tag check fault Vincenzo Frascino
2021-01-21 16:39   ` Vincenzo Frascino
2021-01-21 17:38   ` Andrey Konovalov
2021-01-21 17:38     ` Andrey Konovalov
2021-01-22 11:24     ` Vincenzo Frascino [this message]
2021-01-22 11:24       ` Vincenzo Frascino
2021-01-22 11:58   ` Catalin Marinas
2021-01-22 11:58     ` Catalin Marinas
2021-01-21 16:39 ` [PATCH v5 5/6] arm64: mte: Expose execution mode Vincenzo Frascino
2021-01-21 16:39   ` Vincenzo Frascino
2021-01-21 17:41   ` Andrey Konovalov
2021-01-21 17:41     ` Andrey Konovalov
2021-01-21 16:39 ` [PATCH v5 6/6] kasan: Forbid kunit tests when async mode is enabled Vincenzo Frascino
2021-01-21 16:39   ` Vincenzo Frascino
2021-01-21 17:40   ` Andrey Konovalov
2021-01-21 17:40     ` Andrey Konovalov
2021-01-22 11:26     ` Vincenzo Frascino
2021-01-22 11:26       ` Vincenzo Frascino
2021-01-22 12:00     ` Catalin Marinas
2021-01-22 12:00       ` Catalin Marinas
2021-01-22  4:04   ` kernel test robot
2021-01-22  4:04     ` kernel test robot
2021-01-22  4:04     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04eba2be-641b-ee23-7fa0-436c33168cd8@arm.com \
    --to=vincenzo.frascino@arm.com \
    --cc=Branislav.Rankov@arm.com \
    --cc=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=catalin.marinas@arm.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=eugenis@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.