From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Alexey Galakhov' <agalakhov@gmail.com>,
linux-samsung-soc@vger.kernel.org
Cc: 'Padmavathi Venna' <padma.v@samsung.com>,
'Sangbeom Kim' <sbkim73@samsung.com>,
'Mark Brown' <broonie@opensource.wolfsonmicro.com>,
'Kukjin Kim' <kgene.kim@samsung.com>
Subject: RE: [PATCH] Fix compilation error on S3C2440
Date: Mon, 28 Jan 2013 22:06:24 -0800 [thread overview]
Message-ID: <05e201cdfde6$c711cb70$55356250$@samsung.com> (raw)
In-Reply-To: <1359392823-30529-1-git-send-email-agalakhov@gmail.com>
Alexey Galakhov wrote:
>
> There was a compilation error introduced on Dec 7, 2012
> by commit a08485d8fdf6f67ca5f173b68d8f873c574745f2.
>
Following is better:
The commit a08485d8 ("ASoC: Samsung: Do not register samsung audio dma
device as pdev") introduced compilation error.
> Combination of CONFIG_CPU_S3C2440 and CONFIG_SND_S3C24XX_I2S
> caused the following:
> sound/soc/samsung/s3c24xx-i2s.c: In function 's3c24xx_iis_dev_probe':
> sound/soc/samsung/s3c24xx-i2s.c:472:2: error: implicit declaration of
> function 's3c_i2sv2_register_dai' [-Werror=implicit-function-declaration]
> sound/soc/samsung/s3c24xx-i2s.c:472:48: error: 's3c2412_i2s_dai'
> undeclared (first use in this function)
>
> This patch fixes the problem and makes S3C2440 I2S usable again.
>
> Signed-off-by: Alexey Galakhov <agalakhov@gmail.com>
Cc: Padmavathi Venna <padma.v@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/samsung/s3c24xx-i2s.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/samsung/s3c24xx-i2s.c
> b/sound/soc/samsung/s3c24xx-i2s.c
> index ee10e87..13f6dd1 100644
> --- a/sound/soc/samsung/s3c24xx-i2s.c
> +++ b/sound/soc/samsung/s3c24xx-i2s.c
> @@ -469,7 +469,7 @@ static int s3c24xx_iis_dev_probe(struct
> platform_device *pdev)
> {
> int ret = 0;
>
> - ret = s3c_i2sv2_register_dai(&pdev->dev, -1, &s3c2412_i2s_dai);
> + ret = snd_soc_register_dai(&pdev->dev, &s3c24xx_i2s_dai);
> if (ret) {
> pr_err("failed to register the dai\n");
> return ret;
> --
> 1.7.10.4
next prev parent reply other threads:[~2013-01-29 6:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 17:07 [PATCH] Fix compilation error on S3C2440 Alexey Galakhov
2013-01-29 6:06 ` Kukjin Kim [this message]
2013-01-30 2:18 ` Mark Brown
2013-01-30 9:35 ` Alexey Galakhov
2013-01-31 6:49 ` Mark Brown
2013-01-30 9:48 ` Alexey Galakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='05e201cdfde6$c711cb70$55356250$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=agalakhov@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.