From: Alexey Galakhov <agalakhov@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
'Padmavathi Venna' <padma.v@samsung.com>,
'Sangbeom Kim' <sbkim73@samsung.com>
Subject: Re: [PATCH] Fix compilation error on S3C2440
Date: Wed, 30 Jan 2013 15:48:48 +0600 [thread overview]
Message-ID: <5108EC80.9090809@gmail.com> (raw)
In-Reply-To: <20130130021857.GF4945@opensource.wolfsonmicro.com>
On 01/30/2013 08:18 AM, Mark Brown wrote:
> Though I've got a horrible feeling this will conflict with Padma's
> work...
Looks like Padma changed the code for S3C2412 and blindly copy-pasted
the same change for all S3C24xx. However S3C24xx is for I2S-v1 and
S3C2412 is for I2S-v2. The extra stuff in s3c_i2sv2_register_dai() is
unrelated to v1.
After this patch the code works again just like v3.7 one. However the
v3.7 code was already broken (in fact, since v3.2) in the DMA
notification part so it doesn't play sound correctly thus I can't tell
that everything works just fine now :). I found the patch that
introduced the bug (344b4c4) and now I'm debugging it.
prev parent reply other threads:[~2013-01-30 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 17:07 [PATCH] Fix compilation error on S3C2440 Alexey Galakhov
2013-01-29 6:06 ` Kukjin Kim
2013-01-30 2:18 ` Mark Brown
2013-01-30 9:35 ` Alexey Galakhov
2013-01-31 6:49 ` Mark Brown
2013-01-30 9:48 ` Alexey Galakhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5108EC80.9090809@gmail.com \
--to=agalakhov@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=padma.v@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.