* [PATCH] nvdimm: nfit: remove redundant NULL check before vfree()
@ 2026-07-03 14:48 mdshahid03
2026-07-06 22:32 ` Dave Jiang
2026-07-15 0:01 ` Alison Schofield
0 siblings, 2 replies; 3+ messages in thread
From: mdshahid03 @ 2026-07-03 14:48 UTC (permalink / raw)
To: Dan Williams, Vishal Verma, Dave Jiang, Alison Schofield,
Ira Weiny
Cc: nvdimm, linux-kernel, Mohammad Shahid
From: Mohammad Shahid <mdshahid03@gmail.com>
vfree() safely handles NULL pointers, so the explicit NULL check
before calling vfree() is unnecessary.
This issue was reported by ifnullfree.cocci.
Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
---
tools/testing/nvdimm/test/nfit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
index f87e9f251d13..009fe107b0d7 100644
--- a/tools/testing/nvdimm/test/nfit.c
+++ b/tools/testing/nvdimm/test/nfit.c
@@ -1644,8 +1644,7 @@ static void *__test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma,
err:
if (*dma && size >= DIMM_SIZE)
gen_pool_free(nfit_pool, *dma, size);
- if (buf)
- vfree(buf);
+ vfree(buf);
kfree(nfit_res);
return NULL;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nvdimm: nfit: remove redundant NULL check before vfree()
2026-07-03 14:48 [PATCH] nvdimm: nfit: remove redundant NULL check before vfree() mdshahid03
@ 2026-07-06 22:32 ` Dave Jiang
2026-07-15 0:01 ` Alison Schofield
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2026-07-06 22:32 UTC (permalink / raw)
To: mdshahid03, Dan Williams, Vishal Verma, Alison Schofield,
Ira Weiny
Cc: nvdimm, linux-kernel
On 7/3/26 7:48 AM, mdshahid03@gmail.com wrote:
> From: Mohammad Shahid <mdshahid03@gmail.com>
>
> vfree() safely handles NULL pointers, so the explicit NULL check
> before calling vfree() is unnecessary.
>
> This issue was reported by ifnullfree.cocci.
>
> Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> tools/testing/nvdimm/test/nfit.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
> index f87e9f251d13..009fe107b0d7 100644
> --- a/tools/testing/nvdimm/test/nfit.c
> +++ b/tools/testing/nvdimm/test/nfit.c
> @@ -1644,8 +1644,7 @@ static void *__test_alloc(struct nfit_test *t, size_t size, dma_addr_t *dma,
> err:
> if (*dma && size >= DIMM_SIZE)
> gen_pool_free(nfit_pool, *dma, size);
> - if (buf)
> - vfree(buf);
> + vfree(buf);
> kfree(nfit_res);
> return NULL;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nvdimm: nfit: remove redundant NULL check before vfree()
2026-07-03 14:48 [PATCH] nvdimm: nfit: remove redundant NULL check before vfree() mdshahid03
2026-07-06 22:32 ` Dave Jiang
@ 2026-07-15 0:01 ` Alison Schofield
1 sibling, 0 replies; 3+ messages in thread
From: Alison Schofield @ 2026-07-15 0:01 UTC (permalink / raw)
To: mdshahid03
Cc: Dan Williams, Vishal Verma, Dave Jiang, Ira Weiny, nvdimm,
linux-kernel
On Fri, Jul 03, 2026 at 08:18:51PM +0530, mdshahid03@gmail.com wrote:
> From: Mohammad Shahid <mdshahid03@gmail.com>
>
> vfree() safely handles NULL pointers, so the explicit NULL check
> before calling vfree() is unnecessary.
>
> This issue was reported by ifnullfree.cocci.
>
> Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
Applied to libnvdimm-for-next:
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-15 0:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-03 14:48 [PATCH] nvdimm: nfit: remove redundant NULL check before vfree() mdshahid03
2026-07-06 22:32 ` Dave Jiang
2026-07-15 0:01 ` Alison Schofield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.