Re: [PATCH v2 1/2] dt-bindings: phy: samsung,usb3-drd-phy: add dt-schema for ExynosAutov920

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pritam Manohar Sutar <pritam.sutar@samsung.com>,
	vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com,
	andre.draszik@linaro.org, peter.griffin@linaro.org,
	kauschluss@disroot.org, m.szyprowski@samsung.com,
	s.nawrocki@samsung.com
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, rosa.pila@samsung.com,
	dev.tailor@samsung.com, faraz.ata@samsung.com,
	muhammed.ali@samsung.com, selvarasu.g@samsung.com
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: samsung,usb3-drd-phy: add dt-schema for ExynosAutov920
Date: Tue, 20 May 2025 09:45:12 +0200	[thread overview]
Message-ID: <0615877e-247a-419b-b4d6-de377cb40914@kernel.org> (raw)
In-Reply-To: <20250516102650.2144487-2-pritam.sutar@samsung.com>

On 16/05/2025 12:26, Pritam Manohar Sutar wrote:
> Add a dedicated compatible for USB phy found in this SoC
> 
> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> ---
>  .../bindings/phy/samsung,usb3-drd-phy.yaml    | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)

A nit, subject: drop second/last, redundant "dt-schema for". The
"dt-bindings" prefix is already stating that these are bindings in
dtschema format.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> 
> diff --git a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
> index fdddddc7d611..c50f4218ded9 100644
> --- a/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/samsung,usb3-drd-phy.yaml
> @@ -32,6 +32,7 @@ properties:
>        - samsung,exynos7-usbdrd-phy
>        - samsung,exynos7870-usbdrd-phy
>        - samsung,exynos850-usbdrd-phy
> +      - samsung,exynosautov920-usb31drd-phy
>  
>    clocks:
>      minItems: 2
> @@ -204,6 +205,32 @@ allOf:
>          reg-names:
>            maxItems: 1
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: samsung,exynosautov920-usb31drd-phy
> +    then:
> +      $ref: /schemas/usb/usb-switch.yaml#
> +
> +      properties:
> +        clocks:
> +          items:

Why there is no main PHY clock?

> +            - description: ext_xtal clock
> +            - description: reference clock

Both external oscillator and reference clocks? What are these clocks?

> +
> +        clock-names:
> +          items:
> +            - const: ext_xtal
> +            - const: ref
> +
> +        reg:
> +          minItems: 1

No, there is no such syntax. Drop.

> +          maxItems: 1
> +
> +        reg-names:
> +          minItems: 1

No, look at existing code and do the same.

> +
>  unevaluatedProperties: false
>  
>  examples:

Best regards,
Krzysztof