From: Roger Quadros <rogerq@kernel.org>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Whitcroft <apw@canonical.com>,
"mike .." <wingman205@gmx.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Joe Perches <joe@perches.com>, Jonathan Corbet <corbet@lwn.net>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Tero Kristo <kristo@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com
Subject: Re: [PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example
Date: Wed, 30 Apr 2025 17:22:54 +0300 [thread overview]
Message-ID: <06268dcb-4a49-468e-8ebd-d9366a2cf0c2@kernel.org> (raw)
In-Reply-To: <4216050f7b33ce4e5ce54f32023ec6ce093bd83c.1744710099.git.matthias.schiffer@ew.tq-group.com>
Hi Matthias,
On 15/04/2025 13:18, Matthias Schiffer wrote:
> k3-am65-cpsw-nuss controllers have a fixed internal TX delay, so RXID
> mode is not actually possible and will result in a warning from the
> driver going forward.
>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
> .../devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> index b11894fbaec47..c8128b8ca74fb 100644
> --- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
> @@ -282,7 +282,7 @@ examples:
> ti,syscon-efuse = <&mcu_conf 0x200>;
> phys = <&phy_gmii_sel 1>;
>
> - phy-mode = "rgmii-rxid";
> + phy-mode = "rgmii-id";
> phy-handle = <&phy0>;
> };
> };
FYI the following TI boards using this driver are using "rgmii-rxid".
Will you be sending fixes to the device trees files?
arch/arm64/boot/dts/ti
k3-am625-beagleplay.dts: phy-mode = "rgmii-rxid";
k3-am625-sk.dts: phy-mode = "rgmii-rxid";
k3-am625-sk.dts.orig: phy-mode = "rgmii-rxid";
k3-am62a7-sk.dts: phy-mode = "rgmii-rxid";
k3-am62a-phycore-som.dtsi: phy-mode = "rgmii-rxid";
k3-am62p5-sk.dts: phy-mode = "rgmii-rxid";
k3-am62p5-sk.dts: phy-mode = "rgmii-rxid";
k3-am62-phycore-som.dtsi: phy-mode = "rgmii-rxid";
k3-am62-verdin-dev.dtsi: phy-mode = "rgmii-rxid";
k3-am62-verdin.dtsi: phy-mode = "rgmii-rxid";
k3-am62-verdin-ivy.dtsi: phy-mode = "rgmii-rxid";
k3-am62x-phyboard-lyra.dtsi: phy-mode = "rgmii-rxid";
k3-am62x-sk-common.dtsi: phy-mode = "rgmii-rxid";
k3-am642-evm.dts: phy-mode = "rgmii-rxid";
k3-am642-evm.dts: phy-mode = "rgmii-rxid";
k3-am642-sk.dts: phy-mode = "rgmii-rxid";
k3-am642-sk.dts: phy-mode = "rgmii-rxid";
k3-am642-tqma64xxl-mbax4xxl.dts: phy-mode = "rgmii-rxid";
k3-am642-tqma64xxl-mbax4xxl.dts: /* phy-mode is fixed up to rgmii-rxid by prueth driver to account for
k3-am64-phycore-som.dtsi: phy-mode = "rgmii-rxid";
k3-am654-base-board.dts: phy-mode = "rgmii-rxid";
k3-am67a-beagley-ai.dts: phy-mode = "rgmii-rxid";
k3-am68-sk-base-board.dts: phy-mode = "rgmii-rxid";
k3-am69-sk.dts: phy-mode = "rgmii-rxid";
k3-j7200-common-proc-board.dts: phy-mode = "rgmii-rxid";
k3-j721e-beagleboneai64.dts: phy-mode = "rgmii-rxid";
k3-j721e-common-proc-board.dts: phy-mode = "rgmii-rxid";
k3-j721e-evm-gesi-exp-board.dtso: phy-mode = "rgmii-rxid";
k3-j721e-evm-gesi-exp-board.dtso: phy-mode = "rgmii-rxid";
k3-j721e-evm-gesi-exp-board.dtso: phy-mode = "rgmii-rxid";
k3-j721e-evm-gesi-exp-board.dtso: phy-mode = "rgmii-rxid";
k3-j721e-sk.dts: phy-mode = "rgmii-rxid";
k3-j721s2-common-proc-board.dts: phy-mode = "rgmii-rxid";
k3-j721s2-evm-gesi-exp-board.dtso: phy-mode = "rgmii-rxid";
k3-j722s-evm.dts: phy-mode = "rgmii-rxid";
k3-j784s4-j742s2-evm-common.dtsi: phy-mode = "rgmii-rxid";
k3-j784s4-j742s2-evm-common.dtsi: phy-mode = "rgmii-rxid";
--
cheers,
-roger
next prev parent reply other threads:[~2025-04-30 14:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 10:18 [PATCH net-next 0/4] RGMII mode clarification + am65-cpsw fix Matthias Schiffer
2025-04-15 10:18 ` [PATCH net-next 1/4] dt-bindings: net: ethernet-controller: update descriptions of RGMII modes Matthias Schiffer
2025-04-15 10:36 ` Siddharth Vadapalli
2025-04-15 11:28 ` Matthias Schiffer
2025-04-15 11:55 ` Siddharth Vadapalli
2025-04-16 7:41 ` Matthias Schiffer
2025-04-22 8:56 ` Russell King (Oracle)
2025-04-22 14:40 ` Andrew Lunn
2025-04-22 8:41 ` Russell King (Oracle)
2025-04-18 20:40 ` Andrew Lunn
2025-04-22 8:37 ` Russell King (Oracle)
2025-04-15 10:54 ` Maxime Chevallier
2025-04-18 20:26 ` Andrew Lunn
2025-04-21 18:42 ` Rob Herring (Arm)
2025-04-21 19:20 ` Russell King (Oracle)
2025-04-22 15:00 ` Andrew Lunn
2025-04-22 15:31 ` Russell King (Oracle)
2025-04-28 11:29 ` Matthias Schiffer
2025-04-28 14:08 ` Andrew Lunn
2025-04-28 14:28 ` Siddharth Vadapalli
2025-04-28 14:45 ` Andrew Lunn
2025-04-29 7:24 ` Matthias Schiffer
2025-04-29 12:08 ` Andrew Lunn
2025-04-30 7:33 ` Matthias Schiffer
2025-04-15 10:18 ` [PATCH net-next 2/4] dt-bindings: net: ti: k3-am654-cpsw-nuss: update phy-mode in example Matthias Schiffer
2025-04-15 10:58 ` Maxime Chevallier
2025-04-18 20:48 ` Andrew Lunn
2025-04-21 18:44 ` Rob Herring (Arm)
2025-04-30 14:22 ` Roger Quadros [this message]
2025-05-07 9:51 ` Matthias Schiffer
2025-04-15 10:18 ` [PATCH net-next 3/4] net: ethernet: ti: am65-cpsw: fixup PHY mode for fixed RGMII TX delay Matthias Schiffer
2025-04-15 11:06 ` Maxime Chevallier
2025-04-18 20:50 ` Andrew Lunn
2025-04-30 14:56 ` Roger Quadros
2025-04-30 16:15 ` Andrew Lunn
2025-04-15 10:18 ` [PATCH net-next 4/4] checkpatch: check for comment explaining rgmii(|-rxid|-txid) PHY modes Matthias Schiffer
2025-04-15 11:15 ` Maxime Chevallier
2025-04-15 11:21 ` Matthias Schiffer
2025-04-15 12:46 ` Maxime Chevallier
2025-04-15 13:12 ` Andrew Lunn
2025-06-24 9:50 ` Matthias Schiffer
2025-04-15 13:20 ` Andrew Lunn
2025-04-15 13:36 ` Matthias Schiffer
2025-04-15 13:37 ` Matthias Schiffer
2025-04-17 10:28 ` Paolo Abeni
2025-04-15 16:11 ` Joe Perches
2025-04-16 7:48 ` Matthias Schiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06268dcb-4a49-468e-8ebd-d9366a2cf0c2@kernel.org \
--to=rogerq@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=apw@canonical.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwaipayanray1@gmail.com \
--cc=edumazet@google.com \
--cc=joe@perches.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=lukas.bulwahn@gmail.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
--cc=wingman205@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.