From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2 6/7] x86/ucode: Use altcall, and __initconst_cf_clobber
Date: Mon, 14 Feb 2022 14:13:44 +0100 [thread overview]
Message-ID: <06407c26-a189-c4f4-a30b-3bf802be06ea@suse.com> (raw)
In-Reply-To: <20220214125632.24563-7-andrew.cooper3@citrix.com>
On 14.02.2022 13:56, Andrew Cooper wrote:
> Microcode loading is not a fastpath, but there are control flow integrity
> hardening benefits from using altcall, because it allows us to clobber the
> endbr64 instructions on all function pointer targets.
>
> Convert the existing microcode_ops pointer into an __ro_after_init structure,
> and move {amd,intel}_ucode_ops into __initconst_cf_clobber.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2022-02-14 13:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 12:56 [PATCH v2 0/7] x86: Further harden function pointers Andrew Cooper
2022-02-14 12:56 ` [PATCH v2 1/7] xen/altcall: Use __ro_after_init now that it exists Andrew Cooper
2022-02-14 12:59 ` Jan Beulich
2022-02-14 12:56 ` [PATCH v2 2/7] x86/altcall: Check and optimise altcall targets Andrew Cooper
2022-02-14 12:56 ` [PATCH v2 3/7] x86/altcall: Optimise away endbr64 instruction where possible Andrew Cooper
2022-02-14 13:06 ` Jan Beulich
2022-02-14 13:31 ` Andrew Cooper
2022-02-14 13:51 ` Jan Beulich
2022-02-14 16:03 ` Andrew Cooper
2022-02-14 16:16 ` Jan Beulich
2022-03-01 11:59 ` Jan Beulich
2022-03-01 14:51 ` Andrew Cooper
2022-03-01 14:58 ` Jan Beulich
2022-02-14 12:56 ` [PATCH v2 4/7] xsm: Use __initconst_cf_clobber for xsm_ops Andrew Cooper
2022-02-14 12:56 ` [PATCH v2 5/7] x86/hvm: Use __initdata_cf_clobber for hvm_funcs Andrew Cooper
2022-02-14 13:10 ` Jan Beulich
2022-02-14 13:35 ` Andrew Cooper
2022-02-14 16:39 ` Andrew Cooper
2022-02-14 16:45 ` Jan Beulich
2022-02-14 12:56 ` [PATCH v2 6/7] x86/ucode: Use altcall, and __initconst_cf_clobber Andrew Cooper
2022-02-14 13:13 ` Jan Beulich [this message]
2022-02-14 12:56 ` [PATCH v2 7/7] x86/vpmu: Harden indirect branches Andrew Cooper
2022-02-14 13:14 ` Jan Beulich
2022-02-21 18:03 ` [PATCH v2.1 8/7] x86/IOMMU: Use altcall, and __initconst_cf_clobber Andrew Cooper
2022-02-22 9:29 ` Jan Beulich
2022-02-22 10:54 ` Andrew Cooper
2022-02-22 11:02 ` Andrew Cooper
2022-02-22 11:06 ` Jan Beulich
2022-02-22 11:34 ` Andrew Cooper
2022-02-22 11:04 ` Jan Beulich
2022-02-22 11:47 ` [PATCH v2.2 " Andrew Cooper
2022-02-22 12:10 ` Jan Beulich
2022-02-25 8:24 ` Jan Beulich
2022-03-01 14:58 ` Andrew Cooper
2022-03-02 8:10 ` Jan Beulich
2022-03-02 10:12 ` Andrew Cooper
2022-03-02 10:34 ` Jan Beulich
2022-03-02 13:39 ` Andrew Cooper
2022-03-02 19:57 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06407c26-a189-c4f4-a30b-3bf802be06ea@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.