All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>,
	Chao Yu <yuchao0@huawei.com>,
	linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v5] f2fs: support data compression
Date: Mon, 16 Dec 2019 13:28:20 +0000	[thread overview]
Message-ID: <0677a4fd-62a5-ad98-fd02-ae7d5a9cb501@kernel.org> (raw)
In-Reply-To: <0ab8c593-d043-cdf6-7805-f7bceba8e519@web.de>

On 2019-12-16 19:51, Markus Elfring wrote:
> …
>> +++ b/fs/f2fs/f2fs.h
> …
>> +#ifdef CONFIG_F2FS_FS_COMPRESSION
>> +bool f2fs_is_compressed_page(struct page *page);
> …
>
> Can the following adjustment make sense?
>
> +bool f2fs_is_compressed_page(const struct page *page);
>
>
> Would you like to improve const-correctness at any more source code places?

I can't figure out a good reason to do that for f2fs internal functions...

Thanks,

>
> Regards,
> Markus
>

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>,
	Chao Yu <yuchao0@huawei.com>,
	linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [RFC PATCH v5] f2fs: support data compression
Date: Mon, 16 Dec 2019 21:28:20 +0800	[thread overview]
Message-ID: <0677a4fd-62a5-ad98-fd02-ae7d5a9cb501@kernel.org> (raw)
In-Reply-To: <0ab8c593-d043-cdf6-7805-f7bceba8e519@web.de>

On 2019-12-16 19:51, Markus Elfring wrote:
> …
>> +++ b/fs/f2fs/f2fs.h
> …
>> +#ifdef CONFIG_F2FS_FS_COMPRESSION
>> +bool f2fs_is_compressed_page(struct page *page);
> …
>
> Can the following adjustment make sense?
>
> +bool f2fs_is_compressed_page(const struct page *page);
>
>
> Would you like to improve const-correctness at any more source code places?

I can't figure out a good reason to do that for f2fs internal functions...

Thanks,

>
> Regards,
> Markus
>


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>,
	Chao Yu <yuchao0@huawei.com>,
	linux-f2fs-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [RFC PATCH v5] f2fs: support data compression
Date: Mon, 16 Dec 2019 21:28:20 +0800	[thread overview]
Message-ID: <0677a4fd-62a5-ad98-fd02-ae7d5a9cb501@kernel.org> (raw)
In-Reply-To: <0ab8c593-d043-cdf6-7805-f7bceba8e519@web.de>

On 2019-12-16 19:51, Markus Elfring wrote:
> …
>> +++ b/fs/f2fs/f2fs.h
> …
>> +#ifdef CONFIG_F2FS_FS_COMPRESSION
>> +bool f2fs_is_compressed_page(struct page *page);
> …
>
> Can the following adjustment make sense?
>
> +bool f2fs_is_compressed_page(const struct page *page);
>
>
> Would you like to improve const-correctness at any more source code places?

I can't figure out a good reason to do that for f2fs internal functions...

Thanks,

>
> Regards,
> Markus
>

  reply	other threads:[~2019-12-16 13:28 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16  6:28 [f2fs-dev] [RFC PATCH v5] f2fs: support data compression Chao Yu
2019-12-16  6:28 ` Chao Yu
2019-12-16 11:08 ` [f2fs-dev] " Markus Elfring
2019-12-16 11:08   ` Markus Elfring
2019-12-16 13:12   ` [f2fs-dev] " Chao Yu
2019-12-16 13:12     ` Chao Yu
2019-12-16 11:32 ` [f2fs-dev] " Markus Elfring
2019-12-16 11:32   ` Markus Elfring
2019-12-16 13:24   ` [f2fs-dev] " Chao Yu
2019-12-16 13:24     ` Chao Yu
2019-12-16 11:51 ` Markus Elfring
2019-12-16 11:51   ` Markus Elfring
2019-12-16 11:51   ` [f2fs-dev] " Markus Elfring
2019-12-16 13:28   ` Chao Yu [this message]
2019-12-16 13:28     ` Chao Yu
2019-12-16 13:28     ` [f2fs-dev] " Chao Yu
2019-12-16 13:38     ` [v5] " Markus Elfring
2019-12-16 13:38       ` Markus Elfring
2019-12-16 13:38       ` [f2fs-dev] " Markus Elfring
2019-12-18 21:46 ` [f2fs-dev] [RFC PATCH v5] " Jaegeuk Kim
2019-12-18 21:46   ` Jaegeuk Kim
2019-12-23  3:32   ` [f2fs-dev] " Chao Yu
2019-12-23  3:32     ` Chao Yu
2019-12-23  3:58     ` [f2fs-dev] " Chao Yu
2019-12-23  3:58       ` Chao Yu
2019-12-23 19:29     ` Jaegeuk Kim
2019-12-23 19:29       ` Jaegeuk Kim
2019-12-31  0:46     ` [f2fs-dev] " Jaegeuk Kim
2019-12-31  0:46       ` Jaegeuk Kim
2019-12-31  1:45       ` [f2fs-dev] " Chao Yu
2019-12-31  1:45         ` Chao Yu
2020-01-02 18:18         ` [f2fs-dev] " Jaegeuk Kim
2020-01-02 18:18           ` Jaegeuk Kim
2020-01-02 19:00           ` [f2fs-dev] " Jaegeuk Kim
2020-01-02 19:00             ` Jaegeuk Kim
2020-01-03  6:50             ` [f2fs-dev] " Chao Yu
2020-01-03  6:50               ` Chao Yu
2020-01-06  9:01               ` [f2fs-dev] " Chao Yu
2020-01-06  9:01                 ` Chao Yu
2020-01-06 18:16                 ` Jaegeuk Kim
2020-01-06 18:16                   ` Jaegeuk Kim
2020-01-10 23:52                   ` Jaegeuk Kim
2020-01-10 23:52                     ` Jaegeuk Kim
2020-01-11  9:08                     ` Chao Yu
2020-01-11  9:08                       ` Chao Yu
2020-01-11 18:02                       ` Jaegeuk Kim
2020-01-11 18:02                         ` Jaegeuk Kim
2020-01-13  8:56                         ` Chao Yu
2020-01-13  8:56                           ` Chao Yu
2020-01-13 16:11                           ` Jaegeuk Kim
2020-01-13 16:11                             ` Jaegeuk Kim
2020-01-14  1:52                             ` Chao Yu
2020-01-14  1:52                               ` Chao Yu
2020-01-14 22:48                               ` Jaegeuk Kim
2020-01-14 22:48                                 ` Jaegeuk Kim
2020-01-15 10:12                                 ` Chao Yu
2020-01-15 10:12                                   ` Chao Yu
2020-01-15 21:38                                   ` Jaegeuk Kim
2020-01-15 21:38                                     ` Jaegeuk Kim
2020-01-03  1:19           ` Chao Yu
2020-01-03  1:19             ` Chao Yu
2019-12-19  9:53 ` [f2fs-dev] " Geert Uytterhoeven
2019-12-19  9:53   ` Geert Uytterhoeven
2019-12-23  3:36   ` [f2fs-dev] " Chao Yu
2019-12-23  3:36     ` Chao Yu
2019-12-19 10:18 ` [f2fs-dev] " Geert Uytterhoeven
2019-12-19 10:18   ` Geert Uytterhoeven
2019-12-19 10:25 ` [f2fs-dev] " Geert Uytterhoeven
2019-12-19 10:25   ` Geert Uytterhoeven
2019-12-20 21:26   ` [f2fs-dev] " Jaegeuk Kim
2019-12-20 21:26     ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0677a4fd-62a5-ad98-fd02-ae7d5a9cb501@kernel.org \
    --to=chao@kernel.org \
    --cc=Markus.Elfring@web.de \
    --cc=jaegeuk@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.