From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Mahesh Kumar <mahesh1.kumar@intel.com>, intel-gfx@lists.freedesktop.org
Cc: paulo.r.zanoni@intel.com, maarten.lankhorst@intel.com
Subject: Re: [PATCH 06/11] drm/i915/skl+: unify cpp value in WM calculation
Date: Thu, 13 Jul 2017 17:31:57 +0200 [thread overview]
Message-ID: <06a13872-e801-eb82-71f8-ff9780f6fa2c@linux.intel.com> (raw)
In-Reply-To: <20170705143154.32132-7-mahesh1.kumar@intel.com>
Op 05-07-17 om 16:31 schreef Mahesh Kumar:
> From: "Kumar, Mahesh" <mahesh1.kumar@intel.com>
>
> use same cpp value in different phase of plane WM caluclation.
>
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 9e2ca70bed5d..9753210d79ae 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4399,13 +4399,11 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,
> width = drm_rect_width(&intel_pstate->base.src) >> 16;
> }
>
> - cpp = fb->format->cpp[0];
> + cpp = (fb->format->format == DRM_FORMAT_NV12) ? fb->format->cpp[1] :
> + fb->format->cpp[0];
> plane_pixel_rate = skl_adjusted_plane_pixel_rate(cstate, intel_pstate);
>
> if (drm_rotation_90_or_270(pstate->rotation)) {
> - int cpp = (fb->format->format == DRM_FORMAT_NV12) ?
> - fb->format->cpp[1] :
> - fb->format->cpp[0];
>
> switch (cpp) {
> case 1:
First 6 patches pushed, thanks.
I'll take a closer look at the other patches on monday. :)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-07-13 15:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 14:31 [PATCH 00/11] Fixed16.16 wrapper cleanup & wm optimization Mahesh Kumar
2017-07-05 14:31 ` [PATCH 01/11] drm/i915: take-out common clamping code of fixed16 wrappers Mahesh Kumar
2017-07-14 10:24 ` Jani Nikula
2017-07-05 14:31 ` [PATCH 02/11] drm/i915: Always perform internal fixed16 division in 64 bits Mahesh Kumar
2017-07-05 14:31 ` [PATCH 03/11] drm/i915: cleanup fixed-point wrappers naming Mahesh Kumar
2017-07-05 14:31 ` [PATCH 04/11] drm/i915: Addition wrapper for fixed16.16 operation Mahesh Kumar
2017-07-05 14:31 ` [PATCH 05/11] drm/i915/skl+: WM calculation don't require height Mahesh Kumar
2017-07-05 14:31 ` [PATCH 06/11] drm/i915/skl+: unify cpp value in WM calculation Mahesh Kumar
2017-07-13 15:31 ` Maarten Lankhorst [this message]
2017-07-14 10:26 ` Jani Nikula
2017-07-14 10:31 ` Mahesh Kumar
2017-07-05 14:31 ` [PATCH 07/11] drm/i915/skl+: Optimize " Mahesh Kumar
2017-07-05 14:31 ` [PATCH 08/11] drm/i915/gen10: Calculate and enable transition WM Mahesh Kumar
2017-07-05 14:31 ` [PATCH 09/11] drm/i915/glk: IPC linetime watermark workaround for GLK Mahesh Kumar
2017-07-05 14:31 ` [PATCH 10/11] drm/i915/cnl: Extend WM workaround with IPC for CNL Mahesh Kumar
2017-07-05 14:31 ` [PATCH 11/11] drm/i915/bxt: Enable IPC support Mahesh Kumar
2017-07-06 15:10 ` Lankhorst, Maarten
2017-07-13 10:39 ` [PATCH 11/13] " Mahesh Kumar
2017-07-13 10:48 ` Chris Wilson
2017-07-13 12:02 ` Mahesh Kumar
2017-07-05 15:00 ` ✓ Fi.CI.BAT: success for Fixed16.16 wrapper cleanup & wm optimization (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a13872-e801-eb82-71f8-ff9780f6fa2c@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@intel.com \
--cc=mahesh1.kumar@intel.com \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.