* [PATCH] regulator: Fix s5m8767_set_voltage_time_sel calculation value
@ 2012-03-09 7:28 Sangbeom Kim
2012-03-09 12:33 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Sangbeom Kim @ 2012-03-09 7:28 UTC (permalink / raw)
To: linux-kernel, lrg, 'Mark Brown'; +Cc: sbkim01
In the s5m8767_set_voltage_time_sel function, divisor unit is wrong.
ramp_delay is usec unit. So 1000 should be multiplied.
Signed-off-by: Sangbeom Kim <sbkim73@samsung.com>
---
drivers/regulator/s5m8767.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index e369d9e..3592ccb 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -457,7 +457,7 @@ static int s5m8767_set_voltage_time_sel(struct regulator_dev *rdev,
if (old_sel < new_sel)
return DIV_ROUND_UP(desc->step * (new_sel - old_sel),
- s5m8767->ramp_delay);
+ s5m8767->ramp_delay * 1000);
return 0;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: Fix s5m8767_set_voltage_time_sel calculation value
2012-03-09 7:28 [PATCH] regulator: Fix s5m8767_set_voltage_time_sel calculation value Sangbeom Kim
@ 2012-03-09 12:33 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-03-09 12:33 UTC (permalink / raw)
To: Sangbeom Kim; +Cc: linux-kernel, lrg, sbkim01
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
On Fri, Mar 09, 2012 at 04:28:10PM +0900, Sangbeom Kim wrote:
> In the s5m8767_set_voltage_time_sel function, divisor unit is wrong.
> ramp_delay is usec unit. So 1000 should be multiplied.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-09 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-09 7:28 [PATCH] regulator: Fix s5m8767_set_voltage_time_sel calculation value Sangbeom Kim
2012-03-09 12:33 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.