Re: [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition.

[JAEHOON KIM <jhkim@linux.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]


On 6/10/2025 11:02 AM, Peter Xu wrote:
> On Tue, Jun 10, 2025 at 10:08:49AM -0500, Jaehoon Kim wrote:
>> When the source VM attempts to connect to the destination VM's Unix
>> domain socket (cpr.sock) during a cpr-transfer test, race conditions can
>> occur if the socket file isn't ready. This can lead to connection
>> failures when running tests.
>>
>> This patch creates and listens on the socket in advance, and passes the
>> pre-listened FD directly. This avoids timing issues and improves the
>> reliability of CPR tests.
>>
>> Reviewed-by: Jason J. Herne<jjherne@linux.ibm.com>
>> Signed-off-by: Jaehoon Kim<jhkim@linux.ibm.com>
> One quick comment while we can wait for others to look at the details: when
> it involves both qemu and tests changes, please consider splitting that
> into two patches. The test patch can be prefixed with "tests/migration:".
>
> Thanks,

Thank you for your suggestion. I'll split the patch into two separate 
patches and submit an updated v3 version

- Jaehoon Kim

[-- Attachment #2: Type: text/html, Size: 1727 bytes --]