All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Jaehoon Kim <jhkim@linux.ibm.com>
Cc: qemu-devel@nongnu.org, jjherne@linux.ibm.com,
	steven.sistare@oracle.com, farosas@suse.de, lvivier@redhat.com,
	pbonzini@redhat.com
Subject: Re: [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition.
Date: Tue, 10 Jun 2025 12:02:56 -0400	[thread overview]
Message-ID: <aEhXMCuztHlUEhqb@x1.local> (raw)
In-Reply-To: <20250610150849.326194-1-jhkim@linux.ibm.com>

On Tue, Jun 10, 2025 at 10:08:49AM -0500, Jaehoon Kim wrote:
> When the source VM attempts to connect to the destination VM's Unix
> domain socket (cpr.sock) during a cpr-transfer test, race conditions can
> occur if the socket file isn't ready. This can lead to connection
> failures when running tests.
> 
> This patch creates and listens on the socket in advance, and passes the
> pre-listened FD directly. This avoids timing issues and improves the
> reliability of CPR tests.
> 
> Reviewed-by: Jason J. Herne <jjherne@linux.ibm.com>
> Signed-off-by: Jaehoon Kim <jhkim@linux.ibm.com>

One quick comment while we can wait for others to look at the details: when
it involves both qemu and tests changes, please consider splitting that
into two patches. The test patch can be prefixed with "tests/migration:".

Thanks,

-- 
Peter Xu



  reply	other threads:[~2025-06-10 16:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 15:08 [PATCH v2] migration: Setup pre-listened cpr.sock to remove race-condition Jaehoon Kim
2025-06-10 16:02 ` Peter Xu [this message]
2025-06-10 17:25   ` JAEHOON KIM
2025-06-10 16:57 ` Steven Sistare
2025-06-10 17:13   ` JAEHOON KIM
2025-06-10 17:05 ` Daniel P. Berrangé
2025-06-10 17:19   ` JAEHOON KIM
2025-06-10 17:09 ` Daniel P. Berrangé
2025-06-10 17:23   ` JAEHOON KIM

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aEhXMCuztHlUEhqb@x1.local \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=jhkim@linux.ibm.com \
    --cc=jjherne@linux.ibm.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=steven.sistare@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.