From: Kukjin Kim <kgene@kernel.org>
To: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>, kgene@kernel.org
Cc: olof@lixom.net, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de
Subject: RE: [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi
Date: Tue, 03 Feb 2015 13:12:13 +0900 [thread overview]
Message-ID: <06d501d03f67$96bc2b40$c43481c0$@kernel.org> (raw)
In-Reply-To: <1421329871-18819-1-git-send-email-s.nawrocki@samsung.com>
Sylwester Nawrocki wrote:
>
> Assign proper FIMC-IS UART gate clock in the device DT node and not
> use the SRC_MASK gate. This fixes regression introduced in commit
> a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove
> SRC_MASK_ISP gates").
>
> Without this change exynos4 fimc-is driver fails to probe with an
> error log:
>
> [ 1.842447] ERROR: could not get clock /camera/fimc-is@12000000:uart(13)
> [ 1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
> [ 1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>
> Kukjin, could you take this patch into your tree ? I have been applying it
> for several kernel releases now to get the Exynos4 FIMC driver even passing
> probing.
>
> Thanks,
> Sylwester
> arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index 93b7040..86e1800 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -225,7 +225,7 @@
> <&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
> <&clock CLK_DIV_MCUISP0>,
> <&clock CLK_DIV_MCUISP1>,
> - <&clock CLK_SCLK_UART_ISP>,
> + <&clock CLK_UART_ISP_SCLK>,
> <&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
> <&clock CLK_ACLK400_MCUISP>,
> <&clock CLK_DIV_ACLK400_MCUISP>;
> --
Applied, thanks.
- Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi
Date: Tue, 03 Feb 2015 13:12:13 +0900 [thread overview]
Message-ID: <06d501d03f67$96bc2b40$c43481c0$@kernel.org> (raw)
In-Reply-To: <1421329871-18819-1-git-send-email-s.nawrocki@samsung.com>
Sylwester Nawrocki wrote:
>
> Assign proper FIMC-IS UART gate clock in the device DT node and not
> use the SRC_MASK gate. This fixes regression introduced in commit
> a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove
> SRC_MASK_ISP gates").
>
> Without this change exynos4 fimc-is driver fails to probe with an
> error log:
>
> [ 1.842447] ERROR: could not get clock /camera/fimc-is at 12000000:uart(13)
> [ 1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
> [ 1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>
> Kukjin, could you take this patch into your tree ? I have been applying it
> for several kernel releases now to get the Exynos4 FIMC driver even passing
> probing.
>
> Thanks,
> Sylwester
> arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index 93b7040..86e1800 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -225,7 +225,7 @@
> <&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
> <&clock CLK_DIV_MCUISP0>,
> <&clock CLK_DIV_MCUISP1>,
> - <&clock CLK_SCLK_UART_ISP>,
> + <&clock CLK_UART_ISP_SCLK>,
> <&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
> <&clock CLK_ACLK400_MCUISP>,
> <&clock CLK_DIV_ACLK400_MCUISP>;
> --
Applied, thanks.
- Kukjin
next prev parent reply other threads:[~2015-02-03 4:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 13:51 [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi Sylwester Nawrocki
2015-01-15 13:51 ` Sylwester Nawrocki
2015-02-03 4:12 ` Kukjin Kim [this message]
2015-02-03 4:12 ` Kukjin Kim
-- strict thread matches above, loose matches on Subject: below --
2014-10-31 13:34 Sylwester Nawrocki
2014-10-31 13:34 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='06d501d03f67$96bc2b40$c43481c0$@kernel.org' \
--to=kgene@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.