All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene@kernel.org>
To: 'Sylwester Nawrocki' <s.nawrocki@samsung.com>, kgene@kernel.org
Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH] ARM: dts: Fix CLK_MOUT_CAMn parent clocks assignment for Trats2
Date: Tue, 03 Feb 2015 13:14:24 +0900	[thread overview]
Message-ID: <06fa01d03f67$e5044cb0$af0ce610$@kernel.org> (raw)
In-Reply-To: <1421430016-32248-1-git-send-email-s.nawrocki@samsung.com>

Sylwester Nawrocki wrote:
> 
> In order to get exact 24MHz clock frequency value for the camera
> sensor and avoid rounding errors the parent clock must be CLK_XUSBXTI,
> not CLK_MOUT_MPLL_USER_T.  Currently the sensor's master clock
> frequency is too high and the sensor doesn't work properly.
> 
> This fixes commit 0357a4438d531ef3cf529e80ffcd208eb8e35f55
> ("ARM: dts: Specify default clocks for Exynos4 camera devices").
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-trats2.dts |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 29231b4..9ae62c2 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -721,8 +721,8 @@
>  		status = "okay";
>  		assigned-clocks = <&clock CLK_MOUT_CAM0>,
>  				  <&clock CLK_MOUT_CAM1>;
> -		assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>,
> -					 <&clock CLK_MOUT_MPLL_USER_T>;
> +		assigned-clock-parents = <&clock CLK_XUSBXTI>,
> +					 <&clock CLK_XUSBXTI>;
> 
>  		fimc_0: fimc@11800000 {
>  			status = "okay";
> --

Applied, thanks.

- Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Fix CLK_MOUT_CAMn parent clocks assignment for Trats2
Date: Tue, 03 Feb 2015 13:14:24 +0900	[thread overview]
Message-ID: <06fa01d03f67$e5044cb0$af0ce610$@kernel.org> (raw)
In-Reply-To: <1421430016-32248-1-git-send-email-s.nawrocki@samsung.com>

Sylwester Nawrocki wrote:
> 
> In order to get exact 24MHz clock frequency value for the camera
> sensor and avoid rounding errors the parent clock must be CLK_XUSBXTI,
> not CLK_MOUT_MPLL_USER_T.  Currently the sensor's master clock
> frequency is too high and the sensor doesn't work properly.
> 
> This fixes commit 0357a4438d531ef3cf529e80ffcd208eb8e35f55
> ("ARM: dts: Specify default clocks for Exynos4 camera devices").
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-trats2.dts |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 29231b4..9ae62c2 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -721,8 +721,8 @@
>  		status = "okay";
>  		assigned-clocks = <&clock CLK_MOUT_CAM0>,
>  				  <&clock CLK_MOUT_CAM1>;
> -		assigned-clock-parents = <&clock CLK_MOUT_MPLL_USER_T>,
> -					 <&clock CLK_MOUT_MPLL_USER_T>;
> +		assigned-clock-parents = <&clock CLK_XUSBXTI>,
> +					 <&clock CLK_XUSBXTI>;
> 
>  		fimc_0: fimc at 11800000 {
>  			status = "okay";
> --

Applied, thanks.

- Kukjin

  reply	other threads:[~2015-02-03  4:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 17:40 [PATCH] ARM: dts: Fix CLK_MOUT_CAMn parent clocks assignment for Trats2 Sylwester Nawrocki
2015-01-16 17:40 ` Sylwester Nawrocki
2015-02-03  4:14 ` Kukjin Kim [this message]
2015-02-03  4:14   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='06fa01d03f67$e5044cb0$af0ce610$@kernel.org' \
    --to=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.