[PATCH 1/4 V2] Staging: media: atomisp: i2c: removed redundand debug message

[PATCH 1/4 V2] Staging: media: atomisp: i2c: removed redundand debug message

[Thomas Andreatta]

Checkpatch fix: deleted `dev_dbg()` printing the name of the function.
                ftrace can be used instead.

Signed-off-by: Thomas Andreatta <thomas.andreatta2000@gmail.com>
---
 drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
index d35394f1ddbb..830a38086cb8 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
@@ -584,8 +584,6 @@ static void gc0310_remove(struct i2c_client *client)
 	struct v4l2_subdev *sd = i2c_get_clientdata(client);
 	struct gc0310_device *dev = to_gc0310_sensor(sd);
 
-	dev_dbg(&client->dev, "gc0310_remove...\n");
-
 	v4l2_async_unregister_subdev(sd);
 	media_entity_cleanup(&dev->sd.entity);
 	v4l2_ctrl_handler_free(&dev->ctrls.handler);
-- 
2.34.1

[PATCH 2/4 V2] Staging: media: atomisp: i2c: removed redundand debug message

[Thomas Andreatta]

Checkpatch fix: deleted `dev_dbg()` printing the name of the function.
                ftrace can be used instead.

Signed-off-by: Thomas Andreatta <thomas.andreatta2000@gmail.com>
---
 drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index 857d7175942c..6fc39ab95e46 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -779,8 +779,6 @@ static void gc2235_remove(struct i2c_client *client)
 	struct v4l2_subdev *sd = i2c_get_clientdata(client);
 	struct gc2235_device *dev = to_gc2235_sensor(sd);
 
-	dev_dbg(&client->dev, "gc2235_remove...\n");
-
 	dev->platform_data->csi_cfg(sd, 0);
 
 	v4l2_device_unregister_subdev(sd);
-- 
2.34.1

[PATCH 3/4 V2] Staging: media: atomisp: i2c: struct definition style

[Thomas Andreatta]

Reorder const qualifier in array declaration

Signed-off-by: Thomas Andreatta <thomas.andreatta2000@gmail.com>
---
 drivers/staging/media/atomisp/i2c/gc2235.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/gc2235.h b/drivers/staging/media/atomisp/i2c/gc2235.h
index 6c743a17f198..7dd9a676fb98 100644
--- a/drivers/staging/media/atomisp/i2c/gc2235.h
+++ b/drivers/staging/media/atomisp/i2c/gc2235.h
@@ -179,21 +179,21 @@ struct gc2235_write_ctrl {
 	struct gc2235_write_buffer buffer;
 };
 
-static struct gc2235_reg const gc2235_stream_on[] = {
+static const struct gc2235_reg gc2235_stream_on[] = {
 	{ GC2235_8BIT, 0xfe, 0x03}, /* switch to P3 */
 	{ GC2235_8BIT, 0x10, 0x91}, /* start mipi */
 	{ GC2235_8BIT, 0xfe, 0x00}, /* switch to P0 */
 	{ GC2235_TOK_TERM, 0, 0 }
 };
 
-static struct gc2235_reg const gc2235_stream_off[] = {
+static const struct gc2235_reg gc2235_stream_off[] = {
 	{ GC2235_8BIT, 0xfe, 0x03}, /* switch to P3 */
 	{ GC2235_8BIT, 0x10, 0x01}, /* stop mipi */
 	{ GC2235_8BIT, 0xfe, 0x00}, /* switch to P0 */
 	{ GC2235_TOK_TERM, 0, 0 }
 };
 
-static struct gc2235_reg const gc2235_init_settings[] = {
+static const struct gc2235_reg gc2235_init_settings[] = {
 	/* System */
 	{ GC2235_8BIT, 0xfe, 0x80 },
 	{ GC2235_8BIT, 0xfe, 0x80 },
@@ -268,7 +268,7 @@ static struct gc2235_reg const gc2235_init_settings[] = {
  * Register settings for various resolution
  */
 #if ENABLE_NON_PREVIEW
-static struct gc2235_reg const gc2235_1296_736_30fps[] = {
+static const struct gc2235_reg gc2235_1296_736_30fps[] = {
 	{ GC2235_8BIT, 0x8b, 0xa0 },
 	{ GC2235_8BIT, 0x8c, 0x02 },
 
@@ -321,7 +321,7 @@ static struct gc2235_reg const gc2235_1296_736_30fps[] = {
 	{ GC2235_TOK_TERM, 0, 0 }
 };
 
-static struct gc2235_reg const gc2235_960_640_30fps[] = {
+static const struct gc2235_reg gc2235_960_640_30fps[] = {
 	{ GC2235_8BIT, 0x8b, 0xa0 },
 	{ GC2235_8BIT, 0x8c, 0x02 },
 
@@ -373,7 +373,7 @@ static struct gc2235_reg const gc2235_960_640_30fps[] = {
 };
 #endif
 
-static struct gc2235_reg const gc2235_1600_900_30fps[] = {
+static const struct gc2235_reg gc2235_1600_900_30fps[] = {
 	{ GC2235_8BIT, 0x8b, 0xa0 },
 	{ GC2235_8BIT, 0x8c, 0x02 },
 
@@ -418,7 +418,7 @@ static struct gc2235_reg const gc2235_1600_900_30fps[] = {
 	{ GC2235_TOK_TERM, 0, 0 }
 };
 
-static struct gc2235_reg const gc2235_1616_1082_30fps[] = {
+static const struct gc2235_reg gc2235_1616_1082_30fps[] = {
 	{ GC2235_8BIT, 0x8b, 0xa0 },
 	{ GC2235_8BIT, 0x8c, 0x02 },
 
@@ -463,7 +463,7 @@ static struct gc2235_reg const gc2235_1616_1082_30fps[] = {
 	{ GC2235_TOK_TERM, 0, 0 }
 };
 
-static struct gc2235_reg const gc2235_1616_1216_30fps[] = {
+static const struct gc2235_reg gc2235_1616_1216_30fps[] = {
 	{ GC2235_8BIT, 0x8b, 0xa0 },
 	{ GC2235_8BIT, 0x8c, 0x02 },
 
-- 
2.34.1

[PATCH 4/4 V2] Staging: media: atomisp: i2c: struct definition style

[Thomas Andreatta]

Reorder const qualifier in array declaration

Signed-off-by: Thomas Andreatta <thomas.andreatta2000@gmail.com>
---
 drivers/staging/media/atomisp/i2c/ov2722.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/ov2722.h b/drivers/staging/media/atomisp/i2c/ov2722.h
index bc36133f3722..00317d105305 100644
--- a/drivers/staging/media/atomisp/i2c/ov2722.h
+++ b/drivers/staging/media/atomisp/i2c/ov2722.h
@@ -236,7 +236,7 @@ struct ov2722_write_ctrl {
  * Register settings for various resolution
  */
 #if 0
-static struct ov2722_reg const ov2722_QVGA_30fps[] = {
+static const struct ov2722_reg ov2722_QVGA_30fps[] = {
 	{OV2722_8BIT, 0x3718, 0x10},
 	{OV2722_8BIT, 0x3702, 0x0c},
 	{OV2722_8BIT, 0x373a, 0x1c},
@@ -346,7 +346,7 @@ static struct ov2722_reg const ov2722_QVGA_30fps[] = {
 
 };
 
-static struct ov2722_reg const ov2722_480P_30fps[] = {
+static const struct ov2722_reg ov2722_480P_30fps[] = {
 	{OV2722_8BIT, 0x3718, 0x10},
 	{OV2722_8BIT, 0x3702, 0x18},
 	{OV2722_8BIT, 0x373a, 0x3c},
@@ -455,7 +455,7 @@ static struct ov2722_reg const ov2722_480P_30fps[] = {
 	{OV2722_TOK_TERM, 0, 0},
 };
 
-static struct ov2722_reg const ov2722_VGA_30fps[] = {
+static const struct ov2722_reg ov2722_VGA_30fps[] = {
 	{OV2722_8BIT, 0x3718, 0x10},
 	{OV2722_8BIT, 0x3702, 0x18},
 	{OV2722_8BIT, 0x373a, 0x3c},
@@ -565,7 +565,7 @@ static struct ov2722_reg const ov2722_VGA_30fps[] = {
 };
 #endif
 
-static struct ov2722_reg const ov2722_1632_1092_30fps[] = {
+static const struct ov2722_reg ov2722_1632_1092_30fps[] = {
 	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
 				a whole frame complete.(vblank) */
 	{OV2722_8BIT, 0x3718, 0x10},
@@ -667,7 +667,7 @@ static struct ov2722_reg const ov2722_1632_1092_30fps[] = {
 	{OV2722_TOK_TERM, 0, 0}
 };
 
-static struct ov2722_reg const ov2722_1452_1092_30fps[] = {
+static const struct ov2722_reg ov2722_1452_1092_30fps[] = {
 	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
 				a whole frame complete.(vblank) */
 	{OV2722_8BIT, 0x3718, 0x10},
@@ -769,7 +769,7 @@ static struct ov2722_reg const ov2722_1452_1092_30fps[] = {
 };
 
 #if 0
-static struct ov2722_reg const ov2722_1M3_30fps[] = {
+static const struct ov2722_reg ov2722_1M3_30fps[] = {
 	{OV2722_8BIT, 0x3718, 0x10},
 	{OV2722_8BIT, 0x3702, 0x24},
 	{OV2722_8BIT, 0x373a, 0x60},
@@ -877,7 +877,7 @@ static struct ov2722_reg const ov2722_1M3_30fps[] = {
 };
 #endif
 
-static struct ov2722_reg const ov2722_1080p_30fps[] = {
+static const struct ov2722_reg ov2722_1080p_30fps[] = {
 	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for a whole
 					frame complete.(vblank) */
 	{OV2722_8BIT, 0x3718, 0x10},
@@ -983,7 +983,7 @@ static struct ov2722_reg const ov2722_1080p_30fps[] = {
 };
 
 #if 0 /* Currently unused */
-static struct ov2722_reg const ov2722_720p_30fps[] = {
+static const struct ov2722_reg ov2722_720p_30fps[] = {
 	{OV2722_8BIT, 0x3021, 0x03},
 	{OV2722_8BIT, 0x3718, 0x10},
 	{OV2722_8BIT, 0x3702, 0x24},
-- 
2.34.1

Re: [PATCH 1/4 V2] Staging: media: atomisp: i2c: removed redundand debug message

[Hans de Goede]

Hi Thomas,

On 19-Jun-25 10:44 AM, Thomas Andreatta wrote:
> Checkpatch fix: deleted `dev_dbg()` printing the name of the function.
>                 ftrace can be used instead.
> 
> Signed-off-by: Thomas Andreatta <thomas.andreatta2000@gmail.com>

Thank you for your patch.

This patch is obsoleted by my recent gc0310 driver cleanups,
so I'm dropping this patch from the queue.

Regards,

Hans


> ---
>  drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
> index d35394f1ddbb..830a38086cb8 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
> @@ -584,8 +584,6 @@ static void gc0310_remove(struct i2c_client *client)
>  	struct v4l2_subdev *sd = i2c_get_clientdata(client);
>  	struct gc0310_device *dev = to_gc0310_sensor(sd);
>  
> -	dev_dbg(&client->dev, "gc0310_remove...\n");
> -
>  	v4l2_async_unregister_subdev(sd);
>  	media_entity_cleanup(&dev->sd.entity);
>  	v4l2_ctrl_handler_free(&dev->ctrls.handler);

Re: [PATCH 2/4 V2] Staging: media: atomisp: i2c: removed redundand debug message

[Hans de Goede]

Hi,

On 19-Jun-25 10:44 AM, Thomas Andreatta wrote:
> Checkpatch fix: deleted `dev_dbg()` printing the name of the function.
>                 ftrace can be used instead.
> 
> Signed-off-by: Thomas Andreatta <thomas.andreatta2000@gmail.com>

Thank you for your patch.

I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans




> ---
>  drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> index 857d7175942c..6fc39ab95e46 100644
> --- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> +++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
> @@ -779,8 +779,6 @@ static void gc2235_remove(struct i2c_client *client)
>  	struct v4l2_subdev *sd = i2c_get_clientdata(client);
>  	struct gc2235_device *dev = to_gc2235_sensor(sd);
>  
> -	dev_dbg(&client->dev, "gc2235_remove...\n");
> -
>  	dev->platform_data->csi_cfg(sd, 0);
>  
>  	v4l2_device_unregister_subdev(sd);

Re: [PATCH 3/4 V2] Staging: media: atomisp: i2c: struct definition style

[Hans de Goede]

Hi,

On 19-Jun-25 10:44 AM, Thomas Andreatta wrote:
> Reorder const qualifier in array declaration
> 
> Signed-off-by: Thomas Andreatta <thomas.andreatta2000@gmail.com>

Thank you for your patch.

I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans



> ---
>  drivers/staging/media/atomisp/i2c/gc2235.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/gc2235.h b/drivers/staging/media/atomisp/i2c/gc2235.h
> index 6c743a17f198..7dd9a676fb98 100644
> --- a/drivers/staging/media/atomisp/i2c/gc2235.h
> +++ b/drivers/staging/media/atomisp/i2c/gc2235.h
> @@ -179,21 +179,21 @@ struct gc2235_write_ctrl {
>  	struct gc2235_write_buffer buffer;
>  };
>  
> -static struct gc2235_reg const gc2235_stream_on[] = {
> +static const struct gc2235_reg gc2235_stream_on[] = {
>  	{ GC2235_8BIT, 0xfe, 0x03}, /* switch to P3 */
>  	{ GC2235_8BIT, 0x10, 0x91}, /* start mipi */
>  	{ GC2235_8BIT, 0xfe, 0x00}, /* switch to P0 */
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_stream_off[] = {
> +static const struct gc2235_reg gc2235_stream_off[] = {
>  	{ GC2235_8BIT, 0xfe, 0x03}, /* switch to P3 */
>  	{ GC2235_8BIT, 0x10, 0x01}, /* stop mipi */
>  	{ GC2235_8BIT, 0xfe, 0x00}, /* switch to P0 */
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_init_settings[] = {
> +static const struct gc2235_reg gc2235_init_settings[] = {
>  	/* System */
>  	{ GC2235_8BIT, 0xfe, 0x80 },
>  	{ GC2235_8BIT, 0xfe, 0x80 },
> @@ -268,7 +268,7 @@ static struct gc2235_reg const gc2235_init_settings[] = {
>   * Register settings for various resolution
>   */
>  #if ENABLE_NON_PREVIEW
> -static struct gc2235_reg const gc2235_1296_736_30fps[] = {
> +static const struct gc2235_reg gc2235_1296_736_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>  
> @@ -321,7 +321,7 @@ static struct gc2235_reg const gc2235_1296_736_30fps[] = {
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_960_640_30fps[] = {
> +static const struct gc2235_reg gc2235_960_640_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>  
> @@ -373,7 +373,7 @@ static struct gc2235_reg const gc2235_960_640_30fps[] = {
>  };
>  #endif
>  
> -static struct gc2235_reg const gc2235_1600_900_30fps[] = {
> +static const struct gc2235_reg gc2235_1600_900_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>  
> @@ -418,7 +418,7 @@ static struct gc2235_reg const gc2235_1600_900_30fps[] = {
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_1616_1082_30fps[] = {
> +static const struct gc2235_reg gc2235_1616_1082_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>  
> @@ -463,7 +463,7 @@ static struct gc2235_reg const gc2235_1616_1082_30fps[] = {
>  	{ GC2235_TOK_TERM, 0, 0 }
>  };
>  
> -static struct gc2235_reg const gc2235_1616_1216_30fps[] = {
> +static const struct gc2235_reg gc2235_1616_1216_30fps[] = {
>  	{ GC2235_8BIT, 0x8b, 0xa0 },
>  	{ GC2235_8BIT, 0x8c, 0x02 },
>  

Re: [PATCH 4/4 V2] Staging: media: atomisp: i2c: struct definition style

[Hans de Goede]

Hi,

On 19-Jun-25 10:44 AM, Thomas Andreatta wrote:
> Reorder const qualifier in array declaration
> 
> Signed-off-by: Thomas Andreatta <thomas.andreatta2000@gmail.com>

Thank you for your patch.

I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp

And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)

Regards,

Hans



> ---
>  drivers/staging/media/atomisp/i2c/ov2722.h | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/ov2722.h b/drivers/staging/media/atomisp/i2c/ov2722.h
> index bc36133f3722..00317d105305 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2722.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2722.h
> @@ -236,7 +236,7 @@ struct ov2722_write_ctrl {
>   * Register settings for various resolution
>   */
>  #if 0
> -static struct ov2722_reg const ov2722_QVGA_30fps[] = {
> +static const struct ov2722_reg ov2722_QVGA_30fps[] = {
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x0c},
>  	{OV2722_8BIT, 0x373a, 0x1c},
> @@ -346,7 +346,7 @@ static struct ov2722_reg const ov2722_QVGA_30fps[] = {
>  
>  };
>  
> -static struct ov2722_reg const ov2722_480P_30fps[] = {
> +static const struct ov2722_reg ov2722_480P_30fps[] = {
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x18},
>  	{OV2722_8BIT, 0x373a, 0x3c},
> @@ -455,7 +455,7 @@ static struct ov2722_reg const ov2722_480P_30fps[] = {
>  	{OV2722_TOK_TERM, 0, 0},
>  };
>  
> -static struct ov2722_reg const ov2722_VGA_30fps[] = {
> +static const struct ov2722_reg ov2722_VGA_30fps[] = {
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x18},
>  	{OV2722_8BIT, 0x373a, 0x3c},
> @@ -565,7 +565,7 @@ static struct ov2722_reg const ov2722_VGA_30fps[] = {
>  };
>  #endif
>  
> -static struct ov2722_reg const ov2722_1632_1092_30fps[] = {
> +static const struct ov2722_reg ov2722_1632_1092_30fps[] = {
>  	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
>  				a whole frame complete.(vblank) */
>  	{OV2722_8BIT, 0x3718, 0x10},
> @@ -667,7 +667,7 @@ static struct ov2722_reg const ov2722_1632_1092_30fps[] = {
>  	{OV2722_TOK_TERM, 0, 0}
>  };
>  
> -static struct ov2722_reg const ov2722_1452_1092_30fps[] = {
> +static const struct ov2722_reg ov2722_1452_1092_30fps[] = {
>  	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
>  				a whole frame complete.(vblank) */
>  	{OV2722_8BIT, 0x3718, 0x10},
> @@ -769,7 +769,7 @@ static struct ov2722_reg const ov2722_1452_1092_30fps[] = {
>  };
>  
>  #if 0
> -static struct ov2722_reg const ov2722_1M3_30fps[] = {
> +static const struct ov2722_reg ov2722_1M3_30fps[] = {
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x24},
>  	{OV2722_8BIT, 0x373a, 0x60},
> @@ -877,7 +877,7 @@ static struct ov2722_reg const ov2722_1M3_30fps[] = {
>  };
>  #endif
>  
> -static struct ov2722_reg const ov2722_1080p_30fps[] = {
> +static const struct ov2722_reg ov2722_1080p_30fps[] = {
>  	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for a whole
>  					frame complete.(vblank) */
>  	{OV2722_8BIT, 0x3718, 0x10},
> @@ -983,7 +983,7 @@ static struct ov2722_reg const ov2722_1080p_30fps[] = {
>  };
>  
>  #if 0 /* Currently unused */
> -static struct ov2722_reg const ov2722_720p_30fps[] = {
> +static const struct ov2722_reg ov2722_720p_30fps[] = {
>  	{OV2722_8BIT, 0x3021, 0x03},
>  	{OV2722_8BIT, 0x3718, 0x10},
>  	{OV2722_8BIT, 0x3702, 0x24},