All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene@kernel.org>
To: "'Javier Martinez Canillas'" <javier@dowhile0.org>,
	"'Andreas Färber'" <afaerber@suse.de>
Cc: linux-samsung-soc@vger.kernel.org,
	"'Kukjin Kim'" <kgene@kernel.org>,
	'김학주' <ruppi.kim@hardkernel.com>,
	"'Tomasz Figa'" <tomasz.figa@gmail.com>,
	"'Humberto Naves'" <hsnaves@gmail.com>,
	"'Jan Kiszka'" <jan.kiszka@siemens.com>,
	"'Johann Pfefferl'" <johann.pfefferl@siemens.com>,
	"'Ben Gamari'" <bgamari.foss@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"'Linux Kernel'" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
Date: Tue, 17 Mar 2015 11:10:11 +0900	[thread overview]
Message-ID: <07a201d06057$800cd410$80267c30$@kernel.org> (raw)
In-Reply-To: <CABxcv=kXkMkGkq=xjEBkfzdeFZ7XHDhneAxCgANoMDZ4u2Z4yw@mail.gmail.com>

Javier Martinez Canillas wrote:
> 
> Hello Andreas,
> 
Hi,

> On Mon, Mar 16, 2015 at 11:27 AM, Andreas Färber <afaerber@suse.de> wrote:
> > Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas:
> >>
> >> I think this should be defined in exynos5410.dtsi instead since is an
> >> IP block in the SoC and referenced in the .dts using a label to change
> >> the clock-frequency in the board.
> >
> > I hope you understood that this is a literal copy of smdk5410, so I'm
> > not going to make random changes here. If the Samsung guys want to make
> > this change for smdk5410, then fine, but otherwise - like for Snow and
> > Spring - I want to keep the diff -u low between the two.
> >
> 
> Yes I did understand that it was a copy but I thought it could be
> improved anyways. But I don't have a strong opinion either to block
> this series and always both DTS can be changed as a follow-up. So I'm
> ok with your decision to keeping the delta to the minimum for now.
> 
Yeah, everybody can update everything in mainline if it can be got review in
mailinglist. BTW asthe fin_pll can be different according to board condition
that's why it is defined in each boart DT file, it is mostly same on each
boards though...So I think keeping it would be more make sense.

Thanks,
Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree
Date: Tue, 17 Mar 2015 11:10:11 +0900	[thread overview]
Message-ID: <07a201d06057$800cd410$80267c30$@kernel.org> (raw)
In-Reply-To: <CABxcv=kXkMkGkq=xjEBkfzdeFZ7XHDhneAxCgANoMDZ4u2Z4yw@mail.gmail.com>

Javier Martinez Canillas wrote:
> 
> Hello Andreas,
> 
Hi,

> On Mon, Mar 16, 2015 at 11:27 AM, Andreas F?rber <afaerber@suse.de> wrote:
> > Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas:
> >>
> >> I think this should be defined in exynos5410.dtsi instead since is an
> >> IP block in the SoC and referenced in the .dts using a label to change
> >> the clock-frequency in the board.
> >
> > I hope you understood that this is a literal copy of smdk5410, so I'm
> > not going to make random changes here. If the Samsung guys want to make
> > this change for smdk5410, then fine, but otherwise - like for Snow and
> > Spring - I want to keep the diff -u low between the two.
> >
> 
> Yes I did understand that it was a copy but I thought it could be
> improved anyways. But I don't have a strong opinion either to block
> this series and always both DTS can be changed as a follow-up. So I'm
> ok with your decision to keeping the delta to the minimum for now.
> 
Yeah, everybody can update everything in mainline if it can be got review in
mailinglist. BTW asthe fin_pll can be different according to board condition
that's why it is defined in each boart DT file, it is mostly same on each
boards though...So I think keeping it would be more make sense.

Thanks,
Kukjin

  reply	other threads:[~2015-03-17  2:10 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-15 22:00 [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Andreas Färber
2015-03-15 22:00 ` Andreas Färber
2015-03-15 22:00 ` [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation Andreas Färber
2015-03-15 22:00   ` Andreas Färber
2015-03-16  7:24   ` Javier Martinez Canillas
2015-03-16  7:24     ` Javier Martinez Canillas
2015-06-02 12:58   ` Krzysztof Kozlowski
2015-06-02 12:58     ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree Andreas Färber
2015-03-15 22:00   ` Andreas Färber
2015-03-16  7:56   ` Javier Martinez Canillas
2015-03-16  7:56     ` Javier Martinez Canillas
2015-03-16 10:27     ` Andreas Färber
2015-03-16 10:27       ` Andreas Färber
2015-03-16 10:58       ` Javier Martinez Canillas
2015-03-16 10:58         ` Javier Martinez Canillas
2015-03-17  2:10         ` Kukjin Kim [this message]
2015-03-17  2:10           ` Kukjin Kim
2015-06-02 12:43       ` Krzysztof Kozlowski
2015-06-02 12:43         ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 3/5] pinctrl: exynos: add exynos5410 SoC specific data Andreas Färber
2015-03-15 22:00   ` Andreas Färber
2015-03-23 17:22   ` Tomasz Figa
2015-03-23 17:22     ` Tomasz Figa
2015-06-02 12:46     ` Krzysztof Kozlowski
2015-06-02 12:46       ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 4/5] ARM: dts: add pinctrl support to Exynos5410 Andreas Färber
2015-03-15 22:00   ` Andreas Färber
2015-06-02 12:59   ` Krzysztof Kozlowski
2015-06-02 12:59     ` Krzysztof Kozlowski
2015-03-15 22:00 ` [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu Andreas Färber
2015-03-15 22:00   ` Andreas Färber
2015-03-16  8:02   ` Javier Martinez Canillas
2015-03-16  8:02     ` Javier Martinez Canillas
2015-06-02 13:02   ` Krzysztof Kozlowski
2015-06-02 13:02     ` Krzysztof Kozlowski
2015-06-02 13:38     ` Andreas Färber
2015-06-02 13:38       ` Andreas Färber
2015-06-02 23:55       ` Krzysztof Kozlowski
2015-06-02 23:55         ` Krzysztof Kozlowski
2015-03-31 19:48 ` [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs Ben Gamari
2015-03-31 19:48   ` Ben Gamari
2015-03-31 19:48   ` Ben Gamari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='07a201d06057$800cd410$80267c30$@kernel.org' \
    --to=kgene@kernel.org \
    --cc=afaerber@suse.de \
    --cc=bgamari.foss@gmail.com \
    --cc=hsnaves@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=javier@dowhile0.org \
    --cc=johann.pfefferl@siemens.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=ruppi.kim@hardkernel.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.