From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>, linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH v10 5/6] IMA: Add support to limit measuring keys
Date: Tue, 10 Dec 2019 23:23:01 +0000 [thread overview]
Message-ID: <07c231c9-509e-cd1f-9ea0-bfb20f9a0070@linux.microsoft.com> (raw)
In-Reply-To: <1576017805.4579.44.camel@linux.ibm.com>
On 12/10/19 2:43 PM, Mimi Zohar wrote:
>> +static bool ima_match_keyring(struct ima_rule_entry *rule,
>> + const char *keyring, const struct cred *cred)
>> +{
>> + char *keyrings, *next_keyring, *keyrings_ptr;
>> + bool matched = false;
>> +
>> + /* If "keyrings=" is not specified all keys are measured. */
>
> With the addiitonal "uid" support this isn't necessarily true any
> more.
>
> Mimi
Will move the check for uid ahead of the check for keyrings.
if ((rule->flags & IMA_UID) && !rule->uid_op(cred->uid, rule->uid))
return false;
>
>> + if (!rule->keyrings)
>> + return true;
>> +
>> + if (!keyring)
>> + return false;
>> +
>> + if ((rule->flags & IMA_UID) && !rule->uid_op(cred->uid, rule->uid))
>> + return false;
>> +
thanks,
-lakshmi
WARNING: multiple messages have this Message-ID (diff)
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>, linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH v10 5/6] IMA: Add support to limit measuring keys
Date: Tue, 10 Dec 2019 15:23:01 -0800 [thread overview]
Message-ID: <07c231c9-509e-cd1f-9ea0-bfb20f9a0070@linux.microsoft.com> (raw)
In-Reply-To: <1576017805.4579.44.camel@linux.ibm.com>
On 12/10/19 2:43 PM, Mimi Zohar wrote:
>> +static bool ima_match_keyring(struct ima_rule_entry *rule,
>> + const char *keyring, const struct cred *cred)
>> +{
>> + char *keyrings, *next_keyring, *keyrings_ptr;
>> + bool matched = false;
>> +
>> + /* If "keyrings=" is not specified all keys are measured. */
>
> With the addiitonal "uid" support this isn't necessarily true any
> more.
>
> Mimi
Will move the check for uid ahead of the check for keyrings.
if ((rule->flags & IMA_UID) && !rule->uid_op(cred->uid, rule->uid))
return false;
>
>> + if (!rule->keyrings)
>> + return true;
>> +
>> + if (!keyring)
>> + return false;
>> +
>> + if ((rule->flags & IMA_UID) && !rule->uid_op(cred->uid, rule->uid))
>> + return false;
>> +
thanks,
-lakshmi
next prev parent reply other threads:[~2019-12-10 23:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 22:41 [PATCH v10 0/6] KEYS: Measure keys when they are created or updated Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-04 22:41 ` [PATCH v10 1/6] IMA: Check IMA policy flag Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:42 ` Mimi Zohar
2019-12-10 22:42 ` Mimi Zohar
2019-12-10 23:29 ` Lakshmi Ramasubramanian
2019-12-10 23:29 ` Lakshmi Ramasubramanian
2019-12-11 0:03 ` Mimi Zohar
2019-12-11 0:03 ` Mimi Zohar
2019-12-04 22:41 ` [PATCH v10 2/6] IMA: Add KEY_CHECK func to measure keys Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-04 22:41 ` [PATCH v10 3/6] IMA: Define an IMA hook " Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:42 ` Mimi Zohar
2019-12-10 22:42 ` Mimi Zohar
2019-12-04 22:41 ` [PATCH v10 4/6] KEYS: Call the " Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:43 ` Mimi Zohar
2019-12-10 22:43 ` Mimi Zohar
2019-12-04 22:41 ` [PATCH v10 5/6] IMA: Add support to limit measuring keys Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:43 ` Mimi Zohar
2019-12-10 22:43 ` Mimi Zohar
2019-12-10 23:23 ` Lakshmi Ramasubramanian [this message]
2019-12-10 23:23 ` Lakshmi Ramasubramanian
2019-12-04 22:41 ` [PATCH v10 6/6] IMA: Read keyrings= option from the IMA policy Lakshmi Ramasubramanian
2019-12-04 22:41 ` Lakshmi Ramasubramanian
2019-12-10 22:43 ` Mimi Zohar
2019-12-10 22:43 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07c231c9-509e-cd1f-9ea0-bfb20f9a0070@linux.microsoft.com \
--to=nramas@linux.microsoft.com \
--cc=dhowells@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=jamorris@linux.microsoft.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthewgarrett@google.com \
--cc=sashal@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.