All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/2] Rewrite utsname testing suite
Date: Mon, 31 Oct 2022 14:14:21 +0100	[thread overview]
Message-ID: <07e278ff-3122-cf42-d739-2bb6020b921b@suse.com> (raw)
In-Reply-To: <Y1/GpPKVzWUAV1DK@pevik>

Hi
On 10/31/22 13:59, Petr Vorel wrote:
> Hi Andrea,
>
>> +#define _GNU_SOURCE
>> +
>> +#include "tst_test.h"
>> +#include "utsname.h"
>> +
>> +#define HLEN 100
> Could this definition be in utsname.h?
> Also, although getconf HOST_NAME_MAX returns 64 on my machine, maybe using from
> HOST_NAME_MAX would be safer (that can be up to 255).
> Also maybe HOSTLEN (readability)?

It makes sense to use HOST_NAME_MAX. I will use it in the next patches

>
> Kind regards,
> Petr

Andrea


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2022-10-31 13:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 11:30 [LTP] [PATCH v2 0/2] Rewrite utstest suite Andrea Cervesato via ltp
2022-10-31 11:30 ` [LTP] [PATCH v2 1/2] Add SAFE_SETHOSTNAME macro Andrea Cervesato via ltp
2022-10-31 11:30 ` [LTP] [PATCH v2 2/2] Rewrite utsname testing suite Andrea Cervesato via ltp
2022-10-31 12:59   ` Petr Vorel
2022-10-31 13:14     ` Andrea Cervesato via ltp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07e278ff-3122-cf42-d739-2bb6020b921b@suse.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.