From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/2] Rewrite utsname testing suite
Date: Mon, 31 Oct 2022 13:59:16 +0100 [thread overview]
Message-ID: <Y1/GpPKVzWUAV1DK@pevik> (raw)
In-Reply-To: <20221031113046.9218-3-andrea.cervesato@suse.com>
Hi Andrea,
> +#define _GNU_SOURCE
> +
> +#include "tst_test.h"
> +#include "utsname.h"
> +
> +#define HLEN 100
Could this definition be in utsname.h?
Also, although getconf HOST_NAME_MAX returns 64 on my machine, maybe using from
HOST_NAME_MAX would be safer (that can be up to 255).
Also maybe HOSTLEN (readability)?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-10-31 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:30 [LTP] [PATCH v2 0/2] Rewrite utstest suite Andrea Cervesato via ltp
2022-10-31 11:30 ` [LTP] [PATCH v2 1/2] Add SAFE_SETHOSTNAME macro Andrea Cervesato via ltp
2022-10-31 11:30 ` [LTP] [PATCH v2 2/2] Rewrite utsname testing suite Andrea Cervesato via ltp
2022-10-31 12:59 ` Petr Vorel [this message]
2022-10-31 13:14 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1/GpPKVzWUAV1DK@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.