Re: [PATCH 0/2] drm/panel: samsung: Share test key command helpers

[Neil Armstrong <neil.armstrong@linaro.org>]

On 9/3/26 23:21, Linus Walleij wrote:
> Several Samsung display controller drivers use identical three-byte
> commands to enable and disable test key levels. The commands are
> currently repeated as driver-specific macros or raw DCS writes.
> 
> Add a private Samsung DSI header with typed helpers for all three test
> key levels. Use it in the drivers that already identify these commands
> by level, including the S6E88A0 AMS452EF01 driver whose comments identify
> the raw F0 pair as level 2 commands.
> 
> Drivers with conflicting level numbering or without an established
> test-key name are deliberately left unchanged.
> 
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>
> ---
> Linus Walleij (2):
>        drm/panel: samsung: Add shared test key helpers
>        drm/panel: samsung-s6e88a0-ams452ef01: Use test key helpers
> 
>   drivers/gpu/drm/panel/panel-samsung-dsi.h          | 38 ++++++++++++
>   drivers/gpu/drm/panel/panel-samsung-s6e3fc2x01.c   | 71 +++++++++-------------
>   drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c      | 70 +++++++++------------
>   .../drm/panel/panel-samsung-s6e88a0-ams452ef01.c   |  6 +-
>   .../gpu/drm/panel/panel-samsung-s6e8fc0-m1906f9.c  | 23 +++----
>   drivers/gpu/drm/panel/panel-samsung-sofef00.c      | 15 ++---
>   6 files changed, 116 insertions(+), 107 deletions(-)
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260903-drm-panels-sofef0-73886714ac49
> 
> Best regards,
> --
> Linus Walleij <linusw@kernel.org>
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil