From: Linus Walleij <linusw@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
David Heidelberg <david@ixit.cz>,
Dzmitry Sankouski <dsankouski@gmail.com>,
Yedaya Katsman <yedaya.ka@gmail.com>,
Casey Connolly <casey.connolly@linaro.org>
Cc: dri-devel@lists.freedesktop.org, Linus Walleij <linusw@kernel.org>
Subject: [PATCH 0/2] drm/panel: samsung: Share test key command helpers
Date: Thu, 03 Sep 2026 23:21:18 +0200 [thread overview]
Message-ID: <20260903-drm-panels-sofef0-v1-0-9e841645beba@kernel.org> (raw)
Several Samsung display controller drivers use identical three-byte
commands to enable and disable test key levels. The commands are
currently repeated as driver-specific macros or raw DCS writes.
Add a private Samsung DSI header with typed helpers for all three test
key levels. Use it in the drivers that already identify these commands
by level, including the S6E88A0 AMS452EF01 driver whose comments identify
the raw F0 pair as level 2 commands.
Drivers with conflicting level numbering or without an established
test-key name are deliberately left unchanged.
Assisted-by: LLM
Signed-off-by: Linus Walleij <linusw@kernel.org>
---
Linus Walleij (2):
drm/panel: samsung: Add shared test key helpers
drm/panel: samsung-s6e88a0-ams452ef01: Use test key helpers
drivers/gpu/drm/panel/panel-samsung-dsi.h | 38 ++++++++++++
drivers/gpu/drm/panel/panel-samsung-s6e3fc2x01.c | 71 +++++++++-------------
drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c | 70 +++++++++------------
.../drm/panel/panel-samsung-s6e88a0-ams452ef01.c | 6 +-
.../gpu/drm/panel/panel-samsung-s6e8fc0-m1906f9.c | 23 +++----
drivers/gpu/drm/panel/panel-samsung-sofef00.c | 15 ++---
6 files changed, 116 insertions(+), 107 deletions(-)
---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260903-drm-panels-sofef0-73886714ac49
Best regards,
--
Linus Walleij <linusw@kernel.org>
next reply other threads:[~2026-09-03 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 21:21 Linus Walleij [this message]
2026-09-03 21:21 ` [PATCH 1/2] drm/panel: samsung: Add shared test key helpers Linus Walleij
2026-09-03 21:21 ` [PATCH 2/2] drm/panel: samsung-s6e88a0-ams452ef01: Use " Linus Walleij
2026-09-03 21:23 ` [PATCH 0/2] drm/panel: samsung: Share test key command helpers David Heidelberg
2026-09-08 12:16 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903-drm-panels-sofef0-v1-0-9e841645beba@kernel.org \
--to=linusw@kernel.org \
--cc=airlied@gmail.com \
--cc=casey.connolly@linaro.org \
--cc=david@ixit.cz \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsankouski@gmail.com \
--cc=jesszhan0024@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=yedaya.ka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.