Re: [PATCH v5 05/11] media: rockchip: add a driver for the rockchip camera interface

From: Markus Elfring <Markus.Elfring@web.de>
To: "Gerald Loacker" <gerald.loacker@wolfvision.net>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Mehdi Djait" <mehdi.djait@bootlin.com>,
	"Michael Riesch" <michael.riesch@wolfvision.net>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	"Alexander Shiyan" <eagle.alexander923@gmail.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
	"Paul Kocialkowski" <paulk@sys-base.io>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Rob Herring" <robh@kernel.org>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Sebastian Fricke" <sebastian.fricke@collabora.com>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Val Packett" <val@packett.cool>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Mehdi Djait <mehdi.djait@linux.intel.com>
Subject: Re: [PATCH v5 05/11] media: rockchip: add a driver for the rockchip camera interface
Date: Mon, 28 Apr 2025 16:05:19 +0200	[thread overview]
Message-ID: <07f95756-8ba3-4cad-b97a-cf69866e0c2e@web.de> (raw)
In-Reply-To: <20250306-v6-8-topic-rk3568-vicap-v5-5-f02152534f3c@wolfvision.net>

…
> +++ b/drivers/media/platform/rockchip/rkcif/rkcif-stream.c
> @@ -0,0 +1,622 @@
…
> +static void rkcif_stream_push_buffer(struct rkcif_stream *stream,
> +				     struct rkcif_buffer *buffer)
> +{
> +	unsigned long lock_flags;
> +
> +	spin_lock_irqsave(&stream->driver_queue_lock, lock_flags);
> +	list_add_tail(&buffer->queue, &stream->driver_queue);
> +	spin_unlock_irqrestore(&stream->driver_queue_lock, lock_flags);
> +}
…

Will development interests grow to apply a statement
like “guard(spinlock_irqsave)(&stream->driver_queue_lock);”?
https://elixir.bootlin.com/linux/v6.15-rc3/source/include/linux/spinlock.h#L571-L573

Regards,
Markus