* [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size
@ 2019-01-24 17:06 Colin King
2019-01-24 17:27 ` [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code Pierre-Louis Bossart
0 siblings, 1 reply; 5+ messages in thread
From: Colin King @ 2019-01-24 17:06 UTC (permalink / raw)
To: Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Hans de Goede, alsa-devel,
linux-kernel
Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
Don't populate the const array mic_name on the stack but instead make
it static. Makes the object code smaller by 28 bytes:
Before:
text data bss dec hex filename
14107 8832 224 23163 5a7b bytcht_es8316.o
After:
text data bss dec hex filename
14015 8896 224 23135 5a5f bytcht_es8316.o
(gcc version 8.2.0 x86_64)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/intel/boards/bytcht_es8316.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
index fa9c4cf97686..1364e4e601d8 100644
--- a/sound/soc/intel/boards/bytcht_es8316.c
+++ b/sound/soc/intel/boards/bytcht_es8316.c
@@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping byt_cht_es8316_gpios[] = {
static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
{
- const char * const mic_name[] = { "in1", "in2" };
+ static const char * const mic_name[] = { "in1", "in2" };
struct byt_cht_es8316_private *priv;
struct device *dev = &pdev->dev;
struct snd_soc_acpi_mach *mach;
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size
2019-01-24 17:06 [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size Colin King
@ 2019-01-24 17:27 ` Pierre-Louis Bossart
0 siblings, 0 replies; 5+ messages in thread
From: Pierre-Louis Bossart @ 2019-01-24 17:27 UTC (permalink / raw)
To: Colin King, Liam Girdwood, Jie Yang, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Hans de Goede, alsa-devel, linux-kernel
Cc: kernel-janitors
> diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
> index fa9c4cf97686..1364e4e601d8 100644
> --- a/sound/soc/intel/boards/bytcht_es8316.c
> +++ b/sound/soc/intel/boards/bytcht_es8316.c
> @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping byt_cht_es8316_gpios[] = {
>
> static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
> {
> - const char * const mic_name[] = { "in1", "in2" };
> + static const char * const mic_name[] = { "in1", "in2" };
> struct byt_cht_es8316_private *priv;
> struct device *dev = &pdev->dev;
> struct snd_soc_acpi_mach *mach;
We have the same code pattern in two other files, so if we care about
this we should fix it across the board(s), no?
bytcht_es8316.c: const char * const mic_name[] = { "in1", "in2" };
bytcr_rt5640.c: const char * const map_name[] = { "dmic1", "dmic2",
"in1", "in3" };
bytcr_rt5651.c: const char * const mic_name[] = { "dmic", "in1",
"in2", "in12" };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code
@ 2019-01-24 17:27 ` Pierre-Louis Bossart
0 siblings, 0 replies; 5+ messages in thread
From: Pierre-Louis Bossart @ 2019-01-24 17:27 UTC (permalink / raw)
To: Colin King, Liam Girdwood, Jie Yang, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Hans de Goede, alsa-devel, linux-kernel
Cc: kernel-janitors
> diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
> index fa9c4cf97686..1364e4e601d8 100644
> --- a/sound/soc/intel/boards/bytcht_es8316.c
> +++ b/sound/soc/intel/boards/bytcht_es8316.c
> @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping byt_cht_es8316_gpios[] = {
>
> static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
> {
> - const char * const mic_name[] = { "in1", "in2" };
> + static const char * const mic_name[] = { "in1", "in2" };
> struct byt_cht_es8316_private *priv;
> struct device *dev = &pdev->dev;
> struct snd_soc_acpi_mach *mach;
We have the same code pattern in two other files, so if we care about
this we should fix it across the board(s), no?
bytcht_es8316.c: const char * const mic_name[] = { "in1", "in2" };
bytcr_rt5640.c: const char * const map_name[] = { "dmic1", "dmic2",
"in1", "in3" };
bytcr_rt5651.c: const char * const mic_name[] = { "dmic", "in1",
"in2", "in12" };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size
2019-01-24 17:27 ` [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code Pierre-Louis Bossart
@ 2019-01-24 17:29 ` Colin Ian King
-1 siblings, 0 replies; 5+ messages in thread
From: Colin Ian King @ 2019-01-24 17:29 UTC (permalink / raw)
To: Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Hans de Goede, alsa-devel,
linux-kernel
Cc: kernel-janitors
On 24/01/2019 17:27, Pierre-Louis Bossart wrote:
>
>> diff --git a/sound/soc/intel/boards/bytcht_es8316.c
>> b/sound/soc/intel/boards/bytcht_es8316.c
>> index fa9c4cf97686..1364e4e601d8 100644
>> --- a/sound/soc/intel/boards/bytcht_es8316.c
>> +++ b/sound/soc/intel/boards/bytcht_es8316.c
>> @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping
>> byt_cht_es8316_gpios[] = {
>> static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
>> {
>> - const char * const mic_name[] = { "in1", "in2" };
>> + static const char * const mic_name[] = { "in1", "in2" };
>> struct byt_cht_es8316_private *priv;
>> struct device *dev = &pdev->dev;
>> struct snd_soc_acpi_mach *mach;
>
> We have the same code pattern in two other files, so if we care about
> this we should fix it across the board(s), no?
>
> bytcht_es8316.c: const char * const mic_name[] = { "in1", "in2" };
> bytcr_rt5640.c: const char * const map_name[] = { "dmic1", "dmic2",
> "in1", "in3" };
> bytcr_rt5651.c: const char * const mic_name[] = { "dmic", "in1",
> "in2", "in12" };
>
Good point, will resend.
Colin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code
@ 2019-01-24 17:29 ` Colin Ian King
0 siblings, 0 replies; 5+ messages in thread
From: Colin Ian King @ 2019-01-24 17:29 UTC (permalink / raw)
To: Pierre-Louis Bossart, Liam Girdwood, Jie Yang, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Hans de Goede, alsa-devel,
linux-kernel
Cc: kernel-janitors
On 24/01/2019 17:27, Pierre-Louis Bossart wrote:
>
>> diff --git a/sound/soc/intel/boards/bytcht_es8316.c
>> b/sound/soc/intel/boards/bytcht_es8316.c
>> index fa9c4cf97686..1364e4e601d8 100644
>> --- a/sound/soc/intel/boards/bytcht_es8316.c
>> +++ b/sound/soc/intel/boards/bytcht_es8316.c
>> @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping
>> byt_cht_es8316_gpios[] = {
>> static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
>> {
>> - const char * const mic_name[] = { "in1", "in2" };
>> + static const char * const mic_name[] = { "in1", "in2" };
>> struct byt_cht_es8316_private *priv;
>> struct device *dev = &pdev->dev;
>> struct snd_soc_acpi_mach *mach;
>
> We have the same code pattern in two other files, so if we care about
> this we should fix it across the board(s), no?
>
> bytcht_es8316.c: const char * const mic_name[] = { "in1", "in2" };
> bytcr_rt5640.c: const char * const map_name[] = { "dmic1", "dmic2",
> "in1", "in3" };
> bytcr_rt5651.c: const char * const mic_name[] = { "dmic", "in1",
> "in2", "in12" };
>
Good point, will resend.
Colin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-24 17:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-24 17:06 [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size Colin King
2019-01-24 17:27 ` [alsa-devel] " Pierre-Louis Bossart
2019-01-24 17:27 ` [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code Pierre-Louis Bossart
2019-01-24 17:29 ` [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size Colin Ian King
2019-01-24 17:29 ` [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code Colin Ian King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.