From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>
Cc: anan.sun@mediatek.com, chengci.xu@mediatek.com,
xueqi.zhang@mediatek.com, linux-kernel@vger.kernel.org,
libo.kang@mediatek.com, yf.wang@mediatek.com,
iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Guenter Roeck <groeck@chromium.org>,
mingyuan.ma@mediatek.com, linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 1/5] iommu/mediatek: Use dev_err_probe to mute probe_defer err log
Date: Thu, 16 Jun 2022 15:28:33 +0200 [thread overview]
Message-ID: <085be77f-3833-628e-b76a-b2b888db3b78@gmail.com> (raw)
In-Reply-To: <20220616054203.11365-2-yong.wu@mediatek.com>
On 16/06/2022 07:41, Yong Wu wrote:
> Mute the probe defer log:
>
> [ 2.654806] mtk-iommu 14018000.iommu: mm dts parse fail(-517).
> [ 2.656168] mtk-iommu 1c01f000.iommu: mm dts parse fail(-517).
>
> Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE")
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/iommu/mtk_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index bb9dd92c9898..3b2489e8a6dd 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -1204,7 +1204,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
> if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) {
> ret = mtk_iommu_mm_dts_parse(dev, &match, data);
> if (ret) {
> - dev_err(dev, "mm dts parse fail(%d).", ret);
> + dev_err_probe(dev, ret, "mm dts parse fail.");
> goto out_runtime_disable;
> }
> } else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA) &&
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>
Cc: iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
mingyuan.ma@mediatek.com, yf.wang@mediatek.com,
libo.kang@mediatek.com, chengci.xu@mediatek.com,
youlin.pei@mediatek.com, anan.sun@mediatek.com,
xueqi.zhang@mediatek.com, Guenter Roeck <groeck@chromium.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2 1/5] iommu/mediatek: Use dev_err_probe to mute probe_defer err log
Date: Thu, 16 Jun 2022 15:28:33 +0200 [thread overview]
Message-ID: <085be77f-3833-628e-b76a-b2b888db3b78@gmail.com> (raw)
In-Reply-To: <20220616054203.11365-2-yong.wu@mediatek.com>
On 16/06/2022 07:41, Yong Wu wrote:
> Mute the probe defer log:
>
> [ 2.654806] mtk-iommu 14018000.iommu: mm dts parse fail(-517).
> [ 2.656168] mtk-iommu 1c01f000.iommu: mm dts parse fail(-517).
>
> Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE")
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/iommu/mtk_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index bb9dd92c9898..3b2489e8a6dd 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -1204,7 +1204,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
> if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) {
> ret = mtk_iommu_mm_dts_parse(dev, &match, data);
> if (ret) {
> - dev_err(dev, "mm dts parse fail(%d).", ret);
> + dev_err_probe(dev, ret, "mm dts parse fail.");
> goto out_runtime_disable;
> }
> } else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA) &&
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>
Cc: iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
mingyuan.ma@mediatek.com, yf.wang@mediatek.com,
libo.kang@mediatek.com, chengci.xu@mediatek.com,
youlin.pei@mediatek.com, anan.sun@mediatek.com,
xueqi.zhang@mediatek.com, Guenter Roeck <groeck@chromium.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2 1/5] iommu/mediatek: Use dev_err_probe to mute probe_defer err log
Date: Thu, 16 Jun 2022 15:28:33 +0200 [thread overview]
Message-ID: <085be77f-3833-628e-b76a-b2b888db3b78@gmail.com> (raw)
In-Reply-To: <20220616054203.11365-2-yong.wu@mediatek.com>
On 16/06/2022 07:41, Yong Wu wrote:
> Mute the probe defer log:
>
> [ 2.654806] mtk-iommu 14018000.iommu: mm dts parse fail(-517).
> [ 2.656168] mtk-iommu 1c01f000.iommu: mm dts parse fail(-517).
>
> Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE")
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/iommu/mtk_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index bb9dd92c9898..3b2489e8a6dd 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -1204,7 +1204,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
> if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) {
> ret = mtk_iommu_mm_dts_parse(dev, &match, data);
> if (ret) {
> - dev_err(dev, "mm dts parse fail(%d).", ret);
> + dev_err_probe(dev, ret, "mm dts parse fail.");
> goto out_runtime_disable;
> }
> } else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA) &&
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-16 13:28 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 5:41 [PATCH v2 0/5] iommu/mediatek: Improve safety from dts Yong Wu via iommu
2022-06-16 5:41 ` Yong Wu
2022-06-16 5:41 ` Yong Wu
2022-06-16 5:41 ` [PATCH v2 1/5] iommu/mediatek: Use dev_err_probe to mute probe_defer err log Yong Wu via iommu
2022-06-16 5:41 ` Yong Wu
2022-06-16 5:41 ` Yong Wu
2022-06-16 13:28 ` Matthias Brugger [this message]
2022-06-16 13:28 ` Matthias Brugger
2022-06-16 13:28 ` Matthias Brugger
2022-06-16 5:42 ` [PATCH v2 2/5] iommu/mediatek: Add error path for loop of mm_dts_parse Yong Wu via iommu
2022-06-16 5:42 ` Yong Wu
2022-06-16 5:42 ` Yong Wu
2022-06-16 8:59 ` Robin Murphy
2022-06-16 8:59 ` Robin Murphy
2022-06-16 8:59 ` Robin Murphy
2022-06-16 10:08 ` Yong Wu via iommu
2022-06-16 10:08 ` Yong Wu
2022-06-16 10:08 ` Yong Wu
2022-06-16 10:31 ` Robin Murphy
2022-06-16 10:31 ` Robin Murphy
2022-06-16 10:31 ` Robin Murphy
2022-06-23 1:54 ` Yong Wu via iommu
2022-06-23 1:54 ` Yong Wu
2022-06-23 1:54 ` Yong Wu
2022-06-23 10:08 ` Robin Murphy
2022-06-23 10:08 ` Robin Murphy
2022-06-23 10:08 ` Robin Murphy
2022-06-16 13:49 ` Matthias Brugger
2022-06-16 13:49 ` Matthias Brugger
2022-06-16 13:49 ` Matthias Brugger
2022-06-23 2:12 ` Yong Wu via iommu
2022-06-23 2:12 ` Yong Wu
2022-06-23 2:12 ` Yong Wu
2022-06-16 5:42 ` [PATCH v2 3/5] iommu/mediatek: Validate number of phandles associated with "mediatek, larbs" Yong Wu via iommu
2022-06-16 5:42 ` Yong Wu
2022-06-16 5:42 ` Yong Wu
2022-06-16 5:42 ` [PATCH v2 4/5] iommu/mediatek: Improve safety for mediatek, smi property in larb nodes Yong Wu via iommu
2022-06-16 5:42 ` Yong Wu
2022-06-16 5:42 ` Yong Wu
2022-06-16 5:42 ` [PATCH v2 5/5] iommu/mediatek: Remove a unused "mapping" which is only for v1 Yong Wu via iommu
2022-06-16 5:42 ` Yong Wu
2022-06-16 5:42 ` Yong Wu
2022-06-16 12:03 ` AngeloGioacchino Del Regno
2022-06-16 12:03 ` AngeloGioacchino Del Regno
2022-06-16 12:03 ` AngeloGioacchino Del Regno
2022-06-16 13:56 ` Matthias Brugger
2022-06-16 13:56 ` Matthias Brugger
2022-06-16 13:56 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=085be77f-3833-628e-b76a-b2b888db3b78@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chengci.xu@mediatek.com \
--cc=dan.carpenter@oracle.com \
--cc=groeck@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=libo.kang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mingyuan.ma@mediatek.com \
--cc=will@kernel.org \
--cc=xueqi.zhang@mediatek.com \
--cc=yf.wang@mediatek.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.