From: dthaler1968@googlemail.com
To: <bpf@ietf.org>
Cc: <bpf@vger.kernel.org>, <bpf-chairs@ietf.org>
Subject: RE: BPF WG ISA Document: Last Call
Date: Fri, 5 Apr 2024 08:24:19 -0700 [thread overview]
Message-ID: <086301da876d$54c3e400$fe4bac00$@gmail.com> (raw)
In-Reply-To: <20240307180133.GB63192@maniforge>
David Vernet <void@manifault.com> wrote:
> We've made great progress since IETF 118, and we're thrilled to announce
that
> the Instruction Set Architecture (ISA) document is now in working group
last
> call. Please review the document at [0], and share any remaining feedback
that
> you believe needs to be addressed before we send the document to the ADs.
[...]
> Because we're so close to IETF 119, the document will remain in last call
for at
> least two weeks following the conclusion of the conference.
FYI to all, per IETF 119 minutes the WGLC closes today.
I just did another read-through and found some more editorial nits which I
plan to send a patch for, but wanted to get this email out before WGLC ends.
Section 1.1: "_s16_ is a types whose..."
s/types/type/
Section 1.4: "tools as such compilers that..."
s/as such/such as/
Section 2.1: the src_reg field correctly says "the source register number
(0-10),
except where otherwise specified", but dst_reg and offset are missing the
"except where otherwise specified" phrases on their definitions, since some
new instructions (SDIV, SMOD, MOVSX) reuse offset for other purposes, and
the thread around future callx would use dst_reg for another purpose so
having
similar caveats on all three fields seems warranted.
Section 3.1: most places in the doc use "8-bit", "16-bit", "32-bit", and
"64-bit"
as adjectives. A couple places in this section are missing the hyphen so
are inconsistent.
Section 3.2: most places in the doc put field names in single quotes like
'imm'
when referencing them in normal text. A few places in this section, and one
in
section 3.1, are missing the single quotes so are inconsistent.
Section 4.2: "Where size is one of:"
s/size/'<size>'/
for consistency with Section 4.1.
Section 5.1: "a IANA sub-registry"
s/a/an/
Section 5.1.2: "to supercede the existing conformance group"
s/supercede/supersede/
Dave
WARNING: multiple messages have this Message-ID (diff)
From: dthaler1968=40googlemail.com@dmarc.ietf.org
To: <bpf@ietf.org>
Cc: <bpf@vger.kernel.org>, <bpf-chairs@ietf.org>
Subject: Re: [Bpf] BPF WG ISA Document: Last Call
Date: Fri, 5 Apr 2024 08:24:19 -0700 [thread overview]
Message-ID: <086301da876d$54c3e400$fe4bac00$@gmail.com> (raw)
Message-ID: <20240405152419.-26Er0f5jD3ZKzq27KeTdH9B0ISiXyOwLZNrQzYjUts@z> (raw)
In-Reply-To: <20240307180133.GB63192@maniforge>
David Vernet <void@manifault.com> wrote:
> We've made great progress since IETF 118, and we're thrilled to announce
that
> the Instruction Set Architecture (ISA) document is now in working group
last
> call. Please review the document at [0], and share any remaining feedback
that
> you believe needs to be addressed before we send the document to the ADs.
[...]
> Because we're so close to IETF 119, the document will remain in last call
for at
> least two weeks following the conclusion of the conference.
FYI to all, per IETF 119 minutes the WGLC closes today.
I just did another read-through and found some more editorial nits which I
plan to send a patch for, but wanted to get this email out before WGLC ends.
Section 1.1: "_s16_ is a types whose..."
s/types/type/
Section 1.4: "tools as such compilers that..."
s/as such/such as/
Section 2.1: the src_reg field correctly says "the source register number
(0-10),
except where otherwise specified", but dst_reg and offset are missing the
"except where otherwise specified" phrases on their definitions, since some
new instructions (SDIV, SMOD, MOVSX) reuse offset for other purposes, and
the thread around future callx would use dst_reg for another purpose so
having
similar caveats on all three fields seems warranted.
Section 3.1: most places in the doc use "8-bit", "16-bit", "32-bit", and
"64-bit"
as adjectives. A couple places in this section are missing the hyphen so
are inconsistent.
Section 3.2: most places in the doc put field names in single quotes like
'imm'
when referencing them in normal text. A few places in this section, and one
in
section 3.1, are missing the single quotes so are inconsistent.
Section 4.2: "Where size is one of:"
s/size/'<size>'/
for consistency with Section 4.1.
Section 5.1: "a IANA sub-registry"
s/a/an/
Section 5.1.2: "to supercede the existing conformance group"
s/supercede/supersede/
Dave
--
Bpf mailing list
Bpf@ietf.org
https://www.ietf.org/mailman/listinfo/bpf
next prev parent reply other threads:[~2024-04-05 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 18:01 BPF WG ISA Document: Last Call David Vernet
2024-03-07 18:01 ` [Bpf] " David Vernet
2024-04-05 15:24 ` dthaler1968 [this message]
2024-04-05 15:24 ` dthaler1968=40googlemail.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='086301da876d$54c3e400$fe4bac00$@gmail.com' \
--to=dthaler1968@googlemail.com \
--cc=bpf-chairs@ietf.org \
--cc=bpf@ietf.org \
--cc=bpf@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.