From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Michal Schmidt <mschmidt@redhat.com>, Calvin Owens <calvin@wbinvd.org>
Cc: <netdev@vger.kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
"Ivan Vecera" <ivecera@redhat.com>,
<intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH net] i40e: Prevent unwanted interface name changes
Date: Wed, 20 Aug 2025 11:41:42 +0200 [thread overview]
Message-ID: <089ba88e-e19d-40eb-844d-541d39e648e8@intel.com> (raw)
In-Reply-To: <CADEbmW100menFu3KACm4p72yPSjbnQwnYumDCGRw+GxpgXeMJA@mail.gmail.com>
On 8/20/25 08:42, Michal Schmidt wrote:
> On Wed, Aug 20, 2025 at 6:30 AM Calvin Owens <calvin@wbinvd.org> wrote:
>> The same naming regression which was reported in ixgbe and fixed in
>> commit e67a0bc3ed4f ("ixgbe: prevent from unwanted interface name
>> changes") still exists in i40e.
>>
>> Fix i40e by setting the same flag, added in commit c5ec7f49b480
>> ("devlink: let driver opt out of automatic phys_port_name generation").
>>
>> Fixes: 9e479d64dc58 ("i40e: Add initial devlink support")
>
> But this one's almost two years old. By now, there may be more users
> relying on the new name than on the old one.
> Michal
>
And, more importantly, noone was complaining on the new name ;)
WARNING: multiple messages have this Message-ID (diff)
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Michal Schmidt <mschmidt@redhat.com>, Calvin Owens <calvin@wbinvd.org>
Cc: <netdev@vger.kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
"Ivan Vecera" <ivecera@redhat.com>,
<intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] i40e: Prevent unwanted interface name changes
Date: Wed, 20 Aug 2025 11:41:42 +0200 [thread overview]
Message-ID: <089ba88e-e19d-40eb-844d-541d39e648e8@intel.com> (raw)
In-Reply-To: <CADEbmW100menFu3KACm4p72yPSjbnQwnYumDCGRw+GxpgXeMJA@mail.gmail.com>
On 8/20/25 08:42, Michal Schmidt wrote:
> On Wed, Aug 20, 2025 at 6:30 AM Calvin Owens <calvin@wbinvd.org> wrote:
>> The same naming regression which was reported in ixgbe and fixed in
>> commit e67a0bc3ed4f ("ixgbe: prevent from unwanted interface name
>> changes") still exists in i40e.
>>
>> Fix i40e by setting the same flag, added in commit c5ec7f49b480
>> ("devlink: let driver opt out of automatic phys_port_name generation").
>>
>> Fixes: 9e479d64dc58 ("i40e: Add initial devlink support")
>
> But this one's almost two years old. By now, there may be more users
> relying on the new name than on the old one.
> Michal
>
And, more importantly, noone was complaining on the new name ;)
next prev parent reply other threads:[~2025-08-20 9:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 4:29 [Intel-wired-lan] [PATCH net] i40e: Prevent unwanted interface name changes Calvin Owens
2025-08-20 4:29 ` Calvin Owens
2025-08-20 6:42 ` [Intel-wired-lan] " Michal Schmidt
2025-08-20 6:42 ` Michal Schmidt
2025-08-20 9:41 ` Przemek Kitszel [this message]
2025-08-20 9:41 ` Przemek Kitszel
2025-08-20 16:11 ` [Intel-wired-lan] " Calvin Owens
2025-08-20 16:11 ` Calvin Owens
2025-08-20 23:09 ` [Intel-wired-lan] " Calvin Owens
2025-08-20 23:09 ` Calvin Owens
2025-08-20 15:31 ` [Intel-wired-lan] " Calvin Owens
2025-08-20 15:31 ` Calvin Owens
2025-08-20 17:41 ` [Intel-wired-lan] " Calvin Owens
2025-08-20 17:41 ` Calvin Owens
2025-08-21 8:00 ` [Intel-wired-lan] " Przemek Kitszel
2025-08-21 8:00 ` Przemek Kitszel
2025-08-21 14:23 ` [Intel-wired-lan] " Calvin Owens
2025-08-21 14:23 ` Calvin Owens
2025-08-21 20:39 ` [Intel-wired-lan] " Przemek Kitszel
2025-08-21 20:39 ` Przemek Kitszel
2025-08-22 4:23 ` [Intel-wired-lan] " Calvin Owens
2025-08-22 4:23 ` Calvin Owens
2025-08-22 6:30 ` [Intel-wired-lan] " Paul Menzel
2025-08-22 14:23 ` Jakub Kicinski
2025-08-22 14:23 ` Jakub Kicinski
2025-08-22 20:25 ` [Intel-wired-lan] " Jacob Keller
2025-08-24 18:59 ` Calvin Owens
2025-08-24 18:59 ` Calvin Owens
2025-08-20 15:51 ` [Intel-wired-lan] " Loktionov, Aleksandr
2025-08-20 15:51 ` Loktionov, Aleksandr
2025-08-20 23:16 ` Calvin Owens
2025-08-22 6:31 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=089ba88e-e19d-40eb-844d-541d39e648e8@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=calvin@wbinvd.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=jedrzej.jagielski@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.