All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sangbeom Kim <sbkim73@samsung.com>
To: 'Padmavathi Venna' <padma.v@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org,
	devicetree-discuss@lists.ozlabs.org
Cc: kgene.kim@samsung.com, rcsekar@samsung.com,
	sangsu4u.park@samsung.com, joshi@samsung.com, thutt@chromium.org,
	ben-linux@fluff.org, olofj@google.com
Subject: Re: [PATCH 1/2] ASOC: SAMSUNG: Add DT support for i2s
Date: Wed, 01 Aug 2012 17:29:37 +0900	[thread overview]
Message-ID: <08da01cd6fbf$cd9b5c00$68d21400$@com> (raw)
In-Reply-To: <1343218170-30483-2-git-send-email-padma.v@samsung.com>

Hi,
On Wednesday, July 25, 2012 9:09 PM, Padmavathi Venna wrote:

> Add support for device based discovery.
> 
Currently, I'm reviewing your patch set.
Your patch can support device tree for Samsung's i2s.
But I wonder that Your patch can support non-dt too,
So, Please test your patch on non-dt environment.
It looks unclear handling of clock source.
After code review, I will give you more detail comments,

Thanks,
Sangbeom.

WARNING: multiple messages have this Message-ID (diff)
From: sbkim73@samsung.com (Sangbeom Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 1/2] ASOC: SAMSUNG: Add DT support for i2s
Date: Wed, 01 Aug 2012 17:29:37 +0900	[thread overview]
Message-ID: <08da01cd6fbf$cd9b5c00$68d21400$@com> (raw)
In-Reply-To: <1343218170-30483-2-git-send-email-padma.v@samsung.com>

Hi,
On Wednesday, July 25, 2012 9:09 PM, Padmavathi Venna wrote:

> Add support for device based discovery.
> 
Currently, I'm reviewing your patch set.
Your patch can support device tree for Samsung's i2s.
But I wonder that Your patch can support non-dt too,
So, Please test your patch on non-dt environment.
It looks unclear handling of clock source.
After code review, I will give you more detail comments,

Thanks,
Sangbeom.

  reply	other threads:[~2012-08-01  8:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-25 12:09 [PATCH 0/2] ASOC: SAMSUNG: Add dt support for i2s Padmavathi Venna
2012-07-25 12:09 ` Padmavathi Venna
2012-07-25 12:09 ` [PATCH 1/2] ASOC: SAMSUNG: Add DT " Padmavathi Venna
2012-07-25 12:09   ` Padmavathi Venna
2012-08-01  8:29   ` Sangbeom Kim [this message]
2012-08-01  8:29     ` [alsa-devel] " Sangbeom Kim
2012-08-01 13:12     ` Padma Venkat
2012-08-01 13:12       ` Padma Venkat
2012-07-25 12:09 ` [PATCH 2/2] ASOC: SAMSUNG: Add dma_prop variable in s3c_dma_params Padmavathi Venna
2012-07-25 12:09   ` Padmavathi Venna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='08da01cd6fbf$cd9b5c00$68d21400$@com' \
    --to=sbkim73@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ben-linux@fluff.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=joshi@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olofj@google.com \
    --cc=padma.v@samsung.com \
    --cc=rcsekar@samsung.com \
    --cc=sangsu4u.park@samsung.com \
    --cc=thutt@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.