Re: [PATCH mptcp-next 0/3] mptcp: improve ADD_ADDR timeout handling

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 29/07/2025 10:22, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This series optimizes MPTCP's ADD_ADDR retransmission timeout:
> 
> 1. Renames sysctl to add_addr_timeout_max for clearer semantics
> 2. Makes timeout adaptive to subflow RTT
> 3. Updates selftests for the rename
> 
> The adaptive timeout improves subflow establishment responsiveness
> while maintaining reliability through the max timeout cap. The rename
> provides better configuration clarity.

Thank you for working on that. I have some comments, please see the
individual patches.

> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/576

Better to (also) put that in the last patch closing the ticket, so
GitHub can automatically close it when this patch will be applied.

> Geliang Tang (3):
>   mptcp: rename add_addr_timeout to add_addr_timeout_max
>   mptcp: make ADD_ADDR timeout adaptive to subflow RTT
>   selftests: mptcp: update for add_addr_timeout_max rename
> 
>  Documentation/networking/mptcp-sysctl.rst     |  6 ++---
>  net/mptcp/ctrl.c                              | 12 ++++-----
>  net/mptcp/pm.c                                | 27 ++++++++++++++++---
>  net/mptcp/protocol.h                          |  2 +-
>  .../testing/selftests/net/mptcp/mptcp_join.sh |  8 +++---
>  5 files changed, 38 insertions(+), 17 deletions(-)
> 

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.