From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH 1/3] ASoC: (cosmetic) simplify dpcm_prune_paths()
Date: Mon, 9 Mar 2020 16:37:26 -0500 [thread overview]
Message-ID: <0a514b46-171c-78e7-aaa9-8f20b38e433a@linux.intel.com> (raw)
In-Reply-To: <20200309170749.32313-2-guennadi.liakhovetski@linux.intel.com>
On 3/9/20 12:07 PM, Guennadi Liakhovetski wrote:
> Currently dpcm_prune_paths() has up to 4 nested condition and loop
> levels, which forces the code to use flags for flow control.
> Extracting widget status verification code from dpcm_prune_paths()
> into a separate function simplifies the code.
>
> Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
The diff format makes it hard to review, but with --patience it looks
fine indeed and a nice code refactoring.
Minor comment below:
> + /* is there a valid CPU DAI widget for this BE */
> + for_each_rtd_cpu_dai(dpcm->be, i, dai) {
this will conflict with Morimoto-san's cleanup step6 shared today.
> + /* is there a valid CODEC DAI widget for this BE */
> + for_each_rtd_codec_dai(dpcm->be, i, dai) {
and this as well, will be _dais, not _dai.
next prev parent reply other threads:[~2020-03-09 22:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 17:07 [PATCH 0/3] [RESEND] ASoC: SOF: preparatory patches Guennadi Liakhovetski
2020-03-09 17:07 ` [PATCH 1/3] ASoC: (cosmetic) simplify dpcm_prune_paths() Guennadi Liakhovetski
2020-03-09 21:37 ` Pierre-Louis Bossart [this message]
2020-03-09 17:07 ` [PATCH 2/3] ASoC: add function parameters to enable forced path pruning Guennadi Liakhovetski
2020-03-09 21:48 ` Pierre-Louis Bossart
2020-03-10 12:45 ` Mark Brown
2020-03-11 7:41 ` Guennadi Liakhovetski
2020-03-11 12:25 ` Mark Brown
2020-03-11 12:36 ` Guennadi Liakhovetski
2020-03-11 12:41 ` Mark Brown
2020-03-11 13:26 ` Guennadi Liakhovetski
2020-03-09 17:07 ` [PATCH 3/3] ASoC: export DPCM runtime update functions Guennadi Liakhovetski
2020-03-09 21:54 ` [Sound-open-firmware] " Pierre-Louis Bossart
2020-03-09 22:05 ` [PATCH 0/3] [RESEND] ASoC: SOF: preparatory patches Pierre-Louis Bossart
2020-03-10 12:50 ` Mark Brown
2020-03-10 20:13 ` Pierre-Louis Bossart
2020-03-11 12:16 ` Mark Brown
2020-03-12 11:45 ` Guennadi Liakhovetski
2020-03-12 12:15 ` Mark Brown
2020-03-12 13:09 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a514b46-171c-78e7-aaa9-8f20b38e433a@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.