All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org,
	sound-open-firmware@alsa-project.org
Subject: Re: [PATCH 2/3] ASoC: add function parameters to enable forced path pruning
Date: Wed, 11 Mar 2020 08:41:27 +0100	[thread overview]
Message-ID: <20200311074126.GA4149@ubuntu> (raw)
In-Reply-To: <20200310124544.GE4106@sirena.org.uk>

Hi Mark,

On Tue, Mar 10, 2020 at 12:45:44PM +0000, Mark Brown wrote:
> On Mon, Mar 09, 2020 at 06:07:48PM +0100, Guennadi Liakhovetski wrote:
> 
> > soc_dpcm_runtime_update() to activate an audio path and update audio
> > routing. When streaming is stopped, the vhost driver calls
> > soc_dpcm_runtime_update() and snd_soc_runtime_deactivate(). The latter
> > doesn't work at the moment, because the DPCM doesn't recognise the
> > path as inactive. We address this by adding a "mode" parameter to
> > soc_dpcm_runtime_update(). If virtualisation isn't used, the current
> > behaviour isn't affected.
> 
> So why doesn't DPCM recognize that the path is inactive and why is it
> better to do this than fix whatever the issue is there?

Of course that would be better abd I'd much prefer that. Unfortunately I 
haven't been able to find a single scenario in which those paths would be 
exercised. As far as I understand path pruning should take place e.g. 
when a mixer modifies audio routing and as a result disables a certain 
pipeline, which is then pruned. If I could reproduce such a scenario I 
would be able to first check whether it's working, then see exactly how 
it is working and then see how best to add my use case to it. Since I 
wasn't able to find such a scenario, my only option was to preserve 
the current state and add my own path "on top." I'd be happy to try the 
other path too, I just need a use case, that I can reproduce.

Thanks
Guennadi

  reply	other threads:[~2020-03-11  7:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 17:07 [PATCH 0/3] [RESEND] ASoC: SOF: preparatory patches Guennadi Liakhovetski
2020-03-09 17:07 ` [PATCH 1/3] ASoC: (cosmetic) simplify dpcm_prune_paths() Guennadi Liakhovetski
2020-03-09 21:37   ` Pierre-Louis Bossart
2020-03-09 17:07 ` [PATCH 2/3] ASoC: add function parameters to enable forced path pruning Guennadi Liakhovetski
2020-03-09 21:48   ` Pierre-Louis Bossart
2020-03-10 12:45   ` Mark Brown
2020-03-11  7:41     ` Guennadi Liakhovetski [this message]
2020-03-11 12:25       ` Mark Brown
2020-03-11 12:36         ` Guennadi Liakhovetski
2020-03-11 12:41           ` Mark Brown
2020-03-11 13:26             ` Guennadi Liakhovetski
2020-03-09 17:07 ` [PATCH 3/3] ASoC: export DPCM runtime update functions Guennadi Liakhovetski
2020-03-09 21:54   ` [Sound-open-firmware] " Pierre-Louis Bossart
2020-03-09 22:05 ` [PATCH 0/3] [RESEND] ASoC: SOF: preparatory patches Pierre-Louis Bossart
2020-03-10 12:50   ` Mark Brown
2020-03-10 20:13     ` Pierre-Louis Bossart
2020-03-11 12:16       ` Mark Brown
2020-03-12 11:45     ` Guennadi Liakhovetski
2020-03-12 12:15       ` Mark Brown
2020-03-12 13:09         ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311074126.GA4149@ubuntu \
    --to=guennadi.liakhovetski@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=sound-open-firmware@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.