Re: [PATCH mptcp-net] selftests: mptcp: userspace_pm: fix undefined variable port

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 26/06/2026 09:04, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> In make_connection(), the variable "port" is used but never defined.
> This leads to an empty argument being passed to wait_local_port_listen(),
> causing "printf: : invalid number" errors:
> 
>  # INFO: Init
>  # 01 Created network namespaces ns1, ns2                          [ OK ]
>  # INFO: Make connections
>  # ./../lib.sh: line 651: printf: : invalid number
>  # 02 Established IPv4 MPTCP Connection ns2 => ns1                 [ OK ]
>  # INFO: Connection info: 10.0.1.2:59516 -> 10.0.1.1:50002
>  # ./../lib.sh: line 651: printf: : invalid number
>  # 03 Established IPv6 MPTCP Connection ns2 => ns1                 [ OK ]
> 
> Fix it by using the correctly defined variable "app_port", which holds the
> appropriate port number for the connection.

Thank you for the fix, and sorry for the delay!

Arf, I think remember I had this issue, and I thought I fixed it before
sending the patches, but no.

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

New patches for t/upstream-net and t/upstream:
- ebaa2571aeaa: selftests: mptcp: userspace_pm: fix undefined variable port
- Results: 4c2362a7db02..08c6392dbaf1 (export-net)
- Results: 4285a4fe811b..ea196b8ada26 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/1ef110cb2b759cde24642c71416460cd328469cf/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/9d33b57982424bae6bd4e53ffe848dc8043fc2d8/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.